[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #31 from Fedora Update System upda...@fedoraproject.org 2011-05-25 12:04:11 EDT --- toppler-1.1.5-1.el5.1 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|toppler-1.1.5-1.fc15|toppler-1.1.5-1.el5.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #32 from Fedora Update System upda...@fedoraproject.org 2011-05-25 12:07:53 EDT --- toppler-1.1.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|toppler-1.1.5-1.el5.1 |toppler-1.1.5-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #33 from Fedora Update System upda...@fedoraproject.org 2011-05-25 14:52:47 EDT --- toppler-1.1.5-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|toppler-1.1.5-1.el6 |toppler-1.1.5-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||toppler-1.1.5-1.fc15 Resolution||ERRATA Last Closed||2011-05-19 00:47:45 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2011-05-19 00:47:37 EDT --- toppler-1.1.5-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2011-05-06 02:57:30 EDT --- toppler-1.1.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/toppler-1.1.5-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2011-05-06 02:57:22 EDT --- toppler-1.1.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/toppler-1.1.5-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2011-05-06 02:57:15 EDT --- toppler-1.1.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/toppler-1.1.5-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2011-05-06 02:57:04 EDT --- toppler-1.1.5-1.el5.1 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/toppler-1.1.5-1.el5.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #29 from Fedora Update System upda...@fedoraproject.org 2011-05-06 21:31:39 EDT --- toppler-1.1.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #24 from Jason Tibbitts ti...@math.uh.edu 2011-05-05 11:29:10 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #22 from Hans de Goede hdego...@redhat.com 2011-05-04 04:54:47 EDT --- Looks good to me now, approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #23 from Xavier Bachelot xav...@bachelot.org 2011-05-04 05:09:03 EDT --- New Package SCM Request === Package Name: toppler Short Description: platform game Owners: xavierb Branches: f14 f15 el5 el6 InitialCC: Thanks again for the review and patches, Hans :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #20 from Hans de Goede hdego...@redhat.com 2011-05-03 04:22:56 EDT --- Created attachment 496450 -- https://bugzilla.redhat.com/attachment.cgi?id=496450 PATCH: no strncpy please for v 1.1.5 p.s. I test played a bit (completed the first tower) and I see no problems with v 1.1.5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #19 from Hans de Goede hdego...@redhat.com 2011-05-03 04:22:11 EDT --- Created attachment 496449 -- https://bugzilla.redhat.com/attachment.cgi?id=496449 Patch for proper shared highscore file rights handling for v 1.1.5 Hi, I've rebased my patches to 1.1.5, I've also made some slight changes to the highscores patch, to keep the filenames 100% identical to what they were, so it should be acceptable upstream. I'll send them upstream and put you in the CC. I'll also attached a rebased version of my strncpy patch. All other patches can be dropped, except for the toppler-1.1.3-move_hiscores one. Talking about that one since the toppler.hsc file must pre-exist so that it has the right owner, there is no need for a separate dir, so the proper value for pkglocalstatedir would be: pkglocalstatedir = $(localstatedir)/games Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #21 from Xavier Bachelot xav...@bachelot.org 2011-05-03 17:58:09 EDT --- Here are the updated spec and SRPM : http://www.bachelot.org/fedora/SPECS/toppler.spec http://www.bachelot.org/fedora/SRPMS/toppler-1.1.5-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #18 from Xavier Bachelot xav...@bachelot.org 2011-05-02 19:06:31 EDT --- Thanks Hans, this is much appreciated :-) toppler 1.1.5 has been released some time ago, I need to check if the issue I had with 1.1.4 have been fixed. Hopefully, your patches will still apply to 1.1.5. It could take me a bit of time to get that done as my spare time is sparse at the moment, but I'm still interested in getting this game into Fedora, so it will happen eventually. Ah, the good old C64 days :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #16 from Hans de Goede hdego...@redhat.com 2011-04-28 15:01:35 EDT --- Created attachment 495638 -- https://bugzilla.redhat.com/attachment.cgi?id=495638 Patch for proper shared highscore file rights handling Hi, First of all apologies for taking for ever to get around to this. If you take the attached patch, and drop the following 2 (which it obsoletes): toppler-1.1.3-create_hiscores_file.patch toppler-1.1.3-fix_highscore_lockfile_creation.patch Then the dropping of sgid games handling is handled properly, further you should also create (just a touch is enough) /var/games/toppler/toppler.hsc in the spec file and include it with the proper rights / owner. Otherwise it will get created with the first user starting toppler as owner which is not what we want. While working on this I also noticed the use of strncpy in highscore.cc strncpy is evil as it does not guarantee 0 termination. So I've also done a patch to replace it with snprintf, I'll attach that next. If you can do a new version with these patches integrated, then I'll aprove this package. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #17 from Hans de Goede hdego...@redhat.com 2011-04-28 15:02:43 EDT --- Created attachment 495639 -- https://bugzilla.redhat.com/attachment.cgi?id=495639 PATCH: no strncpy please -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #15 from Hans de Goede hdego...@redhat.com 2010-11-19 03:23:40 EST --- Hi, (In reply to comment #14) This review then fall off my radar, but I would still like to get toppler into Fedora. Great! I'll be glad if you can provide a patch fixing the outstanding highscore file issue. I'll put this on my todo and get back to you when I get around to it. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Flag|needinfo?(xav...@bachelot.o | |rg) | --- Comment #14 from Xavier Bachelot xav...@bachelot.org 2010-11-18 11:50:56 EST --- Thanks for the head up, Hans. The new upstream maintainer quickly disappeared after he released a new version against which I reported a number of issues as well as the highscore issue. I never packaged the new version given the issues I had with it and I'm rather happy with the old one. This review then fall off my radar, but I would still like to get toppler into Fedora. I'll be glad if you can provide a patch fixing the outstanding highscore file issue. Regards, Xavier -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524992] Review Request: toppler - platform game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524992 --- Comment #13 from Hans de Goede hdego...@redhat.com 2010-11-17 03:36:35 EST --- Hi Xavier, What is the status on this? Are you still waiting for a response from upstream wrt to highscore issue? Have you tried pinging upstream? If the highscore issue is the only blocker and you're still interested in getting toppler into Fedora, I can write a patch to fix the highscore issue I've done so for many other games already. Regards, Hans p.s. The way I plan on solving the highscore issue is using 1 file shared by all users under /var/games owned by group games, make the toppler binary sgid games, and make it open the file rw as fisr thing on startup, immediately followed by dropping the sgid rights, see: http://fedoraproject.org/wiki/SIGs/Games/Packaging -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
