[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Fedora Update System changed: What|Removed |Added Fixed In Version|lua-loop-2.3-0.2.beta.fc14 |lua-loop-2.3-0.2.beta.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #13 from Fedora Update System 2010-12-01 12:34:50 EST --- lua-loop-2.3-0.2.beta.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Fedora Update System changed: What|Removed |Added Fixed In Version|lua-loop-2.3-0.2.beta.fc13 |lua-loop-2.3-0.2.beta.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #12 from Fedora Update System 2010-11-26 16:07:22 EST --- lua-loop-2.3-0.2.beta.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #11 from Fedora Update System 2010-11-26 16:05:17 EST --- lua-loop-2.3-0.2.beta.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||lua-loop-2.3-0.2.beta.fc13 Resolution||ERRATA Last Closed||2010-11-26 16:05:23 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #8 from Fedora Update System 2010-11-16 09:04:31 EST --- lua-loop-2.3-0.2.beta.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/lua-loop-2.3-0.2.beta.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #9 from Fedora Update System 2010-11-16 09:04:38 EST --- lua-loop-2.3-0.2.beta.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lua-loop-2.3-0.2.beta.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #7 from Fedora Update System 2010-11-16 09:04:25 EST --- lua-loop-2.3-0.2.beta.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/lua-loop-2.3-0.2.beta.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2010-11-16 12:30:48 EST --- lua-loop-2.3-0.2.beta.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lua-loop'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/lua-loop-2.3-0.2.beta.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #6 from Jason Tibbitts 2010-11-16 08:05:24 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Michel Alexandre Salim changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Michel Alexandre Salim 2010-11-16 03:07:57 EST --- Thanks for the review! New Package SCM Request === Package Name: lua-loop Short Description: Class models for Lua Owners: salimma Branches: el5 el6 f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Jason Tibbitts changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jason Tibbitts 2010-11-15 19:37:24 EST --- Looks good, thanks. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526805
--- Comment #3 from Michel Alexandre Salim
2010-11-07 13:18:03 EST ---
Spec URL: http://salimma.fedorapeople.org/specs/funpl/lua-loop.spec
SRPM URL:
http://salimma.fedorapeople.org/specs/funpl/lua-loop-2.3-0.2.beta.fc14.src.rpm
Updated:
- scripts now installed in %%{_bindir}
I contemplated giving them a loop- prefix, but then LuaRocks install them
unprefixed, and they are generic enough to be usable to interoperate between
C code and *any* Lua module, not just loop.
One would assume that if there is any naming conflict, someone would have
fixed the Rocks specification by now!
- remove unneeded dependencies
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #2 from Michel Alexandre Salim 2010-11-07 12:52:06 EST --- Thanks for the review! EL-5 and EL-6 have reasonable Lua stacks, so (In reply to comment #1) > Just going over the old review tickets. This one builds fine and rpmlint is > silent. As expected for a ticket this old, there are some lines in the spec > which are unnecessary on modern Fedora (BuildRoot, first line of %install, the > entire %clean section) which I would recommend removing unless you plan to > target EPEL with the same spec. > EL-5 and -6 have decent Lua stacks (though -5 is a bit buggy right now), so it'd be nice to have this package there, yes. > I see a comment "# for checks" but I don't see any checks enabled and I don't > see anything that's obviously a test suite. Is there one? > Will investigate -- it's been a while! I suspect it comes from another Lua spec, for a package that does have a test suite. > Do you think that preloader.lua and precompiler.lua, which aren't in the > package-specific directory, are problematic? They don't conflict with > anything > but the names do seem quite generic. I don't know much about Lua, however, so > I'll defer to you. I'll compare it with the packaging done for LuaRocks (Lua's equivalent of CPAN) and get back to you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526805] Review Request: lua-loop - Class models for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Jason Tibbitts changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu Flag||fedora-review? --- Comment #1 from Jason Tibbitts 2010-11-02 15:30:49 EDT --- Just going over the old review tickets. This one builds fine and rpmlint is silent. As expected for a ticket this old, there are some lines in the spec which are unnecessary on modern Fedora (BuildRoot, first line of %install, the entire %clean section) which I would recommend removing unless you plan to target EPEL with the same spec. I see a comment "# for checks" but I don't see any checks enabled and I don't see anything that's obviously a test suite. Is there one? Do you think that preloader.lua and precompiler.lua, which aren't in the package-specific directory, are problematic? They don't conflict with anything but the names do seem quite generic. I don't know much about Lua, however, so I'll defer to you. * source files match upstream. sha256sum: 2c9000f5744ca84b6c0d58bd8fb1d8d71c2841b01a75b3b201a486f88ffda864 loop-2.3-beta.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: lua-loop-2.3-0.1.beta.fc15.noarch.rpm lua-loop = 2.3-0.1.beta.fc15 = /usr/bin/env lua >= 5.1 lua-lpeg >= 0.8.1 lua-loop-doc-2.3-0.1.beta.fc15.noarch.rpm lua-loop-doc = 2.3-0.1.beta.fc15 = lua-loop = 2.3-0.1.beta.fc15 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. ? maybe generically named files * code, not content. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
