[Bug 527492] Review Request: jilter - Sendmail milter protocol for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527492 --- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2010-11-05 13:08:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527492] Review Request: jilter - Sendmail milter protocol for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527492 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2010-11-05 13:51:45 --- Comment #6 from Orion Poplawski or...@cora.nwra.com 2010-11-05 13:51:45 EDT --- Checked in and built. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527492] Review Request: jilter - Sendmail milter protocol for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527492 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu Flag||fedora-review+ --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2010-11-04 14:41:03 EDT --- I don't normally review Java packages since I know very little about them. However, this has been sitting around for so long and the Java SIG folks are busy, so even though there's no possibility for me to test this, I'll review it. Builds fine (on F14 since rawhide is hosed today), rpmlint is silent. There's some stuff that's unnecessary on modern Fedora releases (BuildRoot:, buildroot cleaning in %install, the %clean section) which you can remove if you like. Of course, you can't if you intend to target EPEL with the same spec. Otherwise, I see no issues. * source files match upstream. sha256sum: a0f367f1103208e767b3e32e981ee4cdcc62f998cef1c455c11ac093288275b9 jilter-1.2-src.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (f14, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: jilter-1.2-2.fc14.noarch.rpm jilter = 1.2-2.fc14 = java jpackage-utils log4j jilter-javadoc-1.2-2.fc14.noarch.rpm jilter-javadoc = 1.2-2.fc14 = jpackage-utils * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files (except for the license text) * file permissions are appropriate. * code, not content. * %docs are not necessary for the proper functioning of the package. Java-specific bits: * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * javadocs are under _javadocdir. * ant called properly. * no wrapper script necessary. * gcj not called. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527492] Review Request: jilter - Sendmail milter protocol for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527492 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Orion Poplawski or...@cora.nwra.com 2010-11-04 15:16:03 EDT --- Thanks Jason! New Package SCM Request === Package Name: jilter Short Description: Sendmail milter protocol for Java Owners: orion Branches: f14 f13 el6 el5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527492] Review Request: jilter - Sendmail milter protocol for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527492 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status Whiteboard||BuildFails --- Comment #1 from Jason Tibbitts ti...@math.uh.edu 2010-11-03 13:03:22 EDT --- Fails to build for me on rawhide: runtests: BUILD FAILED /builddir/build/BUILD/jilter-1.2/build.xml:56: Problem: failed to create task or type junit Cause: the class org.apache.tools.ant.taskdefs.optional.junit.JUnitTask was not found. This looks like one of Ant's optional components. Action: Check that the appropriate optional JAR exists in -/usr/share/ant/lib -/builddir/.ant/lib -a directory added on the command line with the -lib argument Do not panic, this is a common problem. The commonest cause is a missing JAR. This is not a bug; it is a configuration problem Total time: 2 seconds A scratch build showing the failure: http://koji.fedoraproject.org/koji/taskinfo?taskID=2574543 Please clear the Whiteboard if providing a package that builds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527492] Review Request: jilter - Sendmail milter protocol for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527492 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status Whiteboard|BuildFails | --- Comment #2 from Orion Poplawski or...@cora.nwra.com 2010-11-03 13:19:36 EDT --- http://www.cora.nwra.com/~orion/fedora/jilter.spec http://www.cora.nwra.com/~orion/fedora/jilter-1.2-2.fc14.src.rpm * Wed Nov 3 2010 Orion Poplawski or...@cora.nwra.com - 1.2-2 - Add ant-junit to BR - Add log4j to Requires - Build and ship javadoc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
