[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.1.11-1.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #16 from Fedora Update System 2010-02-01 20:12:26 EST --- pynac-0.1.11-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #15 from Fedora Update System 2010-01-31 15:32:15 EST --- pynac-0.1.11-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pynac-0.1.11-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #14 from Thomas Spura 2010-01-31 15:30:25 EST --- (In reply to comment #12) > About Requires: pkgconfig > - Note that the rule "any packages containing pkgconfig .pc file > must have Requires: pkgconfig" is already removed on Fedora, see: > https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files FYI: The new guidelines doesn't say something, that pkgconfig is *not* allowed to be required. So I explicitely require it for now, because this version was approved above and will remove it again with the next update to a new version some time in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #13 from Kevin Fenzi 2010-01-31 13:15:29 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #12 from Mamoru Tasaka 2010-01-29 06:31:56 EST --- About Requires: pkgconfig - Note that the rule "any packages containing pkgconfig .pc file must have Requires: pkgconfig" is already removed on Fedora, see: https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines Well, actually I found that review guideline wiki page still leaves this as must item, however this is just not updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 Thomas Spura changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Thomas Spura 2010-01-29 06:15:39 EST --- Thanks for the review. New Package CVS Request === Package Name: pynac Short Description: manipulation of symbolic expressions Owners: tomspur Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #11 from Christoph Wickert 2010-01-29 06:16:18 EST --- (In reply to comment #8) > Not needed = no blocker at all ;) > > But requiring it now, till the guidelines hopefully change. It will only work with rpm >= 4.7.0, so the guidelines are unlikely to change any time soon. This is why it's still a MUST and therefor a blocker. Rule of thumb: Whatever is requiered for directory ownership should be listed in the spec explicitly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 David A. Wheeler changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #9 from David A. Wheeler 2010-01-28 18:32:08 EST --- My theory is, if it's a MUST in the guidelines, then it's required... even if it's automated. I checked; all of the comments above have now been addressed. Thanks!! I did a few checks to make sure the new version didn't add surprises. I rebuilt the new version. It whines with a lot of warnings, but it builds fine. rpmlint output for this version is the same as before (see comment 5), so that's fine: rpmlint pynac.spec ../RPMS/x86_64/pynac-* ../SRPMS/pynac-0.1.11-1.fc12.src.rpm pynac-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings. I also did a mock build to see if new dependencies were created: mock --rebuild ../SRPMS/pynac-0.1.11-1.fc12.src.rpm and it went fine. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529198
--- Comment #8 from Thomas Spura 2010-01-27
17:17:50 EST ---
Thanks for the review.
(In reply to comment #6)
> In short, the only issues I found were:
>
> * MUST: Each package must consistently use macros. [17]
>
> ISSUE.
> It uses $RPM_BUILD_ROOT and %{optflags}.
Now it is %{buildroot} and %{optflags}.
(In reply to comment #7)
> Just for completeness and because David asked to become a sponsor recently:
>
> (In reply to comment #6)
> > ISSUE. It has a .pc file, but no "Requires: pkgconfig".
>
> Strictly speaking this is not needed any longer because rpm nowadays detects
> this automatically:
Not needed = no blocker at all ;)
But requiring it now, till the guidelines hopefully change.
> Please add INSTALL='install -p' to 'make install...'
Done.
(Also updated to a new version.)
Spec URL: http://tomspur.fedorapeople.org/review/pynac.spec
SRPM URL: http://tomspur.fedorapeople.org/review/pynac-0.1.11-1.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 Christoph Wickert changed: What|Removed |Added Status|NEW |ASSIGNED CC||cwick...@fedoraproject.org --- Comment #7 from Christoph Wickert 2010-01-27 08:26:12 EST --- Just for completeness and because David asked to become a sponsor recently: (In reply to comment #6) > ISSUE. It has a .pc file, but no "Requires: pkgconfig". Strictly speaking this is not needed any longer because rpm nowadays detects this automatically: Processing files: pynac-devel-0.1.10-1.fc12.x86_64 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /usr/bin/pkg-config libpynac-0.1.so.10()(64bit) However I agree with David that the devel package should require pkgconfig explicitly. Please add INSTALL='install -p' to 'make install...' to preserve the original time stamps of the header files in the devel package. See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529198
--- Comment #5 from David A. Wheeler 2010-01-26
22:30:17 EST ---
Here's my formal review, using
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines - there are a few
issues, easily fixed.
* MUST: rpmlint must be run on every package. The output should be posted
in the review.[1]
$ rpmlint SPECS/pynac.spec RPMS/x86_64/pynac-*
SRPMS/pynac-0.1.10-1.fc12.src.rpm
pynac-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 1 warnings.
This is as noted above. It's a warning, not an error; documentation would be
really nice, but isn't strictly required.
* MUST: The package must be named according to the Package Naming
Guidelines.
OK.
* MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
OK
* MUST: The package must meet the Packaging Guidelines .
OK.
* MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
OK. GPLv2+.
* MUST: The License field in the package spec file must match the actual
license. [3]
OK. I did a spot-check of source code; in directory src/ginac
the files add.cpp and function.pl are clearly GPLv2+.
* MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
OK. COPYING has GPLv2.
* MUST: The spec file must be written in American English. [5]
OK
* MUST: The spec file for the package MUST be legible. [6]
OK
* MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK.
$ wget http://www.sagemath.org/packages/standard/pynac-0.1.10.spkg
$ sha256sum pynac-0.1.10.spkg ~/rpmbuild/SOURCES/pynac-0.1.10.spkg
547326b9af0130ed8891847deca58787b651f346cbf609b3b067176276a81b1b
pynac-0.1.10.spkg
547326b9af0130ed8891847deca58787b651f346cbf609b3b067176276a81b1b
/home/rpmbuilder/rpmbuild/SOURCES/pynac-0.1.10.spkg
* MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
OK. Works on x86_64 Fedora 12.
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
OK. It builds on all architectures, as shown by this koji build:
koji build --scratch dist-f12 ./pynac-0.1.10-1.fc12.src.rpm
$ koji build --scratch dist-f12 ./pynac-0.1.10-1.fc12.src.rpm
Uploading srpm: ./pynac-0.1.10-1.fc12.src.rpm
[] 100% 00:00:16 2.10 MiB 128.73 KiB/sec
Created task: 1947029
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1947029
Watching tasks (this may be safely interrupted)...
1947029 build (dist-f12, pynac-0.1.10-1.fc12.src.rpm): free
1947029 build (dist-f12, pynac-0.1.10-1.fc12.src.rpm): free -> open
(ppc05.phx2.fedoraproject.org)
1947030 buildArch (pynac-0.1.10-1.fc12.src.rpm, ppc): free
1947033 buildArch (pynac-0.1.10-1.fc12.src.rpm, i686): free
1947032 buildArch (pynac-0.1.10-1.fc12.src.rpm, ppc64): free
1947031 buildArch (pynac-0.1.10-1.fc12.src.rpm, x86_64): free
1947030 buildArch (pynac-0.1.10-1.fc12.src.rpm, ppc): free -> open
(ppc03.phx2.fedoraproject.org)
1947032 buildArch (pynac-0.1.10-1.fc12.src.rpm, ppc64): free -> open
(ppc09.phx2.fedoraproject.org)
1947033 buildArch (pynac-0.1.10-1.fc12.src.rpm, i686): free -> open
(x86-03.phx2.fedoraproject.org)
1947031 buildArch (pynac-0.1.10-1.fc12.src.rpm, x86_64): free -> open
(x86-06.phx2.fedoraproject.org)
1947033 buildArch (pynac-0.1.10-1.fc12.src.rpm, i686): open
(x86-03.phx2.fedoraproject.org) -> closed
0 free 4 open 1 done 0 failed
1947031 buildArch (pynac-0.1.10-1.fc12.src.rpm, x86_64): open
(x86-06.phx2.fedoraproject.org) -> closed
0 free 3 open 2 done 0 failed
1947032 buildArch (pynac-0.1.10-1.fc12.src.rpm, ppc64): open
(ppc09.phx2.fedoraproject.org) -> closed
0 free 2 open 3 done 0 failed
1947030 buildArch (pynac-0.1.10-1.fc12.src.rpm, ppc): open
(ppc03.phx2.fedoraproject.org) -> closed
0 free 1 open 4 done 0 failed
1947029 build (dist-f12, pynac-0.1.10-1.fc12.src.rpm): open
(ppc05.phx2.fedoraproject.org) -> closed
0 free 0 open 5 done 0 failed
* MUST: All build dependencies must be listed in BuildRequires, except for
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529198
--- Comment #6 from David A. Wheeler 2010-01-26
22:31:58 EST ---
In short, the only issues I found were:
* MUST: Each package must consistently use macros. [17]
ISSUE.
It uses $RPM_BUILD_ROOT and %{optflags}.
* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability). [22]
ISSUE. It has a .pc file, but no "Requires: pkgconfig".
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 David A. Wheeler changed: What|Removed |Added CC||dwhee...@dwheeler.com AssignedTo|nob...@fedoraproject.org|dwhee...@dwheeler.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529198] Review Request: pynac - manipulation of symbolic expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529198 --- Comment #4 from Thomas Spura 2010-01-15 15:49:12 EST --- $ rpmlint pynac-0.1.10-1.fc12.src.rpm x86_64/pynac-* pynac-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 1 warnings. %changelog - update to new version - use %%global and not %%define Spec URL: http://tomspur.fedorapeople.org/review/pynac.spec SRPM URL: http://tomspur.fedorapeople.org/review/pynac-0.1.10-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
