[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-05-28 13:59:41 EDT --- nitrogen-1.5.1-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||nitrogen-1.5.1-3.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nitrogen-1.5.1-3.fc13 |nitrogen-1.5.1-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-05-28 14:00:42 EDT --- nitrogen-1.5.1-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #15 from Kevin Fenzi ke...@tummy.com 2010-05-06 11:21:47 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Sandro Mathys s...@sandro-mathys.ch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Sandro Mathys s...@sandro-mathys.ch 2010-05-04 02:19:06 EDT --- Great! Thanks again for the review, John! New Package CVS Request === Package Name: nitrogen Short Description: Background browser and setter for X windows Owners: red Branches: F-12 F13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Gareth John gareth.l.j...@googlemail.com 2010-05-03 17:39:11 EDT --- OK point taken, also glad to see you cleaned up man file(s). All needswork done and looks good. I also had problem when using install -p. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530374
--- Comment #10 from Gareth John gareth.l.j...@googlemail.com 2010-05-01
12:54:52 EDT ---
Hi Sandro,
A few final touches to may be look at for you below.
NEEDSWORK===
MUST: The spec file for the package MUST be legibleNEEDSWORK
Excesive files could glob the paths i.e
FROM,
%{_datadir}/icons/hicolor/22x22/apps/nitrogen.png
%{_datadir}/icons/hicolor/32x32/apps/nitrogen.png
%{_datadir}/icons/hicolor/48x48/apps/nitrogen.png
TO,
%{_datadir}/icons/hicolor/*/apps/nitrogen.png
Consider macro?
FROM,
%{_datadir}/icons/hicolor/*/apps/nitrogen.png
TO,
%{_datadir}/icons/hicolor/*/apps/%{name}.png
MUST: Each package must consistently use macrosNEEDSWORK
Again consider macros when usable such as %{name}.desktop
MUST: The License field in the package spec file must match the actual
licenseOK [NEEDSWORK AS DISCUSSED, NOT A PROBLEM]
OK ===
MUST: rpmlint must be run on every package. The output should be posted in the
review...OK
MUST: The package must be named according to the Package Naming
GuidelinesOK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemptionOK
MUST: The package must meet the Packaging GuidelinesOK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing GuidelinesOK (Assumed as FE-LEGAL was lifted)
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %docOK
MUST: The spec file must be written in American EnglishOK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with thisOK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architectureOK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch lineN/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common senseOK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbiddenN/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postunN/A
MUST: Packages must NOT bundle copies of system librariesOK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blockerOK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directoryOK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listingsOK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) lineOK
MUST: The package must contain code, or permissable contentOK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity)OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not presentOK
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
packageN/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are builtN/A
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #11 from Gareth John gareth.l.j...@googlemail.com 2010-05-01 13:07:38 EDT --- Also change FROM: make install DESTDIR=$RPM_BUILD_ROOT TO: make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #12 from Sandro Mathys s...@sandro-mathys.ch 2010-05-01 15:25:10 EDT --- Spec URL: http://red.fedorapeople.org/SRPMS/nitrogen.spec SRPM URL: http://red.fedorapeople.org/SRPMS/nitrogen-1.5.1-2.fc12.src.rpm Thanks for the review, John. All NEEDSWORK done. But if I add the INSTALL thingy the build fails so I left this out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added CC||gareth.l.j...@googlemail.co ||m AssignedTo|nob...@fedoraproject.org|gareth.l.j...@googlemail.co ||m Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #8 from Gareth John gareth.l.j...@googlemail.com 2010-04-30 16:02:45 EDT --- ping! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #9 from Sandro Mathys s...@sandro-mathys.ch 2010-04-30 16:16:12 EDT --- pong! Well, the pkg is ready for review, feel free to do it. I'll change the license in the spec file with the next version to what spot said - don't see a reason to build and upload a new version just for that right now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235(FE-Legal)| --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2010-03-08 16:32:47 EST --- Umm, I'm assuming you are referring to src/md5.c, which is under the zlib license. The rest of the code is clearly marked as GPLv2+. The license tag should be: License: GPLv2+ and zlib and CC-BY-SA Lifting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 Sandro Mathys s...@sandro-mathys.ch changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #6 from Sandro Mathys s...@sandro-mathys.ch 2010-03-02 13:11:08 EST --- Blocking FE-Legal - spot, can you please look at this piece of software and clear for me what License: I should correctly define? See comment 5 about my uncertainties. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530374] Review Request: nitrogen - A background browser and setter for X windows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #5 from Sandro Mathys s...@sandro-mathys.ch 2010-02-05 03:49:56 EST --- Spec URL: http://red.fedorapeople.org/SRPMS/nitrogen.spec SRPM URL: http://red.fedorapeople.org/SRPMS/nitrogen-1.5.1-1.fc12.src.rpm Apologies for the long wait, $DAYJOB kept me really busy. Upstream releases 1.5 and 1.5.1 in the meanwhile fixing the icons' licensing issue after I spoke with them. I also included the hints from Ionuț in the new spec file. What is not clear yet to me is the licensing matter and I'd welcome any licensing expert's opinion (or if none available, I'll ask spot). While the icons are CC-BY-SA now, the code is either GPLv2 or GPLv2+ (not sure if this is stated clear enough in the sources). But the md5 code is under a different license which I'm not sure about. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
