[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=531107

Miroslav Suchý  changed:

   What|Removed |Added

  Flags|needinfo?(da...@fetter.org) |
   |needinfo?(da...@fetter.org) |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=531107

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 AssignedTo|mmasl...@redhat.com |nob...@fedoraproject.org
   Flag|fedora-review+  |fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

--- Comment #22 from Marcela Mašláňová mmasl...@redhat.com 2011-03-04 
08:15:41 EST ---
You've started a lot of reviews as I can see in bugzilla, but you've never
finished any. Why? You need to find someone, who will be your sponsor, which
means give you access to Fedora account system. 
I've added sponsorship request as blocker. For details about sponsorship see:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

In one of previous reviews you lost possible sponsor, so I'm not sure how
successful you'll be this time. (I'm not sponsor).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #21 from David Fetter da...@fetter.org 2011-03-03 18:32:53 EST ---
Done :)

http://fetter.org/~shackle/perl-SQL-Tokenizer.spec
http://fetter.org/~shackle/perl-SQL-Tokenizer-0.20-2.fc14.src.rpm

Re: sponsorship, not that I know of.  What's involved?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #20 from Marcela Mašláňová mmasl...@redhat.com 2011-03-02 
10:04:27 EST ---
(In reply to comment #19)
 Oops.  I'll try to get on this tonight.  How do I remove it?
 
 Cheers,
 David.

You should remove it in prep part of spec file.
rm -rf lib/SQL/._Tokenizer.pm

I must ask. Are you already sponsored in Fedora?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

David Fetter da...@fetter.org changed:

   What|Removed |Added

   Flag|needinfo?(da...@fetter.org) |
   |,   |
   |needinfo?(da...@fetter.org) |

--- Comment #19 from David Fetter da...@fetter.org 2011-03-01 16:05:25 EST ---
Oops.  I'll try to get on this tonight.  How do I remove it?

Cheers,
David.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||needinfo?(da...@fetter.org)

--- Comment #18 from Marcela Mašláňová mmasl...@redhat.com 2011-02-28 
10:26:57 EST ---
Ping?

If you are still interested in this package, could you remove the file
._Tokenizer.pm or comment, why it is needed? We could finish it in that case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||needinfo?(da...@fetter.org)

--- Comment #17 from Marcela Mašláňová mmasl...@redhat.com 2010-11-09 
11:09:59 EST ---
perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5
^ I suppose this is false positive. Key is not needed for functionality.

perl-SQL-Tokenizer.noarch: W: hidden-file-or-dir
/usr/share/perl5/vendor_perl/SQL/._Tokenizer.pm
This is installed. Is it needed? If not, could you remove it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #15 from Marcela Mašláňová mmasl...@redhat.com 2010-10-14 
03:04:35 EDT ---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #16 from David Fetter da...@fetter.org 2010-10-14 10:59:21 EDT ---
What is it you'd like done about them?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #14 from Marcela Mašláňová mmasl...@redhat.com 2010-10-04 
04:59:33 EDT ---
Could you comment these two issues:
perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5
perl-SQL-Tokenizer.noarch: W: hidden-file-or-dir
/usr/share/perl5/vendor_perl/SQL/._Tokenizer.pm
After resolving these two, it should be ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #13 from Marcela Mašláňová mmasl...@redhat.com 2010-07-28 
03:07:42 EDT ---
- rpmlint checks return:
perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5
OK
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPL+ or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english OK
- source matches upstream 0cd63eb036f81e22d1d58fc1f81beb5f OK
- package compiles on devel (x86) OK
- no missing BR OK
- no unnecessary BR OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #11 from Marcela Mašláňová mmasl...@redhat.com 2010-07-27 
03:45:01 EDT ---
SRPM can't be found.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #12 from David Fetter da...@fetter.org 2010-07-27 10:57:37 EDT ---
Oops. sorry. Wrong URL.  The correct URLs are:

http://fetter.org/~shackle/perl-SQL-Tokenizer.spec
http://fetter.org/~shackle/perl-SQL-Tokenizer-0.20-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com

--- Comment #9 from Marcela Mašláňová mmasl...@redhat.com 2010-07-26 04:39:38 
EDT ---
- rpmlint checks return: OK
perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5
 ^ looks like you've signed your package. This should be ok.
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPL+ or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english OK
- source matches upstream OK
- package compiles on devel (x86) OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2350781
- no missing BR OK
- no unnecessary BR NOT OK
 please remove Test::More from Requires. This is needed only during build.
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file  OK

Almost ok ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #10 from David Fetter da...@fetter.org 2010-07-26 13:05:17 EDT ---
Updated to 0.20, the current version, removed Test::More from Requires.  Newest
packages here:

http://fetter.org/~shackle/perl-SQL-Tokenizer.spec
http://fetter.org/~shackle/perl-SQL-Tokenizer-0.20-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #8 from David Fetter da...@fetter.org 2010-03-03 23:01:28 EST ---
Fixed :)

http://fetter.org/~shackle/perl-SQL-Tokenizer.spec
http://fetter.org/~shackle/perl-SQL-Tokenizer-0.19-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #5 from Steve Traylen steve.tray...@cern.ch 2010-02-13 11:29:34 
EST ---
Hi,
Looks easy to approve but a couple of comments.

I see no reason for including MANIFEST.bak in the resulting package.

The license is as perl so not just Artistic 2.0 see: 

http://fedoraproject.org/wiki/Packaging/Perl#License_tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #6 from David Fetter da...@fetter.org 2010-02-13 12:46:36 EST ---
Fixed :)

http://fetter.org/~shackle/perl-SQL-Tokenizer.spec
http://fetter.org/~shackle/perl-SQL-Tokenizer-0.19-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #4 from David Fetter da...@fetter.org 2010-02-11 04:27:39 EST ---
Sorry.  The machine was down for awhile.  Here are the updated spec and SRPM.

http://fetter.org/~shackle/perl-SQL-Tokenizer.spec
http://fetter.org/~shackle/perl-SQL-Tokenizer-0.19-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Steve Traylen steve.tray...@cern.ch changed:

   What|Removed |Added

 CC||steve.tray...@cern.ch

--- Comment #3 from Steve Traylen steve.tray...@cern.ch 2010-02-09 14:14:43 
EST ---
Yes, link still not working. Hangs, firewall?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

--- Comment #2 from Marcela Mašláňová mmasl...@redhat.com 2010-01-22 04:07:09 
EST ---
Link is not working.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review