[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
https://bugzilla.redhat.com/show_bug.cgi?id=533887 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2010-04-19 09:27:24 |2014-03-25 09:59:59 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 ELMORABITY Mohamed pikachu.2...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #13 from Victor Bogado bog...@bogado.net 2010-03-01 10:02:34 EST --- New Package CVS Request === Package Name: raw-thumbnailer Short Description: Nautilus file manager thumbnailer for RAW images Owners: bogado Branches: F-11 F-12 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #14 from Victor Bogado bog...@bogado.net 2010-03-01 10:03:04 EST --- Sorry about the duplication above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 Victor Bogado bog...@bogado.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Victor Bogado bog...@bogado.net 2010-03-01 10:01:31 EST --- New Package CVS Request === Package Name: raw-thumbnailer Short Description: IDE for MCS-51 based microcontrollers Owners: bogado Branches: F-11 F-12 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #15 from Jason Tibbitts ti...@math.uh.edu 2010-03-01 11:54:16 EST --- CVS done (by process-cvs-requests.py). I added an F-13 branch since that seems to have been left out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533887
ELMORABITY Mohamed pikachu.2...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #11 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-02-25
19:05:39 EST ---
* MUST: rpmlint must be run on every package. The output should be posted in
the review.
OK
* MUST: The package must be named according to the Package Naming Guidelines .
OK
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
* MUST: The package must meet the Packaging Guidelines
OK
* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
OK (GPLv2 or more)
* MUST: The License field in the package spec file must match the actual
license.
OK (source code checked)
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK
* MUST: The spec file must be written in American English.
OK
* MUST: The spec file for the package MUST be legible.
OK
* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK (RPM source archive has the same MD5 sum than the one downloaded:
8b166320b17fa906bf0503ed3b6ba226)
* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK (tested on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2014878 and
http://koji.fedoraproject.org/koji/taskinfo?taskID=2014869)
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
N/A
* MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
* MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A
* MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
N/A
* MUST: Packages must NOT bundle copies of system libraries.
OK
* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
N/A
* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
OK
* MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK
* MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK
* MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
OK
* MUST: Each package must consistently use macros.
OK
* MUST: The package must contain code, or permissable content.
OK
* MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
N/A
* MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
OK
* MUST: Header files must be in a -devel package.
N/A
* MUST: Static libraries must be in a -static package.
N/A
* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
N/A
* MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
N/A
* MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #10 from Victor Bogado bog...@bogado.net 2010-02-22 09:01:38 EST --- This change does changes the warning on the rpmlint exit, but I will take your advice on comment #6 and ignore it. The update rpms are linked below : Spec URL: http://static.bogado.net/rpm/raw-thumbnailer.spec SRPM URL: http://static.bogado.net/rpm/raw-thumbnailer-0.99.1-5.bog12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=533887
--- Comment #9 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-02-15
16:00:14 EST ---
It looks very nice :-)
Two few modifications and I will approve your package:
* don't forget to correct the License tag, as said above: GPLv2+ instead of
GPLv2,
* finally the GConf schema files don't need to be tagged as %config files,
according to some recent reviews. So you should even remove the %config tag in
the line:
%config %{_sysconfdir}/gconf/schemas/%{name}.schemas
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #8 from Victor Bogado bog...@bogado.net 2010-02-08 07:55:55 EST --- Made the changes, I did not yet tested them, since I don't have full access to my fedora machine right now (just a ssh connection) but it did compiled well, and passed the rpmlint test (with the exception of the false positive you noted above). Spec URL: http://static.bogado.net/rpm/raw-thumbnailer.spec SRPM URL: http://static.bogado.net/rpm/raw-thumbnailer-0.99.1-4.bog12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #7 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-02-07 18:03:16 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #5 from Victor Bogado bog...@bogado.net 2010-01-27 11:31:11 EST --- There, the links with the changes appointed by ALMORABITY Mohamed : Spec URL: http://static.bogado.net/rpm/raw-thumbnailer.spec SRPM URL: http://static.bogado.net/rpm/raw-thumbnailer-0.99.1-3.bog12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #3 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-01-26 02:58:45 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #4 from Victor Bogado bog...@bogado.net 2010-01-26 12:18:16 EST --- Ops, I am looking into it, I believe that I even made the specs and rpms fixing those issues. But since I am having some problems with time I didn't uploaded them yet, sorry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
