[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #23 from Fedora Update System 2010-05-24 15:37:42 EDT --- lv2-c++-tools-1.0.3-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Fedora Update System changed: What|Removed |Added Fixed In Version|lv2-c++-tools-1.0.3-3.fc13 |lv2-c++-tools-1.0.3-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Fedora Update System changed: What|Removed |Added Fixed In Version|lv2-c++-tools-1.0.3-3.fc11 |lv2-c++-tools-1.0.3-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #22 from Fedora Update System 2010-05-24 15:36:32 EDT --- lv2-c++-tools-1.0.3-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||lv2-c++-tools-1.0.3-3.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #21 from Fedora Update System 2010-05-24 15:35:08 EDT --- lv2-c++-tools-1.0.3-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #20 from Fedora Update System 2010-05-15 16:43:43 EDT --- lv2-c++-tools-1.0.3-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lv2-c++-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/lv2-c++-tools-1.0.3-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #19 from Fedora Update System 2010-05-15 16:42:33 EDT --- lv2-c++-tools-1.0.3-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lv2-c++-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/lv2-c++-tools-1.0.3-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #18 from Fedora Update System 2010-05-15 16:40:50 EDT --- lv2-c++-tools-1.0.3-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lv2-c++-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/lv2-c++-tools-1.0.3-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #17 from Fedora Update System 2010-05-13 21:24:18 EDT --- lv2-c++-tools-1.0.3-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/lv2-c++-tools-1.0.3-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #15 from Fedora Update System 2010-05-13 21:23:11 EDT --- lv2-c++-tools-1.0.3-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/lv2-c++-tools-1.0.3-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #16 from Fedora Update System 2010-05-13 21:23:13 EDT --- lv2-c++-tools-1.0.3-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/lv2-c++-tools-1.0.3-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #14 from Dennis Gilmore 2010-05-13 18:30:54 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Orcan 'oget' Ogetbil changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Orcan 'oget' Ogetbil 2010-05-13 05:31:23 EDT --- Sure. I just sent an email upstream. Thanks for the review. New Package CVS Request === Package Name: lv2-c++-tools Short Description: Support library for writing LV2 plugins in C++ Owners: oget Branches: F-11 F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 David Cornette changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from David Cornette 2010-05-13 01:33:44 EDT --- Looks pretty good. Ideally there would be man pages for lv2peg and lv2soname. Just yesterday, someone announced an intent to package this for Debian (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=581419 ) so when that is done you can grab them from there. In the meantime, you can send an email to upstream asking them for the man pages. That is not a blocker, so this package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 David Cornette changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 David Cornette changed: What|Removed |Added CC||r...@davidcornette.com AssignedTo|nob...@fedoraproject.org|r...@davidcornette.com --- Comment #11 from David Cornette 2010-04-30 18:09:20 EDT --- I'll review this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 David Cornette changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #10 from Orcan 'oget' Ogetbil 2010-04-10 20:31:45 EDT --- Michael, is this package under your review? We have two other packages waiting for this package. One of them is David Cornette's EQ10Q package. He needs to be sponsored, but in order to do that we need to get this package in. (No obligations, I am just asking.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 David Cornette changed: What|Removed |Added Blocks||581104 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #9 from Orcan 'oget' Ogetbil 2010-02-21 16:22:11 EST --- okay, I updated the package, and added a virtual provides. SPEC: http://oget.fedorapeople.org/review/lv2-c++-tools.spec SRPM: http://oget.fedorapeople.org/review/lv2-c++-tools-1.0.3-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #8 from Michael Schwendt 2010-02-21 14:50:24 EST --- Okay, static by design then (both libs make use of C "static" storage). You would still need to follow the guidelines and create a virtual -static package: http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 | If (and only if) a package has shared libraries which require | static libraries to be functional, the static libraries can be | included in the *-devel subpackage. The devel subpackage must | have a virtual Provide for the *-static package, and packages | dependent on it must BuildRequire the *-static package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Orcan 'oget' Ogetbil changed: What|Removed |Added Blocks||567028 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #7 from Orcan 'oget' Ogetbil 2010-02-20 05:19:54 EST --- Hi, I got a hold of the project developer and he requested me to leave the two libraries static, as otherwise things might break. Here is what he says: > Well, I don't think I'll ever make the libraries shared by default - > there are reasons for having them static other than ABI instability. I > don't think that the gain in file size and maintainability in separating > such a tiny piece of code (two 2-line functions and one 3-line function > for liblv2-plugin.a, one 2-line function and one 4-line function for > liblv2-gui.a) justifies the additional annoyance of having an extra > runtime dependency for every plugin built using the libraries (more of > an annoyance for people who build from source than for those who use > package managers obviously). > > Also, when looking at the code I remembered a reason why it's not a good > idea to build the current code as shared libraries. liblv2-plugin.a > contains a symbol, LV2::get_lv2_descriptors()::descriptors, which is a > list of plugin descriptors for all the plugins in that plugin library. > If liblv2-plugin is shared that symbol would be shared by all plugin > libraries that a host has loaded, which would cause two problems: > > 1) Since all the plugin descriptors would end up in the same list, it >would appear to the host as if every plugin library contained every >plugin, which could possibly break things and definitely confuse >diagnostic tools, and > 2) the code that accesses that list is not threadsafe, and the LV2 >spec only guarantees that plugin discovery calls are not >executed simultaneously by the host for plugins in the same >library, so having a shared list for all libraries could >potentially corrupt memory. > > liblv2-gui.a has a similar problem. I removed my hacks and I am building the two libraries static. SPEC: http://oget.fedorapeople.org/review/lv2-c++-tools.spec SRPM: http://oget.fedorapeople.org/review/lv2-c++-tools-1.0.3-2.fc12.src.rpm Some notes: - I removed the -fno-var-tracking-assignments hack too. gcc seems fixed now. It takes a little while to compile still. But it doesn't hang. - There are two static (liblv2-gui.a, liblv2-plugin.a) and one shared (libpag.so) library. I didn't make a static subpackage since the contents of the .a files are not the same as the content of the .so file. Is this okay? What is your opinion? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #6 from Orcan 'oget' Ogetbil 2010-01-30 19:33:24 EST --- Sorry the SRPM URL should be http://oget.fedorapeople.org/review/lv2-c++-tools-1.0.3-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 --- Comment #5 from Orcan 'oget' Ogetbil 2010-01-30 19:31:30 EST --- Spec URL: http://oget.fedorapeople.org/review/lv2-c++-tools.spec SRPM URL: http://oget.fedorapeople.org/review/lv2-c++-tools-1.0.3-1.fc11.src.rpm Updated to 1.0.3. Not much changed softwarewise. I added a patch that fixes bunch of warnings about some boost headers. The patch is sent upstream. I also worked around the compiler bug with the -fno-var-tracking-assignments flag. As for the static/dynamic library, I asked upstream about this and I am waiting for their response. But I vote for going for dynamic libraries. Not much software depends on this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
