[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Fedora Update System changed: What|Removed |Added Fixed In Version|rhnmd-5.3.8-1.fc14 |rhnmd-5.3.8-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #16 from Fedora Update System 2011-03-31 16:05:50 EDT --- rhnmd-5.3.8-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Fedora Update System changed: What|Removed |Added Fixed In Version||rhnmd-5.3.8-1.fc14 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #15 from Fedora Update System 2011-03-31 12:56:16 EDT --- rhnmd-5.3.8-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Miroslav Suchý changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-03-15 06:40:55 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #14 from Fedora Update System 2011-03-15 06:38:30 EDT --- rhnmd-5.3.8-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rhnmd-5.3.8-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #13 from Fedora Update System 2011-03-15 06:37:44 EDT --- rhnmd-5.3.8-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rhnmd-5.3.8-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #12 from Jason Tibbitts 2011-03-14 19:14:04 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Ruediger Landmann changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|r.landm...@redhat.com Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #11 from Jason Tibbitts 2011-03-14 11:36:26 EDT --- This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Miroslav Suchý changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Miroslav Suchý 2011-03-14 02:22:53 EDT --- New Package CVS Request === Package Name: rhnmd Short Description: Red Hat Network Monitoring Daemon Owners: msuchy Branches: F-14, F-15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Ruediger Landmann changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Ruediger Landmann 2011-03-13 22:08:26 EDT --- Thanks Miroslav -- all looks good now. Please go ahead and make your SCM request ACCEPT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Miroslav Suchý changed: What|Removed |Added Flag|needinfo?(msu...@redhat.com | |) | --- Comment #8 from Miroslav Suchý 2011-03-10 04:21:12 EST --- Fixed in spacewalk.git commits: 7fda56e92719610c8e0fc14573a5111ada66e438 648558e2835ec6cbe31b12bbf44f1c7297914e81 Spec: http://miroslav.suchy.cz/fedora/rhnmd/rhnmd.spec src.rpm: http://miroslav.suchy.cz/fedora/rhnmd/rhnmd-5.3.8-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #7 from Jan Pazdziora 2011-03-10 02:28:25 EST --- (In reply to comment #6) > > On the other hand, because this package is new to Fedora, I question whether > you need to obsolete these at all -- how many Fedora machines are likely to > have the arch-specific versions of the packages installed on them? The package was shipped by Spacewalk project for Fedora in the past. So you may well have installations of old non-Fedora package and now upgrade with package that made it to Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Ruediger Landmann changed: What|Removed |Added Flag||needinfo?(msu...@redhat.com ||) --- Comment #6 from Ruediger Landmann 2011-03-10 01:46:18 EST --- Thanks: looks good except for: rhnmd.spec:19: W: unversioned-explicit-obsoletes rhnmd.i386 rhnmd.spec:20: W: unversioned-explicit-obsoletes rhnmd.x86_64 rhnmd.spec:19: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 19) rhnmd.noarch: W: obsolete-not-provided rhnmd.i386 rhnmd.noarch: W: obsolete-not-provided rhnmd.x86_64 If you're going to obsolete the arch-specific versions of the packages, you should also 1. specify the last version of the arch-specific packages 2. add corresponding "Provides:" for the arch-specific packages On the other hand, because this package is new to Fedora, I question whether you need to obsolete these at all -- how many Fedora machines are likely to have the arch-specific versions of the packages installed on them? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Miroslav Suchý changed: What|Removed |Added Flag|needinfo?(msu...@redhat.com | |) | --- Comment #5 from Miroslav Suchý 2011-03-09 03:05:06 EST --- There was only small change: Spec: http://miroslav.suchy.cz/fedora/rhnmd/rhnmd.spec src.rpm: http://miroslav.suchy.cz/fedora/rhnmd/rhnmd-5.3.7-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=538057
Ruediger Landmann changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||r.landm...@redhat.com
Flag||fedora-review?,
||needinfo?(msu...@redhat.com
||)
--- Comment #4 from Ruediger Landmann 2011-03-08
23:09:49 EST ---
Thanks Miroslav for attending to the issues that Christoph raised, or
explaining why you would not do so.
The package looks good now, but because it has been over a year with no more
review, I note that there is a new version available upstream. I assume it is
this version that you want to ship, so please generate a new SRPM based on
5.3.7 and I will approve it if no new issues appear.
Cheers
Rudi
- = N/A
/ = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[/] Rpmlint output is clean:
$ rpmlint SPECS/rhnmd.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/rhnmd-5.3.5-1.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/rhnmd-5.3.5-1.fc14.noarch.rpm
rhnmd.noarch: W: dangling-relative-symlink /usr/sbin/rhnmd sshd
rhnmd.noarch: E: non-readable /var/lib/nocpulse/.ssh/authorized_keys 0600L
rhnmd.noarch: W: hidden-file-or-dir /var/lib/nocpulse/.ssh
rhnmd.noarch: E: non-standard-dir-perm /var/lib/nocpulse/.ssh 0700L
rhnmd.noarch: W: hidden-file-or-dir /var/lib/nocpulse/.ssh
rhnmd.noarch: W: no-manual-page-for-binary rhnmd
rhnmd.noarch: W: dangerous-command-in-%pre rm
rhnmd.noarch: W: service-default-enabled /etc/rc.d/init.d/rhnmd
rhnmd.noarch: W: service-default-enabled /etc/rc.d/init.d/rhnmd
1 packages and 0 specfiles checked; 2 errors, 7 warnings.
* all these issues have already been discussed and explained. It would be nice
to have at least a basic manpage in there, even if it referred to other
Spacewalk documentation for more detail, but I don't consider this a blocker.
[/] Package is named according to the Package Naming Guidelines.
[/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[/] Package meets the Packaging Guidelines including the Language specific
items
[/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[/] License field in the package spec file matches the actual license.
License type: GPLv2
[/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[/] Spec file is legible and written in American English.
[/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
(md5sum 87d7f27b7ddcd1c1140192fb6ac746c0)
[/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2896478
[/] Package is not known to require ExcludeArch
[/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly (with the %find_lang macro)
[-] ldconfig called in %post and %postun if required.
[/] Package does not bundle copies of system libraries
[/] Package is not relocatable.
[/] Package must own all directories that it creates.
[/] Package does not contain duplicates in %files.
[/] Permissions on files are set properly
[/] %files section includes a %defattr(...) line
[/] Package consistently uses macros.
[-] Large documentation files are in a -doc subpackage, if required.
[/] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -static subpackage, if present.
[-] Development .so files in -devel subpackage, if present.
[-] -devel packages require base package with full versioning.
[/] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[/] Package does not own files or directories owned by other packages.
[/] Filenames are valid UTF-8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Tomas Lestach changed: What|Removed |Added Blocks|653453(space13) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Tomas Lestach changed: What|Removed |Added Blocks||674675(space14) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Jan Pazdziora changed: What|Removed |Added CC||jpazdzi...@redhat.com Blocks|623772(space12) |653453(space13) --- Comment #3 from Jan Pazdziora 2010-11-19 11:19:07 EST --- Moving to space13. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Milan Zazrivec changed: What|Removed |Added Blocks|585232(space11) |623772(space12) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Miroslav Suchý changed: What|Removed |Added Blocks|582354(space10) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Miroslav Suchý changed: What|Removed |Added Blocks||585232(space11) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 538057] Review Request: rhnmd - Red Hat Network Monitoring Daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 Justin Sherrill changed: What|Removed |Added Blocks||582354(space10) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
