[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=540996 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=540996 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Branch exists? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=540996 Tomas Hrcka thr...@redhat.com changed: What|Removed |Added CC||thr...@redhat.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Tomas Hrcka thr...@redhat.com --- Package Change Request == Package Name: rubygem-ffi New Branches: epel7 Owners: bkearney vondruch humaton -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 Bryan Kearney bkear...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2010-02-19 13:57:47 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=540996
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-17
11:58:32 EST ---
Well,
- Requires: libffi = 3.0.5 is not needed because libffi in currently
supported Fedora branch (i.e. F-11/12/13/14) all satisfy this version,
and libffi.so.X dependency is automatically detected.
(see the last sentence of below:
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires )
- %dir %{geminstdir} is also needed
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
- The first %defattr(-,root,root,-) is enough. The second %defattr
is redundant.
Please fix these when importing this package into Fedora CVS.
---
This package (rubygem-ffi) is APPROVED by mtasaka
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 Bryan Kearney bkear...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Bryan Kearney bkear...@redhat.com 2010-02-17 13:23:58 EST --- New Package CVS Request === Package Name: rubygem-ffi Short Description: Foreign Function Interface package for Ruby Owners: bkearney Branches: devel, F-13, F-12, F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=540996
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-16
12:30:28 EST ---
Well,
* Latest version
- $ gem list -r ffi returns that the latest version is 0.6.2.
* Duplicate files
- build.log shows:
---
6047 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/ffi-0.5.4/LICENSE
6048 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/ffi-0.5.4/README.rdoc
---
Please fix these (note that these files should be marked
as %doc , so %doc %{geminstdir}/README.rdoc line (and so on)
should not be removed)
! Note
- Please change the release number every time you modify your srpm
(when version number does not change) to avoid confusion.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 Bryan Kearney bkear...@redhat.com changed: What|Removed |Added Flag|needinfo?(bkear...@redhat.c | |om) | --- Comment #6 from Bryan Kearney bkear...@redhat.com 2010-02-15 11:28:43 EST --- Sorry.. $DAYJOB took over. I have updated the spec file. Latest files: SRPM: http://bkearney.fedorapeople.org/rubygem-ffi-0.5.4-1.fc12.src.rpm SPEC File: http://bkearney.fedorapeople.org/rubygem-ffi.spec rpmlint output: [bkear...@localhost i686]$ rpmlint * rubygem-ffi.i686: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/ffi-0.5.4/.require_paths 2 packages and 0 specfiles checked; 0 errors, 1 warnings. koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1988494 Specific comments: (In reply to comment #4) Some notes: * %define - %global - We now prefer to use %global %instead of %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Done. * Requires - Please use Requires: rubygem(rake-compiler) style, ref: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * strip / debuginfo rpm - Don't use ELF binary by yourself and create debuginfo rpm correctly. ! Note To create debuginfo rpm correctly, you have to compile C source under %_builddir ( i.e. when rubygem contains C extention library, you cannot install gem file into %buildroot directly. You have to once install gem file under directory created by %setup and then copy the whole tree to %buildroot for correct debuginfo rpm creation: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C ) I will be honest, I do not understand the value here. But I believe the new spec file to be in line with these requirements. ! Note 2 Also, build log shows that compilation of C source to create libffi_c.so is executed both under %_builddir and %buildroot, this is just redundant. Should only be done in %_builddir * macro usage - %ruby_sitelib macro seems to be used nowhere and unneeded. removed. - Please use the defined %geminstdir also in %files done. - You should not use %buildroot vs $RPM_BUILD_ROOT, %optflags vs $RPM_OPT_FLAGS with mixed style and should choose one style. https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS done * Documents location -- %doc README.rdoc LICENSE History.txt -- - These files should be installed under %geminstdir (in fact 2 of them are already installed). Also document files under %geminstdir should be marked as %doc properly. updated. Thank you for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(bkear...@redhat.c ||om) --- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-12 10:49:02 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 --- Comment #3 from Bryan Kearney bkear...@redhat.com 2010-02-01 08:02:11 EST --- Happy to. Updated spec file and SRPM can be found at: http://bkearney.fedorapeople.org/rubygem-ffi.spec http://bkearney.fedorapeople.org/rubygem-ffi-0.5.4-1.fc12.src.rpm rpmlint output is below: [bkear...@localhost rpmbuild]$ rpmlint SPECS/rubygem-ffi.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [bkear...@localhost rpmbuild]$ rpmlint SRPMS/rubygem-ffi-0.5.4-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [bkear...@localhost rpmbuild]$ Koji build can be found at: http://koji.fedoraproject.org/koji/taskinfo?taskID=1956147 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 --- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-01 11:37:09 EST --- Some notes: * %define - %global - We now prefer to use %global %instead of %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * Requires - Please use Requires: rubygem(rake-compiler) style, ref: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * strip / debuginfo rpm - Don't use ELF binary by yourself and create debuginfo rpm correctly. ! Note To create debuginfo rpm correctly, you have to compile C source under %_builddir ( i.e. when rubygem contains C extention library, you cannot install gem file into %buildroot directly. You have to once install gem file under directory created by %setup and then copy the whole tree to %buildroot for correct debuginfo rpm creation: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C ) ! Note 2 Also, build log shows that compilation of C source to create libffi_c.so is executed both under %_builddir and %buildroot, this is just redundant. * macro usage - %ruby_sitelib macro seems to be used nowhere and unneeded. - Please use the defined %geminstdir also in %files - You should not use %buildroot vs $RPM_BUILD_ROOT, %optflags vs $RPM_OPT_FLAGS with mixed style and should choose one style. https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS * Documents location -- %doc README.rdoc LICENSE History.txt -- - These files should be installed under %geminstdir (in fact 2 of them are already installed). Also document files under %geminstdir should be marked as %doc properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540996 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-01-31 09:54:59 EST --- Well, currently newest ffi seems 0.5.4. Would you upgrade your srpm first? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
