[Bug 543689] Package review: libipathverbs - Driver library for libibverbs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543689 Doug Ledford dledf...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-03 16:00:17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543689] Package review: libipathverbs - Driver library for libibverbs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543689 --- Comment #7 from Kevin Fenzi ke...@tummy.com 2010-07-12 13:15:02 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543689] Package review: libipathverbs - Driver library for libibverbs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543689 Doug Ledford dledf...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Doug Ledford dledf...@redhat.com 2010-07-09 13:34:55 EDT --- Michael, thanks for the review. Rel-eng: I'd like an F-13 and devel branch for the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543689] Package review: libipathverbs - Driver library for libibverbs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543689 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #5 from Kevin Fenzi ke...@tummy.com 2010-07-09 14:15:54 EDT --- Please add a cvs template here (see http://fedoraproject.org/wiki/CVS_admin_requests ) and reset the fedora-cvs flag to ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543689] Package review: libipathverbs - Driver library for libibverbs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543689 Doug Ledford dledf...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Doug Ledford dledf...@redhat.com 2010-07-09 15:11:26 EDT --- New Package CVS Request === Package Name: libipathverbs Short Description: Hardware driver for QLogic iPath hardware, used by libibverbs Owners: dledford Branches: F-13,devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543689] Package review: libipathverbs - Driver library for libibverbs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mschwe...@gmail.com
AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com
Flag||fedora-review+
--- Comment #3 from Michael Schwendt mschwe...@gmail.com 2010-06-24 08:08:50
EDT ---
* Correct Source URL would be:
http://www.openfabrics.org/downloads/libipathverbs/libipathverbs-1.2.tar.gz
$ sha1sum libipathverbs-1.2.tar.gz
462c07f85b4d568ef72846865ee48ba0af4bb015 libipathverbs-1.2.tar.gz
Provides: %{name}-devel = %{version}-%{release}
Nowadays, automatic package name Provides would also add a second
target-specific Provides for %{?_isa}, so also adding that one to explicit
Provides would make sense:
%if no%{?_isa} != no
Provides: %{name}-devel%{_isa} = %{version}-%{release}
%endif
* openSUSE also build the package for 32-bit and only ExcludeArch: s390
s390x. A .spec comment explaining your ExlusiveArch: x86_64 would be
helpful.
The spec file included in the tarball is not excluding x86 either. But it may
be mistaken, since it also marks /etc/libibverbs.d/ipath.driver as %config,
which you've said would be incorrect.
* Verified:
$ repoquery --whatprovides /etc/libibverbs.d
libibverbs-0:1.1.3-4.fc13.i686
libibverbs-0:1.1.3-4.fc13.x86_64
Directory meanwhile is owned correctly by libiverbs.
* ldconfig calls not needed. They would be useless due to the chosen driver
library SONAME.
* Placement of the static driver lib in a separate -static subpackage follows
the packaging guidelines.
* There are three other libibverbs-driver packages, which are packaged in the
same way. Things mentioned in this comment could be fixed in fedora pkg cvs,
so:
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
