[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #21 from Fedora Update System 2010-09-25 01:34:06 EDT --- procServ-2.5.1-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Fedora Update System changed: What|Removed |Added Fixed In Version|procServ-2.5.1-3.fc13 |procServ-2.5.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #20 from Fedora Update System 2010-09-23 00:58:21 EDT --- procServ-2.5.1-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||procServ-2.5.1-3.fc13 Resolution||ERRATA Last Closed||2010-09-23 00:58:26 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System 2010-09-15 01:23:19 EDT --- procServ-2.5.1-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update procServ'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/procServ-2.5.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #17 from Fedora Update System 2010-09-14 11:30:35 EDT --- procServ-2.5.1-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/procServ-2.5.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #18 from Fedora Update System 2010-09-14 11:30:42 EDT --- procServ-2.5.1-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/procServ-2.5.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #16 from Kevin Fenzi 2010-09-10 14:43:29 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Ralph Lange changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Ralph Lange 2010-09-10 09:31:30 EDT --- New Package SCM Request === Package Name: procServ Short Description: Process server with telnet console and log access Owners: ralphlange Branches: f13 f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547832
Martin Gieseking changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #14 from Martin Gieseking 2010-09-10
02:10:46 EDT ---
Hi Ralph,
welcome to the packager group. I hope you'll enjoy maintaining and reviewing
packages for Fedora.
Your procServ package is ready now, so we can finish here. The next step is to
request a git repository with the distro branches you're planning to maintain:
https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
$ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm
procServ.src: W: spelling-error %description -l en_US conserver -> conserve,
conserves, conserved
procServ.src: W: spelling-error %description -l en_US localhost -> local host,
local-host, localism
procServ.x86_64: W: spelling-error %description -l en_US conserver -> conserve,
conserves, conserved
procServ.x86_64: W: spelling-error %description -l en_US localhost -> local
host, local-host, localism
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
The above spelling errors can be ignored.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum procServ-2.5.1.tar.gz*
a6d3131361189458fc276ca4323efe46 procServ-2.5.1.tar.gz
a6d3131361189458fc276ca4323efe46 procServ-2.5.1.tar.gz.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2458825
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files must call ldconfig in %post and
%postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: .so files must go in a -devel package.
[.] MUST: devel packages must require the base package.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
- seems to work as expected but I tested only superficially
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: your package should contain man pages for binaries/scripts.
Package APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Martin Gieseking changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #13 from Martin Gieseking 2010-09-09 16:02:14 EDT --- Removed FE-NEEDSPONSOR as I've sponsored Ralph. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 Martin Gieseking changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de Flag||fedora-review? --- Comment #12 from Martin Gieseking 2010-09-03 03:13:03 EDT --- (In reply to comment #11) Hi Ralph, > The two spelling-error warnings remain, both of which are true > false-positives: Yes, that's OK. The spell checker isn't perfect. It sometimes makes a lot of noise. You can just ignore the false positive warnings. > I do not have a sponsor yet, so I accept and highly appreciate your offer. > Thank you very much! You're welcome. :) However, before I can approve you, you should show that you're familiar with the packaging guidelines. This is important because you're allowed to formally review and approve other packager's submissions once you've been sponsored. To show your (basic) understanding of the guidelines, and to become familiar with reviewing packages, I encourage you to do two or three informal reviews. I'll contact you privately for further details. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #11 from Ralph Lange 2010-09-02 16:34:52 EDT --- Hello Martin, thanks a lot for your review and the additional hints. I fixed all issues as you suggested. The two spelling-error warnings remain, both of which are true false-positives: the package I recommend is named "conserver", and I mention "localhost" as found in /etc/hosts - changing the spelling would be misleading. I do not have a sponsor yet, so I accept and highly appreciate your offer. Thank you very much! New URLs: Spec http://pubweb.bnl.gov/~rlange/procserv/procServ.spec SRPM http://pubweb.bnl.gov/~rlange/procserv/procServ-2.5.1-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547832
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #10 from Martin Gieseking 2010-08-31
03:47:39 EDT ---
Hi Ralph,
your package looks almost fine now. Just a couple of things to consider:
- please adapt the URL in Source0 according to
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
- in the %changelog section, replace %doc with %%doc to make rpmlint happy
(see rpmlint output below)
- I recommend to be a bit more specific in %files and replace
%{_mandir}/man1/procServ.* with
%{_mandir}/man1/procServ.1*
The latter might seem a bit nit-picking, but it helps to avoid adding files in
wrong places. I already came across packages with man3 files in man1 folders.
When using an explicit suffix, something like that won't happen by accident in
future releases.
BTW, if you don't have a sponsor yet, I'm willing to sponsor you.
$ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm
procServ.src: W: spelling-error %description -l en_US conserver -> conserve,
conserves, conserved
procServ.src: W: spelling-error %description -l en_US localhost -> local host,
local-host, localism
procServ.src:48: W: macro-in-%changelog %doc
procServ.x86_64: W: spelling-error %description -l en_US conserver -> conserve,
conserves, conserved
procServ.x86_64: W: spelling-error %description -l en_US localhost -> local
host, local-host, localism
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #9 from Ralph Lange 2010-07-23 10:48:15 EDT --- Thank you for the review and especially for pointing out that pitfall. I never realized %doc was replacing anything that was in the target location. I changed/fixed both issues and re-uploaded source RPM and spec. New URLs are Spec URL: http://pubweb.bnl.gov/~rlange/procserv/procServ.spec SRPM URL: http://pubweb.bnl.gov/~rlange/procserv/procServ-2.5.1-2.fc12.src.rpm And, of course: I am still looking for a sponsor. I would very much appreciate if someone was willing to review and upload the package. Again: Thanks a lot! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=547832
Michael Schwendt changed:
What|Removed |Added
CC||mschwe...@gmail.com
--- Comment #8 from Michael Schwendt 2010-07-23 09:45:32
EDT ---
Just a brief look at the spec file:
> Summary: A process server with telnet console and log access
Most packages try to be even more concise, e.g.:
Summary: Process server with telnet console and log access
> %configure --docdir=%{_defaultdocdir}/%{name}-%{version}
> [...]
> %files
> %defattr(-,root,root,-)
> %doc AUTHORS COPYING ChangeLog NEWS README procServ.html procServ.pdf
> procServ.txt
>
Caution! This is a packaging pitfall.
This definition of --docdir here conflicts with the %doc line. What happens is
that any files installed into the --docdir are killed by %doc, because %doc
creates its target directory from scratch. You would not notice if "make
install" installs additional documentation.
Correct would be:
%configure --docdir=%{_defaultdocdir}/%{name}-%{version}
[...]
%files
%defattr(-,root,root,-)
%{_defaultdocdir}/%{name}-%{version}/
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #7 from Ralph Lange 2010-03-24 11:12:26 EDT --- Update for a new upstream version. New URLs are Spec URL: http://pubweb.bnl.gov/~rlange/procserv/procServ.spec SRPM URL: http://pubweb.bnl.gov/~rlange/procserv/procServ-2.5.1-1.fc12.src.rpm I am still looking for a sponsor. I would very much appreciate if someone was willing to review and upload the package. Thanks a lot! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 547832] Review Request: procServ - A process server with telnet console and log access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547832 --- Comment #6 from Ralph Lange 2010-01-20 15:34:18 EST --- Update providing a better description. New URLs are Spec URL: http://pubweb.bnl.gov/~rlange/procserv/procServ.spec SRPM URL: http://pubweb.bnl.gov/~rlange/procserv/procServ-2.5.0-4.fc12.src.rpm I am still looking for a sponsor. This is a very small simplistic package, just a binary and doc, hardly any external dependencies. I would very much appreciate if someone was willing to review and upload the package. Thanks a lot! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
