[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2012-02-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Eric Christensen  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WONTFIX
Last Closed|2010-09-05 09:31:36 |2012-02-10 00:19:32

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2011-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Jeffrey Ness  changed:

   What|Removed |Added

 Blocks|651123  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2011-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #27 from Jeffrey Ness  2011-01-09 14:59:26 
EST ---
Thanks David,

I created Bugzilla #668287
(https://bugzilla.redhat.com/show_bug.cgi?id=668287), but having trouble
assigning it to you, it may be because this is my first package and I'm not
sponsored.

If you wouldn't mind picking up the new ticket (and closing out this one if you
could).

Thanks :)
Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2011-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #26 from David Nalley  2011-01-09 13:03:26 EST ---
Hi Jeffrey - sorry for the lag on this. 
I'd prefer you open a new review request for this (requestor is changing, and
you are starting from bascially a clean spec file instead of picking up Eric's.
Feel free to 'assign' the new ticket to me, and I'll be happy to complete the
review. 

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #25 from Jeffrey Ness  2010-12-08 11:44:33 
EST ---
Added Patch to RPM Spec file rather than generate.sh

$ rpmlint ../SRPMS/php-pChart-1.27-4.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/noarch/php-pChart-1.27-4.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
---

SPEC: http://flip-edesign.com/source/php-pChart/php-pChart.spec
SRPM: http://flip-edesign.com/source/php-pChart/php-pChart-1.27-4.src.rpm
--

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #24 from Jeffrey Ness  2010-12-08 10:53:34 
EST ---
Corrected capitalization issue:

$ rpmlint ../RPMS/noarch/php-pChart-1.27-4.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint ../SRPMS/php-pChart-1.27-4.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #23 from Jeffrey Ness  2010-12-08 10:45:32 
EST ---
Not a problem Eric, I'll be happy to take over this package.

SPEC: http://flip-edesign.com/source/php-pChart/php-pChart.spec
SRPM: http://flip-edesign.com/source/php-pChart/php-pChart-1.27-4.src.rpm

=== SRPM rpmlint ===
$ rpmlint ../SRPMS/php-pChart-1.27-4.src.rpm 
php-pChart.src: W: summary-not-capitalized a PHP class oriented framework
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

=== RPM rpmlint ===
$ rpmlint ../RPMS/noarch/php-pChart-1.27-4.noarch.rpm 
php-pChart.noarch: W: summary-not-capitalized a PHP class oriented framework
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
==

As Eric mentioned above upstream packages are in .rar format, we need to
re-package in .tar.gz format using guidelines
"http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code";

I have confirmed the fonts are not required and truetype font can be used
(verified by includes 'liberation-fonts' in my package
https://bugzilla.redhat.com/show_bug.cgi?id=651123)


Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #22 from Eric Christensen  2010-12-08 
09:08:15 EST ---
(In reply to comment #21)
> Any progress on this package? My package is at a standstill waiting on it.. 
> 
> Jeffrey-

Unfortunately I don't really have the time to work on this right now.  If you
would like to work on this package please do.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-12-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #21 from Jeffrey Ness  2010-12-06 15:04:20 
EST ---
Any progress on this package? My package is at a standstill waiting on it.. 

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #19 from David Nalley  2010-11-21 12:50:35 EST ---
(In reply to comment #17)
> Okay, I've added php-common to be required.
> 
> I believe one of the fonts is already in Fedora but the others are not.  I
> don't feel that I'm qualified to recommend alternate fonts.

I don't know that you have to recommend alternate fonts, but the package won't
work properly has it has fonts coded. 

Jeffrey: Care to share the spec for the development RPM, perhaps someone else
has seen this and come up with a novel solution (such as using liberation
fonts)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #20 from Jeffrey Ness  2010-11-21 16:17:23 
EST ---
Sure. 

My RPM isn't close to Redhat standard for approval, but it gets the job done
for testing:

http://flip-edesign.com/source/php-pChart/php-pChart.spec

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #18 from Jeffrey Ness  2010-11-21 11:59:46 
EST ---
Hey Eric,

The Development RPM I have been using for pChart requires "liberation-fonts",
maybe you can remove the Fonts from you package and rely on it?

Just a thought.

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #17 from Eric Christensen  2010-11-21 
10:29:03 EST ---
Okay, I've added php-common to be required.

I believe one of the fonts is already in Fedora but the others are not.  I
don't feel that I'm qualified to recommend alternate fonts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #16 from David Nalley  2010-11-20 21:57:12 EST ---
Hi Eric: 

So I have come across one concern with stripping the fonts. In pChart.class I
see the two following lines. 

var $ErrorFontName  = "Fonts/pf_arma_five.ttf";
$this->setFontProperties("tahoma.ttf",8);

Those files of course won't be there if they are stripped out, but it looks to
be 'hardcoding' (albeit with a relative path) the font location. 

I see the solution as doing one of two things: 
1. symlink the appropriate .ttf files from packages (and require those
packages) 
2. patch the .class file to refer to to the fonts in question. (or different
fonts altogether) 

Also I think php-common is necessary at a minimum as a require.  (don't know
how I missed that earlier.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Jeffrey Ness  changed:

   What|Removed |Added

 Blocks||651123

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #14 from David Nalley  2010-11-16 09:48:34 EST ---
Eric: 

The package is starting to look good. I don't see any blockers from a SPEC file
standpoint now, but am concerned about the font issue and whether that breaks
things. You mentioned you had someone who wanted to use it?? I'll try and see
if I can use it as well and hopefully get this package approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #15 from Jeffrey Ness  2010-11-16 11:01:05 
EST ---
Sounds great! Can't wait to see this approved.

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #13 from Eric Christensen  2010-11-13 
11:08:36 EST ---
(In reply to comment #7)
> FIX: The License field in the package spec file must match the actual license.
> Source code indicates the following: 
> This program is free software: you can redistribute it and/or modify
>  it under the terms of the GNU General Public License as published by
>  the Free Software Foundation, either version 1,2,3 of the License, or
>  (at your option) any later version.
> 
> Which would be GPL+ instead of GPLv2+ 

Fixed.

> FIX: The sources used to build the package must match the upstream source, as
> provided in the spec URL. Reviewers should use md5sum for this task. If no
> upstream URL can be specified for this package, please see the Source URL
> Guidelines for how to deal with this.
> 
> I know what you did (repackaged as a tarball from the rar) but you need to 
> tell
> us how to recreate what you did so we can compare sources 
> http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code
> While that isn't exactly the situation here - it's pretty close.

Yep, that makes sense.  Done.

> FIX: Packages must NOT bundle copies of system libraries.
> 
> I am saying fix here because it bundles fonts. 
> http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29

Yep.  ONE of those fonts is already in the repositories.  I wonder if the rest
of them should be.  I've removed the fonts completely.

> All of the example*.php, *.php,  buildall.cmd, Sample/* belongs in %doc 

FIXED
> 
> Fonts should exist, but symlink in system fonts (or some other means of
> handling them) 

I wonder if a symlink even needs to be there.  I've compiled without the
symlink and I think we need to test to see where the fonts are being pulled.

SRPM:
http://sparks.fedorapeople.org/Packages/pChart/php-pChart-1.27d-4.fc14.src.rpm

SPEC: http://sparks.fedorapeople.org/Packages/pChart/php-pChart.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-11-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Jeffrey Ness  changed:

   What|Removed |Added

 CC||jn...@flip-edesign.com

--- Comment #12 from Jeffrey Ness  2010-11-12 09:07:10 
EST ---
Any movement on packaging this software? I am in the process of getting an rpm
approved that requires pChart.

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-09-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Eric Christensen  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|WONTFIX |
   Keywords||Reopened

--- Comment #11 from Eric Christensen  2010-09-05 
14:09:43 EDT ---
Shoot, wrong package!

Thanks for the poke.  I'll see if I can work on it this weekend.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-09-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #10 from Kevin Fenzi  2010-09-05 14:00:11 EDT ---
This is also a blocker for limesurvey according to the bugzilla dependencies.
;(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-09-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Eric Christensen  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WONTFIX
Last Closed||2010-09-05 09:31:36

--- Comment #9 from Eric Christensen  2010-09-05 
09:31:36 EDT ---
I'm going to close this request.  Since Fedora isn't going to use Zikula then
this package is moot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-09-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #8 from David Nalley  2010-09-05 00:20:34 EDT ---
Eric: 

Just wanted to see where we stand on this? 

Have you had an opportunity to talk to Nicholas Mailhot re the fonts? 


tnx

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-06-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

--- Comment #7 from David Nalley  2010-06-23 22:05:33 EDT ---
OK: rpmlint must be run on every package. The output should be posted in the
review.
[ke4...@nalleyx60 SPECS]$ rpmlint php-pChart.spec 
php-pChart.spec: W: invalid-url Source0: pChart.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
[ke4...@nalleyx60 SPECS]$ rpmlint ../SRPMS/php-pChart-1.27d-3.fc13.src.rpm 
../RPMS/noarch/php-pChart-1.27d-3.fc13.noarch.rpm 
php-pChart.src: W: invalid-url Source0: pChart.tar.gz
php-pChart.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
MUST: The package must meet the Packaging Guidelines
CHECK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .

While the php code is under a license that's acceptable I am not sure about the
fonts. 

FIX: The License field in the package spec file must match the actual license.
Source code indicates the following: 
This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation, either version 1,2,3 of the License, or
 (at your option) any later version.

Which would be GPL+ instead of GPLv2+ 

NA: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
FIX: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

I know what you did (repackaged as a tarball from the rar) but you need to tell
us how to recreate what you did so we can compare sources 
http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code
While that isn't exactly the situation here - it's pretty close. 


OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
NA: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
NA: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
NA: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun. 
FIX: Packages must NOT bundle copies of system libraries.

I am saying fix here because it bundles fonts. 
http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29

NA: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker. 
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
NA: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. 
NA: Header

[Bug 549590] Review Request: php-pChart - A PHP class to build charts.

2010-06-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549590

Eric Christensen  changed:

   What|Removed |Added

Summary|Review Request: pChart - A  |Review Request: php-pChart
   |PHP class to build charts.  |- A PHP class to build
   ||charts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review