[Bug 551651] Review Request: ArpON - Arp handler inspection
https://bugzilla.redhat.com/show_bug.cgi?id=551651 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #24 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
https://bugzilla.redhat.com/show_bug.cgi?id=551651 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #23 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: ArpON New Branches: epel7 el6 Owners: fab sagarun InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 Arun SAG saga...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Alias||ArpON -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #21 from Terje Røsten terje...@phys.ntnu.no 2010-03-21 16:47:35 EDT --- Arun, what's up, forgot to import and build? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #22 from Arun SAG saga...@gmail.com 2010-03-22 00:38:06 EDT --- (In reply to comment #21) Arun, what's up, forgot to import and build? Sorry, i was busy last weekend. Will import it this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #20 from Jason Tibbitts ti...@math.uh.edu 2010-03-10 17:17:15 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #17 from Arun SAG saga...@gmail.com 2010-03-09 09:47:17 EST --- Fixed issues in #comment 16 SPEC URL: http://sagarun.fedorapeople.org/SPECS/ArpON.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/ArpON-1.90-5.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|terje...@phys.ntnu.no Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #18 from Terje Røsten terje...@phys.ntnu.no 2010-03-09 11:35:25 EST --- o rpmlint clean o spec file looks fine o naming is fine o ownership/perms is correct o sha is good: $ sha1sum ArpON-1.90.tar.gz* 0a0dbfa6e7571892b39bcd25b91f14c840b01315 ArpON-1.90.tar.gz 0a0dbfa6e7571892b39bcd25b91f14c840b01315 ArpON-1.90.tar.gz.spec ! please download with e.g. wget -N to get correct time stamp on tarball. o license is BSD and set correct. o builds with correct flags: http://koji.fedoraproject.org/koji/getfile?taskID=2041933name=build.log o builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2041927 o man page included - Fix the time stamp when importing. The package ArpON is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 Arun SAG saga...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Arun SAG saga...@gmail.com 2010-03-09 12:23:34 EST --- New Package CVS Request === Package Name: ArpON Short Description: ARP handler inspection Owners:sagarun Branches: F-12,F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551651
--- Comment #16 from Terje Røsten terje...@phys.ntnu.no 2010-03-07 06:49:46
EST ---
Cut and paste error?
%{__install} -D -pm 644 man8/arpon.8 %{buildroot}%{_mandir}/man8/arpon.8*
Some pedantic things in changelog
- don't mix case on first letter
- don't mix ending with/without .
Please use only one empty between sections, and I don't see the need for
empty lines in top tags at all.
Rest seems fine, fix these and I will do the formal review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551651
--- Comment #15 from Arun SAG saga...@gmail.com 2010-03-06 14:25:01 EST ---
#Comment 5 honored
# Fixed mandir to %{_mandir}/man8/arpon.8*
SPEC URL: http://sagarun.fedorapeople.org/SPECS/ArpON.spec
SRPM URL: http://sagarun.fedorapeople.org/SRPMS/ArpON-1.90-4.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551651
--- Comment #11 from Fabian Affolter fab...@bernewireless.net 2010-03-03
03:51:16 EST ---
Just another comment on your spec file
%{_mandir}/man8/arpon.8.gz
Since manual pages are compressed on-the-fly by rpmbuild and the compression
tool may change, it's prefered to use: %{_mandir}/man*/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #12 from Fabian Affolter fab...@bernewireless.net 2010-03-03 03:55:14 EST --- In the same effort the comment #5 can be honored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551651
--- Comment #13 from Terje Røsten terje...@phys.ntnu.no 2010-03-03 04:02:12
EST ---
%{_mandir}/man8/arpon.8.gz
Since manual pages are compressed on-the-fly by rpmbuild and the compression
tool may change, it's prefered to use: %{_mandir}/man*/*
This seems too generic? What's wrong with: %{_mandir}/man8/arpon.8*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551651
--- Comment #14 from Till Maas opensou...@till.name 2010-03-03 04:18:35 EST
---
(In reply to comment #13)
This seems too generic? What's wrong with: %{_mandir}/man8/arpon.8*
Nothing, I prefer this, too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net Blocks||563471(FE-SECSPIN) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551651] Review Request: ArpON - Arp handler inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551651 --- Comment #10 from Arun SAG saga...@gmail.com 2010-01-12 11:59:25 EST --- Fixed issues reported by Terje Røsten: SPEC URL: http://sagarun.fedorapeople.org/SPECS/ArpON.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/ArpON-1.90-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
