[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 Guillermo Gómez guillermo.go...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #24 from Guillermo Gómez guillermo.go...@gmail.com 2010-09-16 12:04:27 EDT --- == Package Name: fwsnort New Branches: el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #25 from Guillermo Gómez guillermo.go...@gmail.com 2010-09-16 16:09:18 EDT --- New Package SCM Request == Package Name: fwsnort New Branches: el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #26 from Guillermo Gómez guillermo.go...@gmail.com 2010-09-16 18:12:34 EDT --- Package Change Request == Package Name: pkgname New Branches: el5 el6 Owners: gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #27 from Guillermo Gómez guillermo.go...@gmail.com 2010-09-16 18:24:11 EDT --- Package Change Request == Package Name: fwsnort New Branches: el5 el6 Owners: gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #28 from Kevin Fenzi ke...@tummy.com 2010-09-16 18:28:43 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 Guillermo Gómez guillermo.go...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE --- Comment #23 from Guillermo Gómez guillermo.go...@gmail.com 2010-08-02 16:56:42 EDT --- Being pushed to F12 and F13 branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551857
Dennis Gilmore den...@ausil.us changed:
What|Removed |Added
Blocks|177841(FE-NEEDSPONSOR) |
Flag|fedora-review? |fedora-review+
--- Comment #20 from Dennis Gilmore den...@ausil.us 2010-07-30 20:07:32 EDT
---
one remaining issue
%fwsnortlogdir needs to be %{fwsnortlogdir}
it can be fixed at import time
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 Guillermo Gómez guillermo.go...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #21 from Guillermo Gómez guillermo.go...@gmail.com 2010-07-30 20:38:39 EDT --- New Package CVS Request === Package Name: fwsnort Short Description: Translates Snort rules into equivalent iptables rules Owners: gomix Branches: F-12 F-13 InitialCC: ausil -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #22 from Kevin Fenzi ke...@tummy.com 2010-07-30 20:54:29 EDT --- GIT done (by process-git-requests). With f14 branch added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #19 from Guillermo Gómez guillermo.go...@gmail.com 2010-07-22 03:08:49 EDT --- Updated spec/src.rpm for FC13 (no change) srpm: http://gomix.fedorapeople.org/fwsnort/1.0.6-7/fc13/fwsnort-1.0.6-7.fc13.src.rpm spec: http://gomix.fedorapeople.org/fwsnort/1.0.6-7/fc13/fwsnort.spec $ rpmlint -i fwsnort.spec fwsnort-1.0.6-7.fc13.src.rpm fwsnort.src: W: spelling-error Summary(en_US) iptables - potables, portables, birdtables The value of this tag appears to be misspelled. Please double-check. fwsnort.src: W: spelling-error %description -l en_US iptables - potables, portables, birdtables The value of this tag appears to be misspelled. Please double-check. fwsnort.src: W: spelling-error %description -l en_US ruleset - rule set, rule-set, rules et The value of this tag appears to be misspelled. Please double-check. 1 packages and 1 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 Guillermo Gómez guillermo.go...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551857
--- Comment #16 from Dennis Gilmore den...@ausil.us 2010-05-16 19:54:46 EDT
---
the rpmlint warning can be ignored.
you shouldn't own %{_sysconfdir}/logrotate.d instead you should Requires
logrotate which provides that directory. you need it also to have logrotate
functional.
Can you please point me to some reviews you have helped with.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551857
--- Comment #17 from Guillermo Gómez guillermo.go...@gmail.com 2010-05-16
20:47:51 EDT ---
(In reply to comment #16)
the rpmlint warning can be ignored.
you shouldn't own %{_sysconfdir}/logrotate.d instead you should Requires
logrotate which provides that directory. you need it also to have logrotate
functional.
I'll take care of this asap.
Can you please point me to some reviews you have helped with.
Honestly, i did not know i had such privilege in bugzilla, ¿do i? i guess i do,
i did not find such recommendation anywhere else :(
However, i've helping with many rpm building process to other new potential
contributors, ive been helping others in their way (under rpmdev project
scope):
http://rpmdev.proyectofedora.org/projects/dhcp-probe
http://rpmdev.proyectofedora.org/projects/show/clamsmtp (in bugzilla already)
http://rpmdev.proyectofedora.org/projects/abajo
http://rpmdev.proyectofedora.org/projects/show/smartcam
http://turpial.org.ve/ (in bugzilla, helping richzendy with the pkg, i compiled
tested in x86_64 env and produced a better spec/srpm for him, included if
pf.org repo)
From most of those pkgs, including my own fwsnort,i already have setup a
intermediate yum repo to proove u ive been helping those people to devel their
specs/rpms: http://www.proyectofedora.org/repo/12/ (the idea been those pkgs
will reach oficial repos and bugzilla, not to be an steady repo, just
pre-fedora oficial procedures)
# https://bugzilla.redhat.com/show_bug.cgi?id=555059
# https://bugzilla.redhat.com/show_bug.cgi?id=551857
# https://bugzilla.redhat.com/show_bug.cgi?id=549496
# https://bugzilla.redhat.com/show_bug.cgi?id=549366
# https://bugzilla.redhat.com/show_bug.cgi?id=567713
Ive been helping them, but i did not know i could review them in bugzila.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #15 from Guillermo Gómez guillermo.go...@gmail.com 2010-04-25 07:58:17 EDT --- Done... macros use improved for consistency on release 6 rpmlint output $ rpmlint -i fwsnort.spec fwsnort-1.0.6-6.fc12.src.rpm fwsnort.src: W: spelling-error Summary(en_US) iptables - potables, portables, timetables The value of this tag appears to be misspelled. Please double-check. fwsnort.src: W: spelling-error %description -l en_US iptables - potables, portables, timetables The value of this tag appears to be misspelled. Please double-check. fwsnort.src: W: spelling-error %description -l en_US ruleset - rule set, rule-set, ruler The value of this tag appears to be misspelled. Please double-check. 1 packages and 1 specfiles checked; 0 errors, 3 warnings. spec url: http://gomix.fedorapeople.org/fwsnort/fwsnort.spec srpm url: http://gomix.fedorapeople.org/fwsnort/fwsnort-1.0.6-6.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551857
--- Comment #14 from Dennis Gilmore den...@ausil.us 2010-04-21 23:01:39 EDT
---
rpmlint /var/lib/mock/fedora-13-x86_64/result
fwsnort.noarch: W: spelling-error Summary(en_US) iptables - potables,
portables, timetables
fwsnort.noarch: W: spelling-error %description -l en_US iptables - potables,
portables, timetables
fwsnort.noarch: W: spelling-error %description -l en_US ruleset - rule set,
rule-set, ruler
fwsnort.src: W: spelling-error Summary(en_US) iptables - potables, portables,
timetables
fwsnort.src: W: spelling-error %description -l en_US iptables - potables,
portables, timetables
fwsnort.src: W: spelling-error %description -l en_US ruleset - rule set,
rule-set, ruler
I think that these warnings can be ignored.
upstream source matches
sha256sum fwsnort-1.0.6.tar.gz fedora/SOURCES/fwsnort-1.0.6.tar.gz
b7ce09b815d1dd8ec9518a39ece79883d8099c905be431dc7b6b1d73a523b40f
fwsnort-1.0.6.tar.gz
b7ce09b815d1dd8ec9518a39ece79883d8099c905be431dc7b6b1d73a523b40f
fedora/SOURCES/fwsnort-1.0.6.tar.gz
I would like to see all macros be used consistently some you have wrapped in
{} and some not. please wrap them all in {} i.e. %_sysconfdir should be
%{_sysconfdir}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #11 from Guillermo Gómez guillermo.go...@gmail.com 2010-02-04 14:20:36 EST --- Description in spec in fact was taken from the README, so no problem on accepting the suggestion. Description adjusted en Release 4 rpmlint output $ rpmlint -i fwsnort.spec fwsnort-1.0.6-4.fc12.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. spec url: http://gomix.fedorapeople.org/fwsnort/fwsnort.spec srpm url: http://gomix.fedorapeople.org/fwsnort/fwsnort-1.0.6-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #12 from manuel wolfshant wo...@nobugconsulting.ro 2010-02-04 14:31:08 EST --- Sorry if the answer is obvious, but at the first (and second) glance I do not see what's fwsnortmoddir used for. It does not seem to be used either in %install or in %files Could you please shed some light ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #13 from Guillermo Gómez guillermo.go...@gmail.com 2010-02-04 15:14:19 EST --- No problem, this macro its actually not needed anymore because modules required build are not necesary nor provided by fwsnort, those modules are provided by perl-Net-IPv4Addr perl-IPTables-Parse in Fedora. So i removed the macro definition :) Thanks for the catch. Macro definition fwsnortmoddir removed en Release 5 rpmlint output $ rpmlint -i fwsnort.spec fwsnort-1.0.6-5.fc12.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. spec url: http://gomix.fedorapeople.org/fwsnort/fwsnort.spec srpm url: http://gomix.fedorapeople.org/fwsnort/fwsnort-1.0.6-5.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #2 from Guillermo Gómez guillermo.go...@gmail.com 2010-02-03 08:52:05 EST --- Updated spec and srpm, including all the suggestions. I'm waiting for the autor about the issue syncing man and spec files. /etc/fwsnort/snort_rules/VERSION to %doc section included as SNORT-RULES-VERSION to avoid filename clash with fwsnort VERSION file. rpmlint output of updated spec and srpm $ rpmlint -i fwsnort-1.0.6-1.fc12.src.rpm fwsnort.spec 1 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #3 from Colin Coe colin@gmail.com 2010-02-03 18:18:38 EST --- Hi When you update the spec file, please increment '%release'. Related to this, the %changelog section should list all the changes in this release. Please increment the release and update changelog. CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #4 from Guillermo Gómez guillermo.go...@gmail.com 2010-02-03 20:48:03 EST --- (In reply to comment #3) Hi When you update the spec file, please increment '%release'. Related to this, the %changelog section should list all the changes in this release. Please increment the release and update changelog. CC Done :) Spec url: http://gomix.fedorapeople.org/fwsnort/fwsnort.spec SRPM url: http://gomix.fedorapeople.org/fwsnort/fwsnort-1.0.6-2.fc12.src.rpm Gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #5 from Colin Coe colin@gmail.com 2010-02-03 21:08:26 EST --- At the risk of being pedantic, I think the license is wrong in the spec file. http://fedoraproject.org/wiki/Licensing --- GNU General Public License (no version) GPL+ Yes Yes Yes A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. --- I think the license should be 'GPL+' not 'GPLv2' is the license file lacks a reference to a version. v1.1 of fwsnort has been released, please consider rebasing to this version. Other than these couple of items, your RPM and spec file look pretty good. You look like you've already been sponsored but I'd prefer a second opinion on this RPM and spec to make sure I've not missed anything. CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #6 from Guillermo Gómez guillermo.go...@gmail.com 2010-02-03 21:34:57 EST --- Im not an expert about licenses, but, LICENSE file included begins as follows: GNU GENERAL PUBLIC LICENSE Version 2, June 1991 thats why i did choose GPLv2 short name from the wiki about licencing for the spec (i did not notice the man page file, thanks). The man page mentions only GPL which is the only issue remaining (waiting for the author, i dont want to modify the man page). About the new release (1.1), i will consider some time later afer this ones goes through the revision process, as an update (if it hits reasonably soon to fedora repos). Also i need to test and review v1.1 as a whole (ipv6 stuff). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551857] Review Request: fwsnort - Translates Snort rules into equivalent iptables rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551857 --- Comment #7 from Colin Coe colin@gmail.com 2010-02-03 21:58:36 EST --- Sorry, my mistake, it should definitely 'GPLv2+' because of this in the README file: --- COPYRIGHT: Copyright (C) 2003 Michael Rash (m...@cipherdyne.org) This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. --- OK, so once the license statement is fixed in the spec file I think this will be ready. A second opinion for a more experienced reviewer would be good though. CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
