[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #7 from leigh scott leigh123li...@googlemail.com 2011-04-05 12:00:07 EDT --- Package Change Request == Package Name: compizconfig-backend-kconfig4 New Branches: el6 Owners: leigh123linux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2011-04-05 13:54:01 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 --- Comment #5 from Rex Dieter rdie...@math.unl.edu 2010-02-23 14:46:40 EST --- ping, was this ever imported, can we close this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 --- Comment #6 from leigh scott leigh123li...@googlemail.com 2010-02-23 18:51:21 EST --- (In reply to comment #5) ping, was this ever imported, can we close this? Yes it was. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=555991
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu
Flag||fedora-review?
--- Comment #1 from Rex Dieter rdie...@math.unl.edu 2010-01-16 16:17:48 EST
---
A few quick initial comments:
1. probably only really need
BuildRequires: kdelibs4-devel
(unverified, unless you know better)
2. in %install, use
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
intead
3. in %install, no need for .la file hackery. kde4/cmake produces none.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter rdie...@math.unl.edu 2010-01-16 16:30:24 EST --- $ rpmlint x86_64/*.rpm *.rpm compizconfig-backend-kconfig4.x86_64: W: obsolete-not-provided compizconfig-backend-kconfig compizconfig-backend-kconfig4-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package compizconfig-backend-kconfig4. compizconfig-backend-kconfig4.src:15: W: unversioned-explicit-obsoletes compizconfig-backend-kconfig 3 packages and 0 specfiles checked; 1 errors, 2 warnings. Mostly harmless. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1927324 Builds/installs fine. macro usage good, consistent. License: GPLv2+ OK (though you probably don't need to %doc COPYING.LGPL, unless I'm missing something) no scriptlets. source verified, $ md5sum *.gz d5aee115ad0d2f3586c359b1dac1d072 compizconfig-backend-kconfig4-0.8.4.tar.gz Consider the items in initial comments as SHOULD items, but not review blockers. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from leigh scott leigh123li...@googlemail.com 2010-01-16 16:46:52 EST --- Thank you for review . New Package CVS Request === Package Name: compizconfig-backend-kconfig4 Short Description: Kconfig4 backend for libcompizconfig Owners: leigh123linux Branches: F-12 InitialCC: leigh123linux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555991] Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 --- Comment #4 from Jason Tibbitts ti...@math.uh.edu 2010-01-16 17:29:20 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
