[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed|2010-01-20 11:36:19 |2010-08-20 11:48:03 --- Comment #21 from Mamoru Tasaka 2010-08-20 11:48:03 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #20 from Kevin Fenzi 2010-08-14 16:28:23 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #19 from Mamoru Tasaka 2010-08-14 11:28:00 EDT --- Ah, Package Name should be clamsmtp For now I rewrite git request (CC not needed for me) New Package SCM Request === Package Name: clamsmtp Short Description: A daemon to virus scan mail using clamav Owners: gnat Branches: F12 F13 F14 EL5 EL6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #18 from Jason Tibbitts 2010-08-14 10:47:41 EDT --- The summary says "clamsmtp", the SCM request says "clamsmtpd". Which did you actually want? Please correct either the request or the bug summary so that they match. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Nathanael Noblet 2010-08-13 15:36:50 EDT --- Package Change Request == Package Name: clamsmtpd New Branches: F12 F13 F14 EL5 Owners: gnat -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #17 from Nathanael Noblet 2010-08-13 15:40:06 EDT --- New Package SCM Request === Package Name: clamsmtpd Short Description: A daemon to virus scan mail using clamav Owners: gnat Branches: F12 F13 F14 EL5 EL6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #16 from Nathanael Noblet 2010-08-13 15:37:55 EDT --- Package Change Request == Package Name: clamsmtpd New Branches: F12 F13 F14 EL5 EL6 Owners: gnat Sorry missed the EL6 branch... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #14 from Mamoru Tasaka 2010-08-13 13:51:22 EDT --- Okay. -- This package (clamsmtp) is APPROVED by mtasaka -- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added Flag|needinfo?(nathan...@gnat.ca | |) | --- Comment #13 from Nathanael Noblet 2010-08-12 11:20:21 EDT --- SRPM: http://www.gnat.ca/clamsmtp-1.10-1.fc13.src.rpm SPEC: http://www.gnat.ca/clamsmtp.spec Should all be fixed up. rpmlint complains a bit on the binary RPM about a few init script stuff that isn't true as the initscript is using the wrapper. I added a small patch to fix a man page issue (I've emailed upstream...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(nathan...@gnat.ca ||) --- Comment #12 from Mamoru Tasaka 2010-08-05 11:53:29 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557011
--- Comment #11 from Mamoru Tasaka 2010-07-25
13:03:04 EDT ---
Sorry for late.
Again please use %{?dist} for release number
unless the tarball is preversion or so.
* Requires(foo)
- Please unify Requires(foo) to "/sbin/service" type or
"initscripts" style, not use both, ref:
https://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets
- Some Requires(pre) is missing:
https://fedoraproject.org/wiki/Packaging/UsersAndGroups
* Macros
- Please use macros consistently.
- If you want to use %{__rm} or %{__install}, please also use
%{__make}, %{__mkdir_p}, %{__ln_s} or so.
Also both "%{__rm}" and rm are used.
* service name
- Now rpmlint complains:
clamsmtp.i686: E: init-script-name-with-dot /etc/rc.d/init.d/clamd.clamsmtp
Please check "$ rpmlint -I init-script-name-with-dot" for
explanation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added Flag|needinfo?(nathan...@gnat.ca | |) | --- Comment #10 from Nathanael Noblet 2010-07-20 00:00:21 EDT --- So I think everything you pointed out is fixed. SRPM: http://www.gnat.ca/clamsmtp-1.10-0.2.fc13.src.rpm SPEC: http://www.gnat.ca/clamsmtp.spec Let me know if I missed anything. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(nathan...@gnat.ca ||) --- Comment #9 from Mamoru Tasaka 2010-07-17 11:45:31 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka changed: What|Removed |Added Flag|fedora-review+ |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557011
--- Comment #7 from Mamoru Tasaka 2010-07-07
14:45:35 EDT ---
For 0.1:
* Notes for clamd-clamsmtp service
A Your spec file contains:
80 /sbin/service clamd.clamsmtp stop &>/dev/null || :
81 /sbin/chkconfig --del clamd-clamsmtp
This is not consistent (clamd.clamsmtp vs clamd-clamsmtp).
B # service clamd-clamsmtp status won't work
[r...@localhost ~]# service clamd-clamsmtp start
Starting clamd.clamsmtp: LibClamAV Warning:
**
LibClamAV Warning: *** The virus database is older than 7 days! ***
LibClamAV Warning: *** Please update it as soon as possible.***
LibClamAV Warning: **
[ OK ]
[r...@localhost ~]# service clamd-clamsmtp status
clamd.clamsmtp dead but subsys locked
However:
[r...@localhost ~]# ps auwwx | grep [c]lamd
clamsmtp 12151 0.0 16.8 153680 126688 ? Ssl 02:51 0:00 clamd.clamsmtp
-c /etc/clamd.d/clamsmtp.conf --pid /var/run/clamd.clamsmtp/clamd.pid
Note that this ps output says that pid file is
/var/run/clamd.clamsmtp/clamd.pid
(also check the wrapper file /usr/share/clamav/clamd-wrapper), however
on my system there is no /var/run/clamd.clamsmtp/ directory.
/usr/share/clamav/clamd-wrapper:
29 CLAMD_PIDFILE=/var/run/clamd.${CLAMD_SERVICE}/clamd.pid
C logrotate config file won't work (as I said in bug 555059)
[r...@localhost ~]# ps auwwx | grep [c]lamd
clamsmtp 12151 1.0 17.6 154840 132868 ? Ssl 02:51 0:07 clamd.clamsmtp
-c /etc/clamd.d/clamsmtp.conf --pid /var/run/clamd.clamsmtp/clamd.pid
[r...@localhost ~]# killall -HUP clamd.clamsmtp
clamd.clamsmtp: no process found
The problem here is that the actual binary name exected here is not
clamd.clamsmtp.
[r...@localhost ~]# pgrep -f clamd.clamsmtp
12151
[r...@localhost ~]# ls -lad /proc/$(pgrep -f clamd.clamsmtp)/exe
lrwxrwxrwx. 1 root root 0 Jul 8 03:07 /proc/12151/exe -> /usr/sbin/clamd
killall searches process by the actual binary name currently being executed
(strace says killall reads /proc//stat), so clamd.clamsmtp matches
nothing.
This should be like "pkill -SIGHUP -f clamd.clamsmtp", for example
D. # service clamd-clamsmtp stop won't work
[r...@localhost ~]# service clamd-clamsmtp stop
Stopping clamd.clamsmtp: [FAILED]
[r...@localhost ~]# ps auwwx | grep [c]lamd
clamsmtp 12151 0.5 17.6 154840 132872 ? Ssl 02:51 0:07 clamd.clamsmtp
-c /etc/clamd.d/clamsmtp.conf --pid /var/run/clamd.clamsmtp/clamd.pid
! Note
The issues B. and D. seems because the directory /var/run/clamd.clamsmtp/
does not exist.
Or other solution would be to specify CLAMD_PIDFILE vairable in
%{_sysconfdir}/sysconfig/clamd.clamsmtp
-
[r...@localhost ~]# install -d -m 0750 -o clamsmtp -g root
/var/run/clamd.clamsmtp
[r...@localhost ~]# service clamd-clamsmtp start
Starting clamd.clamsmtp: LibClamAV Warning:
**
LibClamAV Warning: *** The virus database is older than 7 days! ***
LibClamAV Warning: *** Please update it as soon as possible.***
LibClamAV Warning: **
[ OK ]
[r...@localhost ~]# service clamd-clamsmtp status
clamd.clamsmtp (pid 12890) is running...
[r...@localhost ~]# service clamd-clamsmtp stop
Stopping clamd.clamsmtp: [ OK ]
[r...@localhost ~]# service clamd-clamsmtp status
clamd.clamsmtp is stopped
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
ht
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557011
Mamoru Tasaka changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review+
--- Comment #8 from Mamoru Tasaka 2010-07-07
14:46:47 EDT ---
Other things:
* Requires
- Some "Requires(postun)" is needed (postun calls /sbin/service)
* Macros / symlink
--
ln -s ../..%{_sbindir}/clamd $RPM_BUILD_ROOT/usr/sbin/clamd.clamsmtp
--
- Note that %{_sbindir} = /usr/bin, i.e. clamd binary and clamd.clamsmtp
symlink (to be created) are in the same directory. So the
following is enough.
--
ln -sf clamd $RPM_BUILD_ROOT%{_sbindir}/clamd.clamsmtp
--
Also please use macros for "basic" directories.
- Use macros consistently. For example:
--
57 mkdir -p $RPM_BUILD_ROOT%{_var}/lib/clamsmtp
85 getent passwd clamsmtp >/dev/null || useradd -r -g mail -d
/var/lib/clamsmtp -s ..
105 %attr(755,clamsmtp,mail) %{_var}/lib/clamsmtp
--
By the way please begin release number with "1", and increment it
every time you modify your spec file (when version does not change)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #6 from Nathanael Noblet 2010-07-06 11:56:19 EDT --- SRPM: http://www.gnat.ca/clamsmtp-1.10-0.1.fc12.src.rpm Sorry the url was a bit off above... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #5 from Mamoru Tasaka 2010-06-24 15:17:28 EDT --- Nathanael, would you upload the new srpm anyway? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added CC||morphe...@fedoraproject.org --- Comment #4 from Nathanael Noblet 2010-06-22 17:40:21 EDT --- *** Bug 555059 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Nathanael Noblet changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|DUPLICATE | --- Comment #3 from Nathanael Noblet 2010-06-22 17:40:07 EDT --- re-opening... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE --- Comment #2 from Mamoru Tasaka 2010-01-20 11:36:19 EST --- As there is another earlier review request (and as I said in bug 537587 comment 60), once closing this one. Please ask morpheusv to incorporate your spec to his one. *** This bug has been marked as a duplicate of bug 555059 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557011] Review Request: clamsmtp - A Daemon to virus scan mail using clamav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #1 from Nathanael Noblet 2010-01-20 11:22:43 EST --- the rpmlint output and justification clamsmtp.x86_64: W: non-standard-uid /var/run/clamsmtp clamsmtp clamsmtp.x86_64: W: non-standard-uid /var/log/clamsmtp clamsmtp clamsmtp.x86_64: W: non-standard-uid /var/lib/clamsmtp clamsmtp This is so that the clamd instance and clamsmtp are isolated from someone on the system injecting/overriding the file being scanned. clamsmtp.x86_64: W: dangling-relative-symlink /usr/sbin/clamd.clamsmtp ../../usr/sbin/clamd Not sure why it complains here, the symlink works perfectly when installed clamsmtp.x86_64: E: no-status-entry /etc/rc.d/init.d/clamd-clamsmtp clamsmtp.x86_64: W: no-reload-entry /etc/rc.d/init.d/clamd-clamsmtp clamsmtp.x86_64: E: subsys-not-used /etc/rc.d/init.d/clamd-clamsmtp clamsmtp.x86_64: W: no-reload-entry /etc/rc.d/init.d/clamsmtpd These are all pretty much bogus, the clamd initscript is a wrapper around /usr/share/clamav/clamd-wrapper which has all of the parts this is warning about. To create this clamd instance I followed the instructions in the README of the clamav-server package. I debated creating a subpackage for the clamd instance, but decided against it. I guess it is possible that someone would want to install clamsmtp without a pre-setup clamd instance, however they can still do so with this setup. Granted installing this will pull in clamav-server and its dependancies. So that's basically what I'm wondering... should it be split in two? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
