[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
https://bugzilla.redhat.com/show_bug.cgi?id=558058 --- Comment #11 from Jens Petersen --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Jens Petersen --- Package Change Request == Package Name: ghc-dataenc New Branches: el5 Owners: petersen InitialCC: haskell-sig -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 --- Comment #9 from Kevin Fenzi 2010-10-04 15:05:47 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #8 from Jens Petersen 2010-10-03 22:08:55 EDT --- Package Change Request == Package Name: ghc-dataenc New Branches: el6 Owners: petersen InitialCC: haskell-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 --- Comment #7 from Fedora Update System 2010-03-04 22:31:27 EST --- ghc-dataenc-0.13.0.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 --- Comment #6 from Fedora Update System 2010-03-04 06:06:53 EST --- ghc-dataenc-0.13.0.2-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ghc-dataenc-0.13.0.2-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 --- Comment #5 from Jason Tibbitts 2010-03-01 11:57:09 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jens Petersen 2010-02-28 21:05:59 EST --- New Package CVS Request === Package Name: ghc-dataenc Short Description: Haskell encoding library Owners: petersen Branches: F-13 InitialCC: haskell-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 --- Comment #3 from Jens Petersen 2010-02-28 21:00:42 EST --- oops Meant to continue: (In reply to comment #2) > Yeah it is cabal2spec not being that smart: binlib is getting triggered by "executable test" in the .cabal file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Jens Petersen 2010-02-28 20:53:50 EST --- Thanks Conrad. (In reply to comment #1) > I'm curious, cabal2spec-diff wants it to be binlib, not lib. Any idea? Yeah it is cabal2spec not being that smart: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=558058
Conrad Meyer changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Conrad Meyer 2010-02-28 02:44:24 EST ---
BAD = Please fix.
N/A = Doesn't apply to this package.
YES = Fine.
??? = I have some question(s).
- [ YES ] MUST: rpmlint must be run on every package. The output should
be posted in the review.
ghc-dataenc.spec: W: no-cleaning-of-buildroot %install
ghc-dataenc.spec: W: no-buildroot-tag
ghc-dataenc.src: W: spelling-error Summary(en_US) Haskell -> Harrell,
Rathskeller, Hastily
ghc-dataenc.src: W: spelling-error %description -l en_US uuencode -> encoder,
encode, Unicode
ghc-dataenc.src: W: spelling-error %description -l en_US xxencode -> xx encode,
xx-encode, encoder
ghc-dataenc.src: W: spelling-error %description -l en_US yEncoding -> y
Encoding, encoding, yen coding
ghc-dataenc.src: W: no-cleaning-of-buildroot %install
ghc-dataenc.src: W: no-buildroot-tag
1 packages and 1 specfiles checked; 0 errors, 8 warnings.
Spelling warnings are ignorable; the other warnings are also ignorable, I
think we decided.
- [ YES ] MUST: The package must be named according to the Package Naming
Guidelines.
- [ YES ] MUST: The spec file name must match the base package %{name},
in the format %{name}.spec unless your package has an exemption on
Package Naming Guidelines.
- [ ??? ] MUST: The package must meet the Packaging Guidelines.
I'm curious, cabal2spec-diff wants it to be binlib, not lib. Any idea?
Otherwise, looks good.
- [ YES ] MUST: The package must be licensed with a Fedora approved
license and meet the Licensing Guidelines.
- [ YES ] MUST: The License field in the package spec file must match
the actual license.
- [ YES ] MUST: If (and only if) the source package includes the text
of the license(s) in its own file, then that file, containing the text
of the license(s) for the package must be included in %doc.
- [ YES ] MUST: The spec file must be written in American English.
- [ YES ] MUST: The spec file for the package MUST be legible. If the
reviewer is unable to read the spec file, it will be impossible to
perform a review. Fedora is not the place for entries into the
Obfuscated Code Contest (http://www.ioccc.org/).
- [ YES ] MUST: The sources used to build the package must match the
upstream source, as provided in the spec URL. Reviewers should use
md5sum for this task. If no upstream URL can be specified for this
package, please see the Source URL Guidelines for how to deal with this.
sha512sum =
e64138df9d2815af5ad7871ffb3d2b7199183b6991e40929d620b8d8de06f2e22a4104ac317bf485ee98018c25afef7125314fc037ec94de9ba0973f6f190198
- [ YES ] MUST: The package must successfully compile and build into
binary rpms on at least one supported architecture.
Tested on x86_64.
- [ N/A ] MUST: If the package does not successfully compile, build or
work on an architecture, then those architectures should be listed in
the spec in ExcludeArch. Each architecture listed in ExcludeArch needs
to have a bug filed in bugzilla, describing the reason that the package
does not compile/build/work on that architecture. The bug number should
then be placed in a comment, next to the corresponding ExcludeArch line.
New packages will not have bugzilla entries during the review process,
so they should put this description in the comment until the package is
approved, then file the bugzilla entry, and replace the long explanation
with the bug number. The bug should be marked as blocking one (or more)
of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86, FE-ExcludeArch-x64, FE-ExcludeArch-ppc,
FE-ExcludeArch-ppc64
- [ YES ] MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of the Packaging
Guidelines; inclusion of those as BuildRequires is optional.
Apply common sense.
- [ N/A ] MUST: The spec file MUST handle locales properly. This is done
by using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
- [ N/A ] MUST: Every binary RPM package which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
- [ N/A ] MUST: If the package is designed to be relocatable, the packager
must state this fact in the request for review, along with the
rationalization for relocation of that specific package. Without this,
use of Prefix: /usr is considered a blocker.
- [ YES ] MUST: A package must own all directories that it creates. If
it does not create a directory that it uses, then it should require a
package which does create that directory. Refer to the Guidelines for
examples.
- [ YES ] MUST: A package must
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Conrad Meyer changed: What|Removed |Added CC||kon...@tylerc.org AssignedTo|nob...@fedoraproject.org|kon...@tylerc.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Status Whiteboard||ready -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558058] Review Request: ghc-dataenc - Haskell encoding library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558058 Jens Petersen changed: What|Removed |Added Blocks||522953 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
