[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 --- Comment #9 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-11 05:07:01 EST --- cvs import done. https://fedorahosted.org/rel-eng/ticket/3376 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #10 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-11 14:48:52 EST --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1978297 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560170
Mohammed Morsi mmo...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #6 from Mohammed Morsi mmo...@redhat.com 2010-02-10 13:06:03 EST
---
(In reply to comment #5)
(In reply to comment #4)
Even though this is in the orphaned specfile, the following line doesn't
work
(try it yourself):
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this if you want:
find \( -name '*.class' -o -name '*.jar' \) -exec rm -rf {} \;
or this:
find ./ -name '*.jar' -exec rm -f '{}' \;
find ./ -name '*.class' -exec rm -f '{}' \;
fixed as described.
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
fixed.
Great, thanks for both of these.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jcodings/F-11/jcodings.spec?view=markup
The clause with find was only a line that has not been changed in the spec.
So, I've considered it as a new package, and a history, from my viewpoint, is
not interesting for anybody. Nevertheless, if you prefer then I'll save the
changelog.
Ya, think it's good to leave it in, not only for the specfile but just so we
can see the package maintainer history and that it matches up w/ the cvs commit
history.
The second release is prepared for review:
Spec URL: http://victorv.fedorapeople.org/files/jcodings.spec
SRPM URL: http://victorv.fedorapeople.org/files/jcodings-1.0.2-2.fc13.src.rpm
Excellent, went through all the review guidelines and it fully passes.
APPROVED
Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import
the package. Close this bug as RAWHIDE once it's been successfully imported
and built.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-10 14:41:30 EST --- Package Change Request == Package Name: jcodings New Branches: Owners: mmorsi victorv Updated Description: Java-based codings helper classes for Joni and JRuby The package https://admin.fedoraproject.org/pkgdb/packages/name/jcodings exists, but has been orphaned and deprecated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560170
--- Comment #4 from Mohammed Morsi mmo...@redhat.com 2010-02-08 13:49:17 EST
---
Looks good for most part, builds find in mock/koji and passes most review
guidelines.
A couple of specifics though:
Even though this is in the orphaned specfile, the following line doesn't work
(try it yourself):
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this if you want:
find \( -name '*.class' -o -name '*.jar' \) -exec rm -rf {} \;
or this:
find ./ -name '*.jar' -exec rm -f '{}' \;
find ./ -name '*.class' -exec rm -f '{}' \;
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jcodings/F-11/jcodings.spec?view=markup
I would leave those in and add a bit about gcj support being removed for
jcodings. I had tried getting gcj/jcodings working myself to no avail,
aot-compile-rpm blocks indefinetly, consuming more and more resources. If you
can figure out the problem, adding gcj support is easy, if not just add a note
to the changelog.
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||mmo...@redhat.com --- Comment #2 from Thomas Spura toms...@fedoraproject.org 2010-02-04 08:27:15 EST --- *** Bug 561464 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Blocks||561484 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Blocks||560172 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Blocks||560169 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Blocks||541638 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
