[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 --- Comment #8 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-11 06:09:17 EST --- cvs import done. https://fedorahosted.org/rel-eng/ticket/3378 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Bug 560172 depends on bug 560170, which changed state. Bug 560170 Summary: Review Request: jcodings - Java-based codings helper classes for Joni and JRuby https://bugzilla.redhat.com/show_bug.cgi?id=560170 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Bug 560172 depends on bug 560169, which changed state. Bug 560169 Summary: Review Request: bytelist - A java library for lists of bytes https://bugzilla.redhat.com/show_bug.cgi?id=560169 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #9 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-11 15:27:04 EST --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1978440 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 --- Comment #3 from Mohammed Morsi mmo...@redhat.com 2010-02-10 14:31:22 EST --- I think you mistakingly uploaded the built rpm instead of the srpm for the latest release. I'll continue w/ the review once the SRPM is uploaded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 --- Comment #4 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-10 14:56:38 EST --- Sorry for my fault. The release 4 is prepared for review: Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Mohammed Morsi mmo...@redhat.com 2010-02-10 15:21:26 EST --- (In reply to comment #4) Sorry for my fault. The release 4 is prepared for review: Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.src.rpm Everything looks good. Package is fully compliant w/ guidelines and builds fine in mock when jcodings, bytelist dependencies are installed. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-10 15:34:19 EST --- Package Change Request == Package Name: jvyamlb New Branches: Owners: victorv Updated Description: YAML processor for JRuby The package https://admin.fedoraproject.org/pkgdb/packages/name/jvyamlb exists, but has been orphaned and deprecated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2010-02-11 01:21:59 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560172
Mohammed Morsi mmo...@redhat.com changed:
What|Removed |Added
CC||mmo...@redhat.com
--- Comment #1 from Mohammed Morsi mmo...@redhat.com 2010-02-08 14:19:55 EST
---
Looks good for most part, builds find in mock and passes most review
guidelines.
A couple of specifics though:
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup
Also I didn't try, but if it works w/ gcj (java-devel = 1.5) adding gcj
support to the spec is relatively easy:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560172
--- Comment #2 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-08
21:13:43 EST ---
(In reply to comment #1)
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
fixed according to the Specfile Template for ant
https://fedoraproject.org/wiki/Packaging:Java#ant_2
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
fixed
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup
No, changelog in the release 0.2.5-3 contains full history.
Also I didn't try, but if it works w/ gcj (java-devel = 1.5) adding gcj
support to the spec is relatively easy:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
Releases of the package was never containing gcj bits.
We shouldn't add stuff of the deprecated technology into this package.
Clarification is here:
https://bugzilla.redhat.com/show_bug.cgi?id=560170#c5
The release 4 is prepared for review:
Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec
SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.noarch.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Victor G. Vasilyev victor.vasil...@sun.com changed: What|Removed |Added Depends on||560169, 560170 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
