[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
https://bugzilla.redhat.com/show_bug.cgi?id=560457 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
https://bugzilla.redhat.com/show_bug.cgi?id=560457 anish apa...@redhat.com changed: What|Removed |Added CC||apa...@redhat.com --- Comment #15 from anish apa...@redhat.com --- Package Change Request == Package Name: pyutil New Branches: el6 epel7 Owners: anishpatil InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
https://bugzilla.redhat.com/show_bug.cgi?id=560457 anish apa...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
https://bugzilla.redhat.com/show_bug.cgi?id=560457 Vladimir Stackov amigo.el...@gmail.com changed: What|Removed |Added Blocks||1189917 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1189917 [Bug 1189917] pyutil in EPEL -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #14 from Jason Tibbitts ti...@math.uh.edu 2010-02-19 14:11:27 EST --- CVS done (by process-cvs-requests.py). Added an F-13 branch as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-16 11:43:07 EST --- Okay. - This package (pyutil) is APPROVED by mtasaka - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-13 06:27:37 EST --- I think either will do, however I would rename the files rather than deleting the files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #9 from Ruben Kerkhof ru...@rubenkerkhof.com 2010-02-13 07:42:13 EST --- Thanks, I've renamed them Spec URL: http://ruben.fedorapeople.org/pyutil.spec SRPM URL: http://ruben.fedorapeople.org/pyutil-1.6.1-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-13 11:28:12 EST --- Well, * BuildRequires/Requires - Please check if python-zbase32 python-twisted-core python-argparse should be listed only for BuildRequires. ! For example ./pyutil/iputil.py contains: - 9 # from Twisted 10 from twisted.internet import defer, reactor 11 from twisted.python import failure 12 from twisted.internet.protocol import DatagramProtocol 13 from twisted.internet.utils import getProcessOutput 14 from twisted.python.procutils import which 15 from twisted.python import log - It seems that pyutil should also have Requires: python-twisted-core. * rpmlint - pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_iputil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_picklesaver.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/scripts/randfile.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/scripts/randcookie.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_mathutil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/lineutil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_template 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_dictutil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/benchmarks/bench_xor.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_time_format.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_strutil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/scripts/tailx.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_odict.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_zlibutil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/scripts/lines.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/scripts/memdump2dot.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/scripts/unsort.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_assertutil.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_xor.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_cache.py 0644L /usr/bin/env pyutil.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyutil/test/test_jsonutil.py 0644L /usr/bin/env - - These scripts should not have shebang. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #11 from Ruben Kerkhof ru...@rubenkerkhof.com 2010-02-13 12:41:44 EST --- Thanks, it should be fixed: Spec URL: http://ruben.fedorapeople.org/pyutil.spec SRPM URL: http://ruben.fedorapeople.org/pyutil-1.6.1-4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #4 from Ruben Kerkhof ru...@rubenkerkhof.com 2010-02-12 14:28:31 EST --- Fixed: Spec URL: http://ruben.fedorapeople.org/pyutil.spec SRPM URL: http://ruben.fedorapeople.org/pyutil-1.6.1-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #5 from Thomas Moulard thomas.moul...@gmail.com 2010-02-12 15:20:45 EST --- pyutil-1.6.1-2.fc13.src.rpm builds correctly: http://koji.fedoraproject.org/koji/taskinfo?taskID=1980824 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-13 02:37:12 EST --- Well, I don't think that putting files with some generic names like lines unsort under /usr/bin/ is preferable and this leaves room for discussion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 --- Comment #2 from Ruben Kerkhof ru...@rubenkerkhof.com 2010-02-10 07:35:41 EST --- FYI, python-zbase32 is in Rawhide now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560457
Thomas Moulard thomas.moul...@gmail.com changed:
What|Removed |Added
CC||thomas.moul...@gmail.com
--- Comment #1 from Thomas Moulard thomas.moul...@gmail.com 2010-02-01
12:24:05 EST ---
Note: I am not an official Fedora reviewer, so this is only a pre-review.
# MUST: rpmlint must be run on every package. The output should be
posted in the review.
OK
$ rpmlint -i SRPMS/pyutil-1.6.1-1.fc13.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# MUST: The package must be named according to the Package Naming
Guidelines.
OK
# MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
OK
# MUST: The package must meet the Packaging Guidelines.
OK:
- python_sitelib correctly detected
Python egg:
* Must: Python eggs must be built from source. They cannot simply drop an egg
from upstream into the proper directory.
OK
* Must: Python eggs must not download any dependencies during the build
process.
?? Did not succeed to resolve the mutual dependency between pyutil and
python-zbase32 so it did download python-zbase32 from the net. I guess it will
not happen if both packages are accepted.
* Must: If egg-info files are generated by the modules build scripts they must
be included in the package.
OK
* Must: When building a compat package, it must install using easy_install -m
so it won't conflict with the main package.
N/A
* Must: When building multiple versions (for a compat package) one of the
packages must contain a default version that is usable via import MODULE with
no prior setup.
N/A
* Should: A package which is used by another package via an egg interface
should provide egg info.
N/A
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK (GPLv2+)
# MUST: The License field in the package spec file must match the
actual license. [3]
OK (see COPYING.GPL)
# MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.[4]
OK (COPYING.GPL in %doc)
# MUST: The spec file must be written in American English. [5]
OK
# MUST: The spec file for the package MUST be legible. [6]
OK
# MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
OK
# MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture. [7]
OK (noarch package)
# MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the
spec in ExcludeArch. Each architecture listed in ExcludeArch MUST
have a bug filed in bugzilla, describing the reason that the package
does not compile/build/work on that architecture. The bug number
MUST be placed in a comment, next to the corresponding ExcludeArch
line. [8]
N/A
# MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging
Guidelines ; inclusion of those as BuildRequires is optional. Apply
common sense.
Sounds OK for me, but I do not know Python enough be sure at 100% that
all imports are standards ones.
# MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.[9]
N/A
# MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun. [10]
N/A
# MUST: Packages must NOT bundle copies of system libraries.[11]
OK
# MUST: If the package is designed to be relocatable, the packager
must state this fact in the request for review, along with the
rationalization for relocation of that specific package. Without
this, use of Prefix: /usr is considered a blocker. [12]
OK
# MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a
package which does create that directory. [13]
OK
# MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. [14]
OK
# MUST: Permissions on files must be set properly. Executables should
be set with executable permissions, for example. Every %files
section must include a
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Blocks||521716 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560457 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Depends on||560460 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
