[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-05-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||phpesp-2.1.1-2.fc12
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-05-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2010-05-04 02:03:17 EDT ---
phpesp-2.1.1-2.fc12 has been pushed to the Fedora 12 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-05-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-05-04 02:24:24 EDT ---
phpesp-2.1.1-2.fc11 has been pushed to the Fedora 11 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-03-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2010-03-10 01:41:18 EST ---
phpesp-2.1.1-2.fc12 has been pushed to the Fedora 12 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update phpesp'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/phpesp-2.1.1-2.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-03-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2010-03-08 10:47:17 EST ---
phpesp-2.1.1-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/phpesp-2.1.1-2.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-03-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2010-03-08 10:47:11 EST ---
phpesp-2.1.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/phpesp-2.1.1-2.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

David Nalley da...@gnsa.us changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from David Nalley da...@gnsa.us 2010-02-28 14:35:43 EST ---
Thanks for the review Hiemanshu!!!


New Package CVS Request
===
Package Name: phpesp
Short Description: PHP-based web survey application
Owners: ke4qqq
Branches: F-11 F-12 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #6 from David Nalley da...@gnsa.us 2010-02-27 23:53:07 EST ---
Per our conversation in irc: 

http://koji.fedoraproject.org/koji/taskinfo?taskID=2018829

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #7 from Hiemanshu Sharma hieman...@gmail.com 2010-02-28 00:04:56 
EST ---
The package looks good to me. Approved.

- Hiemanshu

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

Hiemanshu Sharma hieman...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #4 from Hiemanshu Sharma hieman...@gmail.com 2010-02-19 07:00:35 
EST ---
Please fix it before I can continue

- Hiemanshu Sharma

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #3 from David Nalley da...@gnsa.us 2010-02-12 19:54:02 EST ---
Hiemanshu: 

I may have overlooked other things, but the one thing I see as a fix, is
buildroot. 
When I look at the Packaging Guidelines here
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag  my buildroot
seems to look acceptable though not the most preferred. 
If you still want this changed, let me know. 

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

Hiemanshu himanshu.shar...@gmail.com changed:

   What|Removed |Added

 CC||himanshu.shar...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #1 from David Nalley da...@gnsa.us 2010-02-11 12:26:32 EST ---
[ke4...@nalleyx60 SPECS]$ rpmlint ./phpesp.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ke4...@nalleyx60 SPECS]$ rpmlint ../SRPMS/phpesp-2.1.1-1.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ke4...@nalleyx60 SPECS]$ rpmlint ../RPMS/noarch/phpesp-2.1.1-1.fc12.noarch.rpm 
phpesp.noarch: W: dangling-symlink /usr/share/phpesp/admin/include/lib/adodb
/usr/share/php/adodb
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

Hiemanshu Sharma hieman...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561235] Review Request: phpesp - PHP-based survey web application

2010-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561235

--- Comment #2 from Hiemanshu Sharma hieman...@gmail.com 2010-02-11 13:54:26 
EST ---
- Package meets naming guidelines
0 Spec file matches base package name.
0 Spec has consistant macro usage.
- Meets Packaging Guidelines.
0 License
0 License field in spec matches
0 License file included in package
0 Spec in American English
0 Spec is legible.
0 Sources match upstream md5sum:
  9d5e68fa1af1f4d91da34e76ed95fe19  phpESP-2.1.1.tgz
* Package needs ExcludeArch
0 BuildRequires correct
* Spec handles locales/find_lang
* Package is relocatable and has a reason to be.
0 Package has %defattr and permissions on files is good.
0 Package has a correct %clean section.
x Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
0 Package is code or permissible content.
* Doc subpackage needed/used.
0 Packages %doc files don't affect runtime.

* Headers/static libs in -devel subpackage.
* Spec has needed ldconfig in post and postun
* .pc files in -devel subpackage/requires pkgconfig
* .so files in -devel subpackage.
* -devel package Requires: %{name} = %{version}-%{release}
* .la files are removed.

* Package is a GUI app and has a .desktop file

0 Package compiles and builds on at least one arch.
0 Package has no duplicate files in %files.
0 Package doesn't own any directories other packages own.
0 Package owns all the directories it creates.
0 No rpmlint output. [False Positive]
0 final provides and requires are sane:
Provides:
phpesp-2.1.1-1.fc12.noarch.rpm
config(phpesp) = 2.1.1-1.fc12
phpesp = 2.1.1-1.fc12
Requires:
/bin/sh  
/usr/bin/perl  
config(phpesp) = 2.1.1-1.fc12
perl(strict)  
php = 4.2.1
php-adodb  
php-gettext  
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
webserver  
rpmlib(PayloadIsXz) = 5.2-1

SHOULD Items:

- Should build in mock.
0 Should build on all supported archs
0 Should function as described.
0 Should have sane scriptlets.
* Should have subpackages require base package with fully versioned depend.
0 Should have dist tag
0 Should package latest version
* check for outstanding bugs on package. (For core merge reviews)

[-] To be checked
[x] Need fixing
[*] NA
[0] Checked

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review