[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #12 from Peter Robinson pbrobin...@gmail.com 2010-05-23 17:34:00 EDT --- Built and in rawhide. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #9 from Peter Robinson pbrobin...@gmail.com 2010-05-20 10:16:51 EDT --- (In reply to comment #8) Everything looks fine. APPROVED. Thanks As a side note, if libsocialweb is not source-compatible with mojito (as in mojito-dependent packages could be rebuilt to depend on it), then I don't see why a Provides/Obsoletes needs to be added at all. It will primarily be enable clean upgrades due to packages that currently depend on mojito will depend on l-s-w so we don't leave mojito around. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Peter Robinson pbrobin...@gmail.com 2010-05-20 10:20:40 EDT --- New Package CVS Request === Package Name: libsocialweb Short Description: A social network data aggregator Owners: pbrobinson Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #11 from Kevin Fenzi ke...@tummy.com 2010-05-20 15:36:42 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 Michel Alexandre Salim michael.silva...@gmail.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #8 from Michel Alexandre Salim michael.silva...@gmail.com 2010-05-19 15:22:55 EDT --- Everything looks fine. APPROVED. As a side note, if libsocialweb is not source-compatible with mojito (as in mojito-dependent packages could be rebuilt to depend on it), then I don't see why a Provides/Obsoletes needs to be added at all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #7 from Peter Robinson pbrobin...@gmail.com 2010-05-12 04:38:10 EDT --- OK. We're on again. We have a git repo of the code! So updated SPEC: http://pbrobinson.fedorapeople.org/libsocialweb.spec SRPM: http://pbrobinson.fedorapeople.org/libsocialweb-0.24.8-1.fc13.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2182111 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added CC||cwick...@fedoraproject.org --- Comment #5 from Christoph Wickert cwick...@fedoraproject.org 2010-04-06 15:32:52 EDT --- If this is a renamed mojito, it needs Provides:/Obsoltes: for it. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #6 from Peter Robinson pbrobin...@gmail.com 2010-04-06 15:55:54 EDT --- (In reply to comment #5) If this is a renamed mojito, it needs Provides:/Obsoltes: for it. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages That is known. See note in comment 1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562097
Michel Alexandre Salim michael.silva...@gmail.com changed:
What|Removed |Added
Flag||needinfo?(pbrobin...@gmail.
||com)
--- Comment #2 from Michel Alexandre Salim michael.silva...@gmail.com
2010-03-31 14:44:48 EDT ---
I did a diff to the current mojito.spec from the development branch, and the
diff looks reasonable -- though there are some oddities:
(for main package)
+%{_libdir}/libsocialweb*.0 .2
+%{_libdir}/libsocialweb*.1
won't libsocialweb*.so.* be clearer -- and won't break when they bump the
soname?
(for devel)
+%{_libdir}/libsocialweb*so
likewise here -- libsocialweb*.so is probably more canonical
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag|needinfo?(pbrobin...@gmail. | |com)| --- Comment #3 from Peter Robinson pbrobin...@gmail.com 2010-03-31 14:49:55 EDT --- Agreed. Will update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #4 from Michel Alexandre Salim michael.silva...@gmail.com 2010-03-31 15:39:47 EDT --- Here's the full review. The license need to be reverted to what mojito has (but with LGPLv2, not LGPLv2.1 -- see http://fedoraproject.org/wiki/Licensing#Good_Licenses And if you could locate a source tarball now that moblin.org is down, and update the SRPM, I could approve the review. Review == Problems rpmlint: only one real warning, the invalid URL. Change to new MeeGo URL when committing $ rpmlint libsocialweb-0.24.0-1.fc12.src.rpm ~/Downloads/libsocialweb* libsocialweb.src: W: spelling-error Summary(en_US) aggregator - aggregation, aggregate, aggressor libsocialweb.src: W: invalid-url Source0: http://download.moblin.org/sources/libsocialweb/0.24/libsocialweb-0.24.0.tar.bz2 HTTP Error 404: Not Found libsocialweb.x86_64: W: spelling-error Summary(en_US) aggregator - aggregation, aggregate, aggressor 4 packages and 0 specfiles checked; 0 errors, 3 warnings. License accurate: FIX -- a spot check shows that many files are LGPLv2 without any mention of using any later version. Upstream source: FIX -- can't check until MeeGo downloads available Passes -- Package spec names: OK Fit for inclusion:OK (rename of existing mojito) Content: OK License acceptable: OK License included: OK Spec language:OK (US English, legible) Compiles: OK see http://koji.fedoraproject.org/koji/taskinfo?taskID=2087590 Complete BRs: OK Locale: OK ldconfig: OK no bundled libs: OK Dir ownership:OK No dup files: OK File perms: OK UTF-8 files: OK %clean: OK rm on %install: OK Consistent macros:OK Large docs: NA %doc unessential: OK Headers in -devel:OK *.so.* - *.so in -devel: OK Static in -static:NA -devel Req: main: OK No .la: OK Desktop files:NA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 Michel Alexandre Salim michael.silva...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||michael.silva...@gmail.com AssignedTo|nob...@fedoraproject.org|michael.silva...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562097] Rename request: libsocialweb - A social network data aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #1 from Peter Robinson pbrobin...@gmail.com 2010-02-28 11:11:36 EST --- Updated to the 0.24.0 release SPEC: http://pbrobinson.fedorapeople.org/libsocialweb.spec SRPM: http://pbrobinson.fedorapeople.org/libsocialweb-0.24.0-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
