[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Jesse Keating jkeat...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #12 from Terje Røsten terje...@phys.ntnu.no 2010-02-14 14:01:58 EST --- Jesse, could you please import and close? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Jesse Keating jkeat...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Jesse Keating jkeat...@redhat.com 2010-02-09 13:15:28 EST --- New Package CVS Request === Package Name: GitPython Short Description: GitPython is a python library used to interact with Git repositories. Owners: jkeating Branches: F-12 F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? --- Comment #2 from Terje Røsten terje...@phys.ntnu.no 2010-02-08 12:29:16 EST --- Review coming up soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #3 from Terje Røsten terje...@phys.ntnu.no 2010-02-08 12:42:16 EST --- rpmlint is clean, source tarball has correct check sum, no licenses issues. noarch is correct, own dirs as it should, perms are good. it builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1969293 However, there are some minor things to fix, all of which I have created a patch for: - Add python-setuptools to buildreq - Explicit file list - Use version macro in source url The only issue I see is the name, would python-git be a better package name? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #4 from Terje Røsten terje...@phys.ntnu.no 2010-02-08 12:43:50 EST --- Created an attachment (id=389585) -- (https://bugzilla.redhat.com/attachment.cgi?id=389585) Patch to build in koji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|terje...@phys.ntnu.no -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #5 from Thomas Spura toms...@fedoraproject.org 2010-02-08 14:47:28 EST --- Jesse, what is this programm for? dist-git? (Just want to know, what work needs to be done, to switch to python3 sometime. This does not build for python3 even after 2to3 running on it :( ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #7 from Jesse Keating jkeat...@redhat.com 2010-02-08 20:19:21 EST --- This is for dist-git yes. Hrm, this builds in koji fine, why does it need python-setuptools as a BuildRequirement ? I used GitPython as that is the upstream project name. That seems to fall under the naming guidelines for python http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 since GitPython has Py in the name. I'll look at the other issues and re-post. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #8 from Jesse Keating jkeat...@redhat.com 2010-02-08 20:42:46 EST --- Spec URL: http://jkeating.fedorapeople.org/review/GitPython.spec SRPM URL: http://jkeating.fedorapeople.org/review/GitPython-0.1.6-2.fc12.src.rpm Updated with suggested changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Terje Røsten terje...@phys.ntnu.no 2010-02-09 02:01:24 EST --- setuptools is needed in setup.py and python-devel don't bring that to the table. Name is according to guide lines so we are finished. The package GitPython is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
