[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 --- Comment #11 from Fedora Update System 2010-03-14 09:39:16 EDT --- aduna-commons-text-2.6.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||aduna-commons-text-2.6.0-3. ||fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #10 from Fedora Update System 2010-03-02 20:48:27 EST --- aduna-commons-text-2.6.0-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update aduna-commons-text'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3351 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 --- Comment #9 from Fedora Update System 2010-03-01 10:54:53 EST --- aduna-commons-text-2.6.0-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/aduna-commons-text-2.6.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 --- Comment #8 from Jason Tibbitts 2010-02-24 15:08:03 EST --- CVS done (by process-cvs-requests.py). I added an F-13 branch as well, since that seems to have been left out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Mary Ellen Foster changed: What|Removed |Added Blocks||567952 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Mary Ellen Foster changed: What|Removed |Added Blocks||567951 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Mary Ellen Foster changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Mary Ellen Foster 2010-02-24 05:50:49 EST --- New Package CVS Request === Package Name: aduna-commons-text Short Description: Manipulate/transform/parse text in various ways Owners: mef Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Mat Booth changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Mat Booth 2010-02-23 15:01:40 EST --- Thanks for the easy review. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 --- Comment #5 from Mary Ellen Foster 2010-02-23 09:07:57 EST --- New version: - Remove BuildRequirements that are pulled in by aduna-commons POM - Require the main package in the javadoc http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text.spec http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text-2.6.0-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=563479
--- Comment #4 from Mat Booth 2010-02-14 07:55:32 EST
---
One more thing:
It is usual for sub-packages (i.e. the javadoc package) to have a fully
versioned dependency on the main package:
Requires: %{name} = %{version}-%{release}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=563479
--- Comment #3 from Mat Booth 2010-02-14 07:50:34 EST
---
Rpmlint shows:
aduna-commons-text.x86_64: W: no-documentation
aduna-commons-text.x86_64: W: non-conffile-in-etc
/etc/maven/fragments/aduna-commons-text
But I'm not worried about that: Upstream does not seem to include a copy of the
licence to use as documentation and the other warning is expected because of
the maven dep-map fragment.
Overall, this is a very compliant package. The only thing I would suggest is to
have something that ensures no pre-compiled classes are shipped in the source
jar and used during the build. Not because that is the case with this package,
but because it is good practice for Java packages in general.
Something like this in the %prep section would suffice[1]:
find -name '*.class' -exec rm -f '{}' \;
find -name '*.jar' -exec rm -f '{}' \;
[1] Taken from the template in the Java packaging guidelines:
http://fedoraproject.org/wiki/Packaging:Java#ant_2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Mat Booth changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|fed...@matbooth.co.uk Flag||fedora-review? --- Comment #2 from Mat Booth 2010-02-13 13:19:59 EST --- I will take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 --- Comment #1 from Mary Ellen Foster 2010-02-11 06:07:22 EST --- Updated version with extra BuildRequirement: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text-2.6.0-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563479] Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563479 Mary Ellen Foster changed: What|Removed |Added Depends on||561439 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
