[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

--- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2010-02-28 17:32:32 EST 
---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-28 
18:04:16 EST ---
sugar-tamtam-0-0.3.20100201git.fc13 has been submitted as an update for Fedora
13.
http://admin.fedoraproject.org/updates/sugar-tamtam-0-0.3.20100201git.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-02-28 
20:38:02 EST ---
sugar-tamtam-0-0.3.20100201git.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-28 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||sugar-tamtam-0-0.3.20100201
   ||git.fc13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-27 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

--- Comment #2 from Sebastian Dziallas sebast...@when.com 2010-02-27 17:07:17 
EST ---
(In reply to comment #1)

I uploaded a new version.

Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-tamtam.spec
SRPM URL:
http://sdz.fedorapeople.org/rpmbuild/sugar-tamtam-0-0.2.20100201git.fc12.src.rpm

 Issues:
 - The sugar-tamtam package should be called sugar-tamtam-common because it is
 not a standalone package. The srpm and spec will still be called sugar-tamtam.

I moved the common files into a common package. Rpmlint complains now about the
main package containing no binary, though.

 - Due to python3 the python guidelines have changed recently. Please update 
 the
 macro definitions acording to
 https://fedoraproject.org/wiki/Packaging/Python#Macros
 
 - You can drop python_sitelib because it is not needed here.

Both done!

 - make is not verbose so compiler flags cannot be verified.

I added the V=1 parameter, so that should be good, too.

 - add -p to preserve timestamps when using cp -r 

Done.

 - the command to install the package should be
 %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
 instead of
 python ./setup.py install --prefix=$RPM_BUILD_ROOT/%{_prefix}

We discussed this on IRC; setup.py seems to have issues with the other
invocation.

 - Typos: organise - organize, synthesiser - synthesizer

Fixed these and a few other typos.

 - backup-file-in-package: Are these files needed?

I don't think so and have removed them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-27 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Christoph Wickert cwick...@fedoraproject.org 2010-02-27 
17:41:22 EST ---
(In reply to comment #2)
 I moved the common files into a common package. Rpmlint complains now about 
 the
 main package containing no binary, though.

This is ok, the lib in %{python_sitearch}/tamtam *is* binary.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-27 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

Sebastian Dziallas sebast...@when.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Sebastian Dziallas sebast...@when.com 2010-02-27 18:03:45 
EST ---
New Package CVS Request
===
Package Name: sugar-tamtam
Short Description: A suite of four music and sound related activities
Owners: sdz
Branches: F-13 F-12 F-11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-27 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

--- Comment #5 from Sebastian Dziallas sebast...@when.com 2010-02-27 18:04:26 
EST ---
Thanks for the review! I'll import an updated version that doesn't build the -
empty - base package, as discussed on IRC.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-22 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

Christoph Wickert cwick...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cwick...@fedoraproject.org
 AssignedTo|nob...@fedoraproject.org|cwick...@fedoraproject.org
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 564425] Review Request: sugar-tamtam - A suite of four music and sound related activities

2010-02-12 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564425

Sebastian Dziallas sebast...@when.com changed:

   What|Removed |Added

 Blocks||558617(SOAS-3)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review