[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||constantine-backgrounds-12. ||1.1-3.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #12 from Fedora Update System 2010-02-26 06:50:20 EST --- constantine-backgrounds-12.1.1-3.fc13, goddard-backgrounds-12.91.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #11 from Fedora Update System 2010-02-19 22:48:55 EST --- constantine-backgrounds-12.1.1-3.fc13, goddard-backgrounds-12.91.0-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update constantine-backgrounds goddard-backgrounds'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-1709 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #9 from Fedora Update System 2010-02-19 17:43:48 EST --- constantine-backgrounds-12.1.1-3.fc13,goddard-backgrounds-12.91.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/constantine-backgrounds-12.1.1-3.fc13,goddard-backgrounds-12.91.0-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #10 from Fedora Update System 2010-02-19 17:44:53 EST --- constantine-backgrounds-12.1.1-3.fc13,goddard-backgrounds-12.91.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/constantine-backgrounds-12.1.1-3.fc13,goddard-backgrounds-12.91.0-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #8 from Jason Tibbitts 2010-02-19 15:09:14 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Rex Dieter changed: What|Removed |Added Blocks||566695 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Martin Sourada changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Martin Sourada 2010-02-19 03:04:25 EST --- New Package CVS Request === Package Name: goddard-backgrounds Short Description: Goddard desktop backgrounds Owners: mso Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566290
Luya Tshimbalanga changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #6 from Luya Tshimbalanga 2010-02-18
18:58:00 EST ---
Further review:
+ $ md5sum rpmbuild/SOURCES/goddard-backgrounds-12.91.0.tar.lzma
Download/goddard-backgrounds-12.91.0.tar.lzma
6db2255dbaf9e5d8609a1fe06b1629ee
rpmbuild/SOURCES/goddard-backgrounds-12.91.0.tar.lzma
6db2255dbaf9e5d8609a1fe06b1629ee Download/goddard-backgrounds-12.91.0.tar.lzma
+ md5sum extracted from srpm files matches md5sum the upstream source
+ Package succesfully compiled and built into binary rpms with noarch BuildArc
+ BuidRequires and requires are provided on spec file
+ No bundled copies of system libraires
+ Package owns all directories that it created
+ Files from %file are listed once in spec files
+ Permission on files are properly set.
+ Package is a clean section which contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Contents are wallpapers under CC-BY-SA created by Fedora Design team
+ Package runs rm -rf %{buildroot} at the beginning of %install
+ Filename in rm packages is valid UTF-8
+ Source package include license text as separate file
+ no scriptlets used
After thoroughly reviewed both srpm and spec file, goddard-backgrounds fully
complies to Fedora Packaging Guideline and set to accept.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #5 from Luya Tshimbalanga 2010-02-18 12:26:08 EST --- (In reply to comment #3) > Luya, do you want to claim this bug? Use the "take" link above so it's > assigned to you, and it won't look like it's unclaimed in the package review > queue. Thank you for working on this! No problem, I am taking care of this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Paul W. Frields changed: What|Removed |Added CC||sticks...@gmail.com --- Comment #3 from Paul W. Frields 2010-02-18 11:21:29 EST --- Luya, do you want to claim this bug? Use the "take" link above so it's assigned to you, and it won't look like it's unclaimed in the package review queue. Thank you for working on this! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Paul W. Frields changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|l...@fedoraproject.org --- Comment #4 from Paul W. Frields 2010-02-18 11:22:25 EST --- Oh wait, I can just do that myself, sorry! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Paul W. Frields changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #2 from Martin Sourada 2010-02-18 05:40:22 EST --- (In reply to comment #1) > $ rpmlint Downloads/goddard-backgrounds-12.91.0-1.fc12.src.rpm > goddard-backgrounds.src:35: W: unversioned-explicit-provides > system-backgrounds-kde > goddard-backgrounds.src:50: W: unversioned-explicit-provides > system-backgrounds > 1 packages and 0 specfiles checked; 0 errors, 2 warnings. > It's the same in constantine-backgrounds, I don't think these provides need versioning. It might be the other way around. Although, come to think, it should be for >= fedora 13, not for >= fedora 12 where this is provided by constantine-backgrounds... Updated SPEC: http://mso.fedorapeople.org/packages/SPECS/goddard-backgrounds.spec Updated SRPM: http://mso.fedorapeople.org/packages/SRPMS/goddard-backgrounds-12.91.0-2.fc12.src.rpm Also, when you will run rpmlint on the binary packages there'll be lots of dangling symlinks warnings on -kde subpackage. These are expected as they link to the images in -single subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Luya Tshimbalanga changed: What|Removed |Added CC||l...@fedoraproject.org --- Comment #1 from Luya Tshimbalanga 2010-02-18 04:55:00 EST --- $ rpmlint Downloads/goddard-backgrounds-12.91.0-1.fc12.src.rpm goddard-backgrounds.src:35: W: unversioned-explicit-provides system-backgrounds-kde goddard-backgrounds.src:50: W: unversioned-explicit-provides system-backgrounds 1 packages and 0 specfiles checked; 0 errors, 2 warnings. + Package is named according to Packaging:NamingGuidelines + The spec file name matches the base package goddard-background + License is CC-BY-SA + Spec file is in American English and legible Could you check about the warning message? I will continue to review once that is resolved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
