[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=566405 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #29 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: nmbscan New Branches: el6 epel7 Owners: fab rebus InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=566405 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #30 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2010-09-15 01:54:29 EDT --- nmbscan-1.2.6-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nmbscan-1.2.6-1.fc14|nmbscan-1.2.6-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2010-09-14 00:55:53 EDT --- nmbscan-1.2.6-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2010-09-11 21:50:31 EDT --- nmbscan-1.2.6-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nmbscan-1.2.6-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2010-09-11 21:50:24 EDT --- nmbscan-1.2.6-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/nmbscan-1.2.6-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2010-08-18 21:03:23 EDT --- nmbscan-1.2.5-5.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nmbscan-1.2.5-5.fc13|nmbscan-1.2.5-5.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2010-08-07 05:23:40 EDT --- nmbscan-1.2.5-5.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/nmbscan-1.2.5-5.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2010-08-07 05:23:34 EDT --- nmbscan-1.2.5-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/nmbscan-1.2.5-5.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2010-08-07 19:28:08 EDT --- nmbscan-1.2.5-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||nmbscan-1.2.5-5.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566405
--- Comment #17 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-08-05
03:43:48 EDT ---
Spec diff:
--- nmbscan.spec.orig 2010-04-17 17:26:19.0 +0300
+++ nmbscan.spec 2010-08-05 10:34:04.730173241 +0300
@@ -1,12 +1,13 @@
Name: nmbscan
Version:1.2.5
-Release:4%{?dist}
+Release:5%{?dist}
Summary:NMB/SMB network scanner
Group: Applications/Internet
License:GPLv2
-URL:http://nmbscan.gbarbier.org/
-Source0:http://nmbscan.gbarbier.org/down/%{name}-%{version}.tar.gz
+URL:http://nmbscan.g76r.eu/
+Source0:http://nmbscan.g76r.eu/down/%{name}-%{version}.tar.gz
+Source1:%{name}.1
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
@@ -20,9 +21,9 @@
Scans a SMB shares network, using NMB and SMB protocols. Useful to acquire
an information on a local area network (security audit, etc.)
-Matches the information such as NMB/SMB/Windows hostname, IP address, IP
-hostname, ethernet MAC address, Windows username, NMB/SMB/Windows domain name
-and master browser.
+Matches the information such as NMB/SMB/Windows host name, IP address,
+IP host name, Ethernet MAC address, Windows user name,
+NMB/SMB/Windows domain name and master browser.
Can discover all NMB/SMB/Windows hosts on a local area network thanks to
hosts lists maintained by master browsers.
@@ -33,12 +34,15 @@
%build
+# Nothing to build
%install
rm -rf %{buildroot}
install -d %{buildroot}%{_bindir}
-install -p -m 755 nmbscan %{buildroot}%{_bindir}/
+install -p -m 0755 nmbscan %{buildroot}%{_bindir}/
+install -d %{buildroot}%{_mandir}/man1
+install -p -m 0644 %{SOURCE1} %{buildroot}%{_mandir}/man1/
%clean
@@ -49,9 +53,15 @@
%defattr(-,root,root,-)
%doc Documentation/HOWTO_contribute.txt Documentation/gplv2.txt
%{_bindir}/%{name}
+%{_mandir}/man1/%{name}.1*
%changelog
+* Wed Aug 04 2010 Nikolay Ulyanitsky lystor AT lystor.org.ua - 1.2.5-5
+- Fixed the project URL
+- Added a man page (thx to Michal Ambroz)
+- Cosmetic changes
$ rpmlint nmbscan-1.2.5-5.fc13.noarch.rpm nmbscan-1.2.5-5.fc13.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Spec URL: http://repo.lystor.org.ua/fedora/13/SPECS/nmbscan.spec
SRPM URL:
http://repo.lystor.org.ua/fedora/13/SRPMS/nmbscan-1.2.5-5.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Nikolay Ulyanitsky lys...@lystor.org.ua changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-08-05 04:40:52 EDT --- New Package SCM Request === Package Name: nmbscan Short Description: NMB/SMB network scanner Owners: lystor rebus Branches: f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #20 from Kevin Fenzi ke...@tummy.com 2010-08-05 12:59:53 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #16 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-08-04 07:47:06 EDT --- Nikolay, are you still interested in this package? If so, please address the small remaining issues so that we can finish the review. Hi Yes. I am still interested in this package and I will finish the nmbscan review process as soon as I can. Also I allow Michal Ambroz to co-maintain the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #12 from manuel wolfshant wo...@nobugconsulting.ro 2010-08-03 02:41:53 EDT --- If Nikolay is busy and/or cannot finish this submission process, this bug should be closed and a new one should be submitted by the new maintainer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #13 from Michal Ambroz re...@seznam.cz 2010-08-03 07:27:53 EDT --- (In reply to comment #12) this bug should be closed and a new one should be submitted by the new maintainer. Hello Manuel, I beg to differ - I believe it is better to have it on one place and not split the effort. There is nothing wrong if package has more than one maintainer. In fact it is encouraged to be like that to ensure that package gets proper maintenance in future. In Package Review Process (http://fedoraproject.org/wiki/Package_Review_Process) there are defined roles, but it is not said that there can't be more than one maintainer. In fact in the CVS Admin request you can see even in the example that there could be more package maintainers from the very beginning. (http://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages) Manuel - please could you support your claim by some link to some procedure/guideline, which says it should be closed and new reopened? I have not found it codified anywhete. If it is just your gut feeling, please reconsider the position. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #14 from Jussi Lehtola jussi.leht...@iki.fi 2010-08-03 07:36:27 EDT --- Manuel is correct, that is normal practice. Even though it can be considered normal for a package to have *co*maintainers, there is always a *primary* maintainer who is considered responsible. If Nikolay is not any more willing to tend to this review, you (Michal) must open up a new review request and mark this one as its duplicate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added CC||mru...@matthias-runge.de --- Comment #15 from Matthias Runge mru...@matthias-runge.de 2010-08-03 07:42:25 EDT --- Michal, I think, it's great, if you volunteer and take over this package. Since I can not see, what information this page here provides you, which a new request can not provide. The bug reporter is the person maintaining the package. There is a way to take over a package, but only, if the package is approved. If I understand it correctly, co-maintainer get scm access (later on). What is the problem with the solution, Manuel suggested? I'm sure, someone (Martin, Manuel(?), or me) will review your package. Matthias -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Michal Ambroz re...@seznam.cz changed: What|Removed |Added CC||re...@seznam.cz --- Comment #11 from Michal Ambroz re...@seznam.cz 2010-08-02 19:41:45 EDT --- Hello, as there is long time no update from Nikolay I volunteer to finish those cosmetic changes and co-maintain the package. Here is updated package with cosmetic changes and manual page : http://rebus.fedorapeople.org/13/SPECS/nmbscan.spec http://rebus.fedorapeople.org/13/SRPMS/nmbscan-1.2.5-5.fc13.src.rpm Output from rpmlint: $ rpmlint nmbscan-1.2.5-5.fc13.src.rpm nmbscan-1.2.5-5.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #10 from Martin Gieseking martin.giesek...@uos.de 2010-07-11 06:50:16 EDT --- Nikolay, are you still interested in this package? If so, please address the small remaining issues so that we can finish the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566405
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review?
--- Comment #9 from Martin Gieseking martin.giesek...@uos.de 2010-05-12
15:56:57 EDT ---
Since nobody else seems to be interested in this package, I take the review. :)
Matthias already did a good job with his informal review, and there are just
two cosmetic things left I would address:
- Add a comment to the %build section telling that there's nothing to build.
- As suggested by the spell checker, capitalize Ethernet in the %description.
The other spelling errors can be ignored.
$ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm
nmbscan.noarch: W: spelling-error %description -l en_US hostname - host name,
host-name, hostage
nmbscan.noarch: W: spelling-error %description -l en_US ethernet - Ethernet,
ether net, ether-net
nmbscan.noarch: W: spelling-error %description -l en_US username - user name,
user-name, whatshername
nmbscan.src: W: spelling-error %description -l en_US hostname - host name,
host-name, hostage
nmbscan.src: W: spelling-error %description -l en_US ethernet - Ethernet,
ether net, ether-net
nmbscan.src: W: spelling-error %description -l en_US username - user name,
user-name, whatshername
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
-
keys used in following checklist:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- GPLv2 according to text in shell script
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum nmbscan-1.2.5.tar.gz*
7cbfd9c7ea817e67525006e78fb5d32e nmbscan-1.2.5.tar.gz
7cbfd9c7ea817e67525006e78fb5d32e nmbscan-1.2.5.tar.gz.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- shell script doesn't need to be built
- package builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2183527
[.] MUST: If the package does not successfully compile ...
[+] MUST: All build dependencies must be listed in BuildRequires.
- none required
[.] MUST: The spec file MUST handle locales properly.
- no locales
[.] MUST: Packages storing shared library files must call ldconfig in %post and
%postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix ...
[.] MUST: devel packages must require the base package
[+] MUST: Packages must NOT contain any .la libtool archives
[.] MUST: Packages containing GUI applications ...
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[+] SHOULD: The reviewer should test that the package builds in mock.
- builds in mock
[.] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
- noarch package
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg.
--
Configure
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566405
--- Comment #8 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-04-17
10:33:13 EDT ---
Hi Martin
Spec diff:
-Release:3%{?dist}
+Release:4%{?dist}
...
-License:GPLv2+
+License:GPLv2
...
-Source0:http://nmbscan.gbarbier.org/down/nmbscan-%{version}.tar.gz
+Source0:http://nmbscan.gbarbier.org/down/%{name}-%{version}.tar.gz
...
-%{_bindir}/nmbscan
+%{_bindir}/%{name}
...
%changelog
+* Sat Apr 17 2010 Nikolay Ulyanitsky lystor AT lystor.org.ua - 1.2.5-4
+- Fix the license and Source0
Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/nmbscan.spec
SRPM URL:
http://repo.lystor.org.ua/fedora/12/SRPMS/nmbscan-1.2.5-4.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566405
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #7 from Martin Gieseking martin.giesek...@uos.de 2010-04-09
13:04:40 EDT ---
Hi Nikolay,
according to the copyright notice included in the shell script, the license of
nmbscan is GPLv2, not GPLv2+ because the addition or (at your option) any
later version is missing.
I also suggest to use the macro %{name} in Source0 and %file:
Source0: http://nmbscan.gbarbier.org/down/%{name}-%{version}.tar.gz
%{_bindir}/%{name}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Alias||nmbscan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Matthias Runge mru...@fedoraproject.org changed: What|Removed |Added CC||mru...@fedoraproject.org --- Comment #4 from Matthias Runge mru...@fedoraproject.org 2010-03-19 16:52:21 EDT --- Since the nmbscan script relies on ping, you should add iputils to the requirements. arp is provided by package net-tools (missing in spec) nslookup is provided from bind-utils (missing in spec) I could do an inofficial review, since I'm not sponsored yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566405
--- Comment #5 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-03-19
17:28:58 EDT ---
Fixed
Spec diff:
@@ -1,6 +1,6 @@
Name: nmbscan
Version:1.2.5
-Release:2%{?dist}
+Release:3%{?dist}
Summary:NMB/SMB network scanner
Group: Applications/Internet
@@ -10,6 +10,9 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
+Requires: bind-utils
+Requires: iputils
+Requires: net-tools
Requires: samba-client
@@ -49,6 +52,9 @@
%changelog
+* Fri Mar 19 2010 Nikolay Ulyanitsky lystor AT lystor.org.ua - 1.2.5-3
+- Add Requires: bind-utils, iputils, net-tools
Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/nmbscan.spec
SRPM URL:
http://repo.lystor.org.ua/fedora/12/SRPMS/nmbscan-1.2.5-3.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #3 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-03-13 15:11:51 EST --- * Sat Mar 13 2010 Nikolay Ulyanitsky lystor AT lystor.org.ua - 1.2.5-2 - Fix the license - Fix the summary - Replace generally useful macros by regular commands Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/nmbscan.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/nmbscan-1.2.5-2.fc12.src.rpm The srpm builds successfully by the mock on Fedora 11, 12, 13 with i386/x86_64 architectures. The rpmlint output is clean. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net Blocks||563471(FE-SECSPIN) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #1 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-02-19 04:42:34 EST --- Builds successfully in mock on Fedora 11 with i386/x86_64 architectures. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 --- Comment #2 from Nikolay Ulyanitsky lys...@lystor.org.ua 2010-02-19 07:52:50 EST --- Builds successfully in mock on Fedora 13 with i386/x86_64 architectures. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566405 Nikolay Ulyanitsky lys...@lystor.org.ua changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
