[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Steve Grubb changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Comment #22 from Steve Grubb 2010-02-27 08:37:14 EST --- suricata-0.8.1-1.fc14 has been built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #21 from Jason Tibbitts 2010-02-26 18:50:00 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Steve Grubb changed: What|Removed |Added Flag||fedora-cvs? --- Comment #20 from Steve Grubb 2010-02-26 16:24:22 EST --- New Package CVS Request === Package Name: suricata Short Description: Intrusion Detection System Owners: sgrubb Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #19 from Jan F. Chadima 2010-02-26 03:16:19 EST --- aprooved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235(FE-Legal)| --- Comment #18 from Tom "spot" Callaway 2010-02-25 16:16:19 EST --- I'll lift FE-Legal on this, but please keep leaning on upstream to clarify the licensing properly on a per-file basis. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #17 from Matej Cepl 2010-02-22 10:25:21 EST --- Whoopsi, we need to wait on FE-Legal to be cleared. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima changed: What|Removed |Added Flag|fedora-review+ |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #16 from Jan F. Chadima 2010-02-22 09:50:23 EST --- aprooved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #15 from Steve Grubb 2010-02-22 08:59:20 EST --- In reply to comment #11, anyone contributing code to this project has to agree to a contributor agreement: http://www.openinfosecfoundation.org/index.php/contributors. The foundation has full control over all the source code and placed a GPL license in the distribution. So, I am sure its an oversight to not have documented each file being under the license they provided. The authors of the files are listed on the project page meaning they should have a contributor's agreement in place: http://www.openinfosecfoundation.org/index.php/team. Is this good enough or do we need to wait for a new release? As for comment #14, libhtp is only available as a cvs snapshot. There are no releases except through the suricata project. http://sourceforge.net/projects/libhtp/files. I don't like cvs snapshots as the only definitive source because its hard to verify if its different from other distributions. Not only that, you might take a snapshot on a day that a feature is only partially working. I'd rather take the embedded version since its the one the project is testing with. If libhtp ever starts making releases from sourceforge, then it might be a different story. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #14 from Jan F. Chadima 2010-02-22 07:32:07 EST --- The library libhtp is generic library which can be obtained from source forge as a separate project. It is not yet in fedora. There is a possibility to port it as a separate package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #13 from Jan F. Chadima 2010-02-22 07:27:26 EST --- CFLAGS="$CFLAGS " is same as CFLAGS+="" but is better legible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #12 from Jan F. Chadima 2010-02-22 07:23:52
EST ---
(In reply to comment #10)
> the problem with the debuginfo is the problem with %{_libdir}/* it includes
> the
> debuginfo into the regular package
solved
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #11 from Matej Cepl 2010-02-22 05:35:51 EST --- (In reply to comment #4) > As for Comment #2, I have been working with the project to get files correctly > stating the license since January. It really is GPLv2 from top to bottom. I > will continue pressing for this documentation to be corrected. They do have a > COPYING and LICENSE file, but I am only keeping the COPYING file in the %doc > section. Just to emphasize, that this doesn't have to be that big deal ... just ask upstream to add unequivocal statement somewhere (e.g., README) about their intentions and I think we are all set. Of course, one nice run of sed on src/ directory would be better. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #10 from Jan F. Chadima 2010-02-20 13:41:28
EST ---
the problem with the debuginfo is the problem with %{_libdir}/* it includes the
debuginfo into the regular package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #9 from Steve Grubb 2010-02-20 13:26:29 EST ---
New srpm is located here since name changed while adding %{?dist}:
http://people.redhat.com/sgrubb/files/suricata/suricata-0.8.1-1.fc12.src.rpm
Added libtool BR.
debuginfo as I understand it is something out of my control. Its rpm or build
system doing it.
The binary is now called out by name. The library will likely change versions,
so I am not calling it out by name. I have libhtp-* instead.
The init script is now working with the app. However, it looks like I need to
work with upstream on the config file and verbosity in daemon mode.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #7 from Jan F. Chadima 2010-02-20 12:54:21
EST ---
It's not recommended to have %{_bindir}/* or %{_libdir}/* in %files section,
better is to have all files pointed by name.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #8 from Jan F. Chadima 2010-02-20 12:55:28
EST ---
It's reconended to use %{?dist} in %release
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #6 from Jan F. Chadima 2010-02-20 12:48:46 EST --- rpmlint i386.rpm suricata.i686: W: spelling-error %description -l en_US Multi -> Mulch, Mufti suricata.i686: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip suricata.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/libhtp-0.2.so.1.0.2.debug suricata.i686: E: shared-lib-without-dependency-information /usr/lib/debug/usr/lib/libhtp-0.2.so.1.0.2.debug suricata.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/suricata.debug suricata.i686: E: statically-linked-binary /usr/lib/debug/usr/bin/suricata.debug suricata.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id suricata.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id suricata.i686: E: non-standard-dir-perm /var/log/suricata 0750L suricata.i686: E: non-readable /etc/sysconfig/suricata 0600L suricata.i686: E: non-readable /etc/suricata.yaml 0600L suricata.i686: E: non-standard-dir-perm /etc/suricata/rules 0750L suricata.i686: E: non-standard-dir-perm /etc/suricata 0750L It seems that /usr/lib/debug is in both the debugifo and the main package I understand the unstardard permissions, I'll disscuss it with fedora people. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #5 from Jan F. Chadima 2010-02-20 12:37:22 EST --- build the package suricata failed on rawhide/x86-64 autoreconf: running: /usr/bin/autoconf --force configure.ac:70: error: possibly undefined macro: AM_PROG_LIBTOOL If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1 build info on http://koji.fedoraproject.org/koji/taskinfo?taskID=2001609 maybe missing libtool in BuldRequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #4 from Steve Grubb 2010-02-20 11:22:29 EST --- Improved package uploaded. This is still a work in progress. Fixed BR in Comment 1. As for Comment #2, I have been working with the project to get files correctly stating the license since January. It really is GPLv2 from top to bottom. I will continue pressing for this documentation to be corrected. They do have a COPYING and LICENSE file, but I am only keeping the COPYING file in the %doc section. Regarding Comment #3, the spelling errors are actually false positives. You will also now get warnings and errors about directory/file permissions. Because this is an IDS system, I want tight permissions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #3 from Jan F. Chadima 2010-02-20 01:04:31 EST --- rpmlint of spec file is 100%ok 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint of src.rpm have 3 warnings suricata.src: W: name-repeated-in-summary C Suricata suricata.src: W: spelling-error %description -l en_US Multi -> Mulch, Mufti suricata.src: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip 1 packages and 0 specfiles checked; 0 errors, 3 warnings. 1) Its recomended to not use the name of the package in the summary 2) maybe s/Mufti/Multi/ 3) maybe s/Grip/ The binary packages not yet rpmlinted -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #2 from Jan F. Chadima 2010-02-19 17:55:58 EST --- Subdirectory libhtp/ seems to be correctly licensed as GPLv2 v exception for compatibility with any FLOSS license. However, code in subdirectory src/ has no comments about licensing and there doesn't seem to be any README explaining licensing. Even worse, some files have just files (e.g., src/suricata.c) have this /* Copyright (c) 2008 Victor Julien */ which is IMHO bad for Fedora. Please, consider the legal status of this package and whether there is some way how make this package acceptable without contacting the upstream, or whether it has to be fixed by the original author. Thank you -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima changed: What|Removed |Added Blocks||182235(FE-Legal) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #1 from Jan F. Chadima 2010-02-19 17:33:47 EST --- build the package suricata failed on rawhide/x86-64 from build log: + autoreconf -fv --install /var/tmp/rpm-tmp.mVSkMD: line 40: autoreconf: command not found error: Bad exit status from /var/tmp/rpm-tmp.mVSkMD (%prep) build info on http://koji.fedoraproject.org/koji/taskinfo?taskID=2000565 maybe missing autoconf in BuldRequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima changed: What|Removed |Added CC||jchad...@redhat.com AssignedTo|nob...@fedoraproject.org|jchad...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
