[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #19 from Fedora Update System 2010-04-13 21:33:17 EDT --- uzbl-0-0.9.20100221gitabbffe5c3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Fedora Update System changed: What|Removed |Added Fixed In Version||uzbl-0-0.9.20100221gitabbff ||e5c3.fc12 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #18 from Mamoru Tasaka 2010-03-26 10:28:52 EDT --- You can just leave F-11 branch as it is. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #17 from Daiki Ueno 2010-03-26 08:07:47 EDT --- Yes, I should have tested F-11 build before importing the package to CVS. Can I remove the F-11 branch (or is it OK to leave the CVS tree for now)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #16 from Mamoru Tasaka 2010-03-26 00:08:47 EDT --- Closing (maybe F-11 webkitgtk is too old for this package to compile) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #15 from Fedora Update System 2010-03-25 23:40:38 EDT --- uzbl-0-0.9.20100221gitabbffe5c3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/uzbl-0-0.9.20100221gitabbffe5c3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #14 from Fedora Update System 2010-03-25 23:39:04 EDT --- uzbl-0-0.9.20100221gitabbffe5c3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/uzbl-0-0.9.20100221gitabbffe5c3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Dennis Gilmore changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Dennis Gilmore 2010-03-25 16:59:14 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Daiki Ueno changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Daiki Ueno 2010-03-24 01:13:43 EDT --- New Package CVS Request === Package Name: uzbl Short Description: Lightweight WebKit browser following the UNIX philosophy Owners: ueno Branches: F-13 F-12 F-11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #11 from Daiki Ueno 2010-03-24 01:12:24 EDT --- Thanks. Done in -0.8: http://www.unixuser.org/~ueno/software/fedora/uzbl/uzbl-0-0.8.20100221gitabbffe5c3.src.rpm I'll do CVS admin request shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Mamoru Tasaka changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Mamoru Tasaka 2010-03-18 11:54:46 EDT --- Sorry, one more issue * %define -> %global - Now we prefer to use %global instead of %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Please fix this when importing this package into Fedora CVS. -- This package (uzbl) is APPROVED by mtasaka -- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #9 from Daiki Ueno 2010-03-18 06:34:44 EDT --- Ah, I misread the explanation on the Wiki :-) Just put -0.7: http://www.unixuser.org/~ueno/software/fedora/uzbl/uzbl-0-0.7.20100221gitabbffe5c3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567053
--- Comment #8 from Mamoru Tasaka 2010-03-17
03:02:32 EDT ---
For -0.6:
Almost okay.
* Directory ownership issue
- Your spec file contains:
---
66 %files
70 %{_datadir}/%{name}/
71 %{_datadir}/%{name}/*
---
Now build.log shows warnings like:
---
111 warning: File listed twice: /usr/share/uzbl/examples
112 warning: File listed twice: /usr/share/uzbl/examples/config
113 warning: File listed twice: /usr/share/uzbl/examples/config/config
114 warning: File listed twice: /usr/share/uzbl/examples/config/cookies
115 warning: File listed twice: /usr/share/uzbl/examples/data
---
Note that as
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
shows, "%{_datadir}/%{name}/" list in %files contains the directory
%{_datadir}/%{name} _and_ all directories/files/etc under this directory.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #7 from Daiki Ueno 2010-03-16 01:12:13 EDT --- Thanks. I've just uploaded -0.6 with fixes for them. http://www.unixuser.org/~ueno/software/fedora/uzbl/uzbl-0-0.6.20100221gitabbffe5c3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567053
--- Comment #6 from Mamoru Tasaka 2010-03-15
12:24:48 EDT ---
For -0.5:
Almost okay
* Timestamps
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
- When using "cp" or "install" commands, please also add "-p" option
to keep timestamps on installed files.
* Scriptlets for icon cache
- Please follow below:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
* Directory ownership issue
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
- Currently the following directories themselves are not owned
by any packages.
%{_datadir}/%{name}/
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Mamoru Tasaka changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #5 from Daiki Ueno 2010-03-13 05:39:42 EST --- Thanks for the review. The issues should be fixed in -0.5: http://www.unixuser.org/~ueno/software/fedora/uzbl/uzbl-0-0.5.20100221gitabbffe5c3.src.rpm On "examples" path, I ended up with keeping the default location as the upstream expects. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #4 from Mamoru Tasaka 2010-03-07 13:15:42 EST --- For 0.4: * build process - From build.log: - 36 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.yQ4cHw 43 + make -j8 54 cc -o uzbl-core callbacks.o events.o inspector.o uzbl-core.o -pthread -lwebkit-1.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0 -lX11 -pthread 56 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.axM2dB 69 + make DESTDIR=/builddir/build/BUILDROOT/uzbl-0-0.4.20100221gitabbffe5c3.i386 PREFIX=/usr install 76 cc -o uzbl-core callbacks.o events.o inspector.o uzbl-core.o -pthread -lwebkit-1.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0 -lX11 -pthread - So actually uzbl is compiled twice, once in %build and once in %install. It seems that Makefile does not check if the needed binaries are already rebuilt or not. So either - fix Makefile to prevent duplicate compilation - or just call "make" once (in %install, as binaries need to be installed anyway) * Desktop file - Installed desktop file contains: - 5 Exec=uzbl 6 Icon=uzbl - However none of these are installed. * "Example" files - Well, now I tried "uzbl-browser", and it complains: - $ env LANG=C uzbl-browser ; echo $? cp: cannot stat `/usr/share/uzbl/examples/config/config': No such file or directory Could not copy default config to /home/tasaka1/.config/uzbl/config 3 - I think the directory name "examples" is really confusing if this directory is actually needed on runtime, however it seems that this directory cannot be moved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Daiki Ueno changed: What|Removed |Added Flag|needinfo?(u...@unixuser.org | |) | --- Comment #3 from Daiki Ueno 2010-03-07 10:11:53 EST --- Thanks for the review. The issues should be fixed in -0.4: http://www.unixuser.org/~ueno/software/fedora/uzbl/uzbl-0-0.4.20100221gitabbffe5c3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(u...@unixuser.org ||) --- Comment #2 from Mamoru Tasaka 2010-03-04 10:17:02 EST --- Ueno-san, would you update this bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567053
--- Comment #1 from Mamoru Tasaka 2010-02-22
12:11:31 EST ---
Some notes:
* Epoch
- Please don't introduce Epoch
* Make build log more verbose
- Build log messages like:
-
38 + make -j4
39 COMPILING src/callbacks.c
40 COMPILING src/events.c
41 COMPILING src/inspector.c
42 COMPILING src/uzbl-core.c
43 ... done.
-
is not useful. We cannot check what is actually happening here,
especially we cannot check if Fedora specific compilation flags
are correctly honored or not:
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
Please build log more verbose so that we can check if compiler
flags are correctly honored.
! Note
As far as I checked this package, actually Fedora specific compilation
flags are currently not correctly honored, so this needs fixing.
* Build failure
- Your srpm does not build on F-13:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2005910
This is because F-13 changed the options to pass to linker:
http://lists.fedoraproject.org/pipermail/devel/2010-February/130519.html
https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
You can check this by passing "--no-added" option to linker
(for this package, you can do by doing $ make CC="gcc -Wl,--no-added")
* %makeinstall
- Please avoid using this unless impossible:
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
* Macros
- Please use rpmmacros. /usr should be %{_prefix}
https://fedoraproject.org/wiki/Packaging/RPMMacros
* Desktop files
- GUI application should install proper desktop files:
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
* Directories for document files
- Currently this package installs document files under:
- /usr/share/doc/uzbl-0
- /usr/share/uzbl/docs
- /usr/share/uzbl/examples
Please consider to unify these (especially "AUTHORS" or so are installed
both under the first two directories, so these should be fixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
