[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #14 from Mat Booth 2010-02-23 04:50:30 EST --- (In reply to comment #13) > Ah, sorry 'bout that. It's very confusing ... Heh, tell me about it. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #13 from Richard W.M. Jones 2010-02-23 04:46:06 EST --- Ah, sorry 'bout that. It's very confusing ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 Mat Booth changed: What|Removed |Added CC||fed...@matbooth.co.uk --- Comment #12 from Mat Booth 2010-02-23 04:41:04 EST --- Hi Richard, You've added the wrong Matthew Booth to the list of package owners. My FAS account name is mbooth, but I did not review this package. You wanted the *other* Matthew Booth's FAS account name... :-) I will relinquish co-maintainership of this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 Richard W.M. Jones changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE --- Comment #11 from Richard W.M. Jones 2010-02-23 04:13:11 EST --- Thanks Jason! I've only built this in Rawhide for the moment, because otherwise it will conflict with existing libguestfs in stable branches. When I upgrade libguestfs over time in those stable branches, I will build hivex there too. Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2008060 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #10 from Jason Tibbitts 2010-02-22 18:39:17 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 Richard W.M. Jones changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Richard W.M. Jones 2010-02-22 10:01:59 EST --- I made the change to the epoch ... New Package CVS Request === Package Name: hivex Short Description: Read and write Windows Registry binary hive files Owners: rjones mbooth Branches: F-12 F-13 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 Matthew Booth changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #8 from Matthew Booth 2010-02-22 09:55:24 EST --- Honesty in advertising: I didn't actually test a build with the above Conflicts line in place because there is no libguestfs build which would currently satisfy it. I also think there's a typo in there, because libguestfs has an Epoch. Should be 1:1.0.84. Assume this will be cleared up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #7 from Matthew Booth 2010-02-22 09:50:53 EST --- I agree LICENSE must be included in both packages. In fact, it should also be in the -debuginfo package, which includes the full source. No idea how you'd do that, though. That's a problem for another day. Added Conflicts line assumes that there will be no release of libguestfs after 1.0.84 which includes hivex. As you're also the libguestfs maintainer, I'll trust you that's true ;) ACK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #6 from Richard W.M. Jones 2010-02-22 09:33:12 EST --- Spec URL: http://www.annexia.org/tmp/hivex.spec SRPM URL: http://www.annexia.org/tmp/hivex-1.1.2-2.fc12.src.rpm The only change is: * Mon Feb 22 2010 Richard W.M. Jones - 1.1.2-2 - Add Conflicts libguestfs <= 1.0.84. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #5 from Richard W.M. Jones 2010-02-22 09:29:06 EST --- Thanks for reviewing this so quickly. Additional comments below: (In reply to comment #4) > * Both the base and devel pacakges list %doc LICENSE I'm going to leave this, as I believe that the current Fedora packaging guidelines are illegal. See my reasoning here: http://lists.fedoraproject.org/pipermail/packaging/2009-November/006654.html > Additionally: > > hivex as packaged here would conflict with libguestfs as currently included in > Fedora. This is a blocker until libguestfs is updated to remove hivex. > > hivex should include Conflicts: libguestfs < (version without hivex, when > released) Agreed. I will make a new package in a moment that contains: Conflicts: libguestfs <= 1.0.84 > libguestfs will presumably require hivex in any case, meaning a user can > upgrade seamlessly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #4 from Matthew Booth 2010-02-22 09:23:19 EST --- rpmlint has been run. Reported errors can be ignored. Package is named according to the package naming guidelines. spec file name matches the base package name Package meets the packaging guidelines Package has an approved license (LGPLv2) spec license matches actual license. LICENSE is included in %doc spec file is in English spec file is legible Sources in srpm match upstream Package builds on at least x86_64 and i686 spec file does not exclude any architectures. All BuildRequires are specified spec file uses %find_lang spec file calls ldconfig in %post and %postun Package does not bundle system libraries Package is not relocatable Package does not explicitly create any directories * Both the base and devel pacakges list %doc LICENSE Permissions are set properly spec file has a %clean section Package uses macros consistently Package doesn't contain any large documentation files %doc files do not affect runtime Header file is in -devel package Package doesn't include any static libraries devel package Requires pkgconfig devel package contains libhivex.so devel package requires exact base package version Package does not contain any libtool archives Package does not any GUI applications Pacakge does not own any files or directories of other packages %install runs rm -rf $RPM_BUILD_ROOT All filenames are valid UTF-8 Additionally: hivex as packaged here would conflict with libguestfs as currently included in Fedora. This is a blocker until libguestfs is updated to remove hivex. hivex should include Conflicts: libguestfs < (version without hivex, when released) libguestfs will presumably require hivex in any case, meaning a user can upgrade seamlessly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 Matthew Booth changed: What|Removed |Added CC||mbo...@redhat.com AssignedTo|nob...@fedoraproject.org|mbo...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #3 from Richard W.M. Jones 2010-02-22 07:01:42 EST --- rpmlint says: hivex.src: W: unexpanded-macro %description -l C %systemroot I think this is a bug in rpmlint (bug 567231). hivex.src: W: spelling-error %description -l en_US systemroot -> system root, system-root, systematic hivex.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure hivex.src: W: spelling-error %description -l en_US libguestfs -> guestrooms, guesthouse, guestroom hivex.src: W: spelling-error %description -l en_US guestfish -> guest fish, guest-fish, guesthouse hivex.src: W: spelling-error %description -l en_US virt -> dirt, girt, vi rt Not spelling mistakes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #2 from Richard W.M. Jones 2010-02-22 07:00:38 EST --- Koji scratch build for dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2004687 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567234] Review Request: hivex - Read and write Windows Registry binary hive files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567234 --- Comment #1 from Richard W.M. Jones 2010-02-22 07:00:22 EST --- Note that this package will conflict with libguestfs if you have that installed. This is because the code in this package is being separated out from the main libguestfs package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
