[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 Filipe Rosset changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 --- Comment #6 from Jason Tibbitts 2010-03-02 17:52:24 EST --- CVS done (by process-cvs-requests.py). Added F-13 branch as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 --- Comment #5 from Filipe Rosset 2010-03-02 08:31:04 EST --- New Package CVS Request === Package Name: python-empy Short Description: A powerful and robust template system for Python Owners: filiperosset Branches: F-11 F-12 EL-5 InitialCC: filiperosset -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 Filipe Rosset changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 Dan Horák changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 --- Comment #4 from Filipe Rosset 2010-03-01 22:34:36 EST --- Spec URL: http://filiperosset.fedorapeople.org/packages/python-empy/python-empy.spec SRPM URL: http://filiperosset.fedorapeople.org/packages/python-empy/python-empy-3.3-4.fc12.src.rpm Changes: License LGPLv3+ to LGPLv2+ I need send this package to CVS now, or after finish bakefile package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 Dan Horák changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Dan Horák 2010-02-28 06:50:05 EST --- All issues are fixed now, but looks like I did a mistake when checking the license. The correct value for the License tag is LGPLv2+ instead of LGPLv3+, because the license mentioned in source code and docs is "LGPL" and that means any version of LGPL, because no specific version is mentioned. Please fix this before uploading the spec file to CVS. The package is APPROVED. Please update now the bakefile package and after a successful finish I will sponsor you in the Fedora account system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 --- Comment #2 from Filipe Rosset 2010-02-27 11:46:40 EST --- Updated according #comment 1 (Dan Horák thanks for your formal review) Spec URL: http://filiperosset.fedorapeople.org/packages/python-empy/python-empy.spec SRPM URL: http://filiperosset.fedorapeople.org/packages/python-empy/python-empy-3.3-3.fc12.src.rpm Changes: - Remove python-devel in BuildRequires - Fix shebang on rpmlint -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 --- Comment #1 from Dan Horák 2010-02-25 05:30:01 EST --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: dfc82202231143b9aabc81bd735c6f8a559b5109 empy-latest.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv3+). License text included in package. OK latest version is being packaged. BAD BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - python-devel as BR: is usually not needed when building pure python modules without C code and the set of BRs should as small as possible (https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires) - rpmlint complains python-empy.noarch: E: wrong-script-interpreter /usr/lib/python2.6/site-packages/em.py /usr/local/bin/python python-empy.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/em.py 0644 /usr/local/bin/python => remove the whole shebang line for example with "sed -i -e '1d' em.py" in %prep section -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||549496 AssignedTo|nob...@fedoraproject.org|d...@danny.cz Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567713] Review Request: python-empy - A powerful and robust template system for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567713 Filipe Rosset changed: What|Removed |Added CC||d...@danny.cz Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
