[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 --- Comment #7 from Shreyank Gupta 2010-05-31 10:34:36 EDT --- *** This bug has been marked as a duplicate of bug 598138 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 Shreyank Gupta changed: What|Removed |Added CC||sgu...@redhat.com Resolution|NOTABUG |DUPLICATE --- Comment #6 from Shreyank Gupta 2010-05-31 10:32:05 EDT --- *** This bug has been marked as a duplicate of bug 588461 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 Mamoru Tasaka changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|needinfo?(adrian.jo...@fedo | |raproject.ro) | --- Comment #5 from Mamoru Tasaka 2010-05-21 12:52:21 EDT --- Once closing. If someone wants to import this package into Fedora, please submit a new review request and mark this bug as a duplicate of the new one, thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 --- Comment #4 from Mamoru Tasaka 2010-05-08 02:16:49 EDT --- I will close this bug if no response is received from the reporter within ONE WEEK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 --- Comment #3 from Mamoru Tasaka 2010-04-29 13:08:44 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(adrian.jo...@fedo ||raproject.ro) --- Comment #2 from Mamoru Tasaka 2010-04-16 13:12:38 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569198
Mamoru Tasaka changed:
What|Removed |Added
CC||mtas...@ioa.s.u-tokyo.ac.jp
--- Comment #1 from Mamoru Tasaka 2010-04-05
13:30:13 EDT ---
! Notes
- Please be familiar with rpmlint (available in "rpmlint" binary
rpm) and check your srpm / rebuilt binary rpm / installed rpm
with rpmlint.
Some initial comments
* spec file name
- The name of this spec file must be "rubygem-rmail.spec"
( see: $ rpmlint -I invalid-spec-name )
* %define -> %global
- We now prefer to use %global instead of %define:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
* Group
- We usually choose "Development/Languages" for rubygem related packages.
* License
- This package is under "BSD"
* Requires/BuildRequires fix
--
16 Requires: rubygems
17 BuildRequires: ruby(rubygems)
33 Requires:ruby(rubygems)
--
- You use both "rubygems" and "ruby(rubygems)" (Build)Requires. Please
choose one style ( note that "BuildRequires: rubygem(rake)" should
be as it is )
--
23 %package -n ruby-%{gemname}
27 Provides: ruby(%{gemname})= %{version}-%{release}
--
- With this line ruby-rmail has "Provides: ruby(rmail)=" and
"Provides: 1.0.0-1.fc??" and this is not expected.
( see: $ rpmlint -I comparison-operator-in-deptoken )
? non-gem compatibility package
- Would you explain why non-gem compatibility package is needed for this
package?
* Directory ownership issue
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory
- The following directories themselves are not owned by any packages:
---
%{geminstdir}
%{geminstdir}/lib
---
* script without executable permission including shebang
---
rubygem-rmail-doc.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/rmail-1.0.0/test/runtests.rb 0644L /usr/bin/env
rubygem-rmail-doc.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/rmail-1.0.0/test/testtestbase.rb 0644L /usr/bin/env
rubygem-rmail-doc.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/rmail-1.0.0/test/testmboxreader.rb 0644L
/usr/bin/env
rubygem-rmail-doc.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/rmail-1.0.0/test/testmessage.rb 0644L /usr/bin/env
...
...
---
- These scripts need not have shebangs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 Adrian Joian changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
