[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2010-03-22 22:15:07 EDT --- rawtherapee-3.0-0.11.a1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||rawtherapee-3.0-0.11.a1.fc1 ||2 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #31 from Fedora Update System upda...@fedoraproject.org 2010-03-22 22:20:24 EDT --- rawtherapee-3.0-0.11.a1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|rawtherapee-3.0-0.11.a1.fc1 |rawtherapee-3.0-0.11.a1.fc1 |2 |3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2010-03-20 10:50:10 EDT --- rawtherapee-3.0-0.11.a1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rawtherapee-3.0-0.11.a1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #25 from Thomas Spura toms...@fedoraproject.org 2010-03-19 06:31:22 EDT --- You might want fedora-cvs ? and not fedora-cvs + as currently set... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Thibault North thibault.no...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #26 from Thibault North thibault.no...@gmail.com 2010-03-19 08:47:34 EDT --- Fixed. Sorry for the typo... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #27 from Kevin Fenzi ke...@tummy.com 2010-03-19 15:50:33 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Thibault North thibault.no...@gmail.com changed: What|Removed |Added Flag||fedora-cvs+ --- Comment #22 from Thibault North thibault.no...@gmail.com 2010-03-18 15:06:53 EDT --- New Package CVS Request === Package Name: rawtherapee Short Description: RAW image processing software Owners: tnorth sdziallas hpejakle Branches: F-11 F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #23 from Sebastian Dziallas sebast...@when.com 2010-03-18 15:22:45 EDT --- I'm pretty sure you want sdz instead of sdziallas - the former one is me, whereas the latter one account doesn't exist... :) - thanks for adding me! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #24 from Thibault North thibault.no...@gmail.com 2010-03-18 15:32:03 EDT --- Yes sorry. I did a quick wiki search to get your FAS account and I believed it :-) Thanks for having spotted it quickly :) New Package CVS Request === Package Name: rawtherapee Short Description: RAW image processing software Owners: tnorth sdz hpejakle Branches: F-11 F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #14 from Thibault North thibault.no...@gmail.com 2010-03-17 13:59:13 EDT --- Ahem! Sorry for that. Will fix it ASAP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #15 from Thibault North thibault.no...@gmail.com 2010-03-17 14:58:47 EDT --- Ok. Actually removed these files, plus windows libs. (lib/*.a) Now calls ldconfig at %post and %postun. In the future, we will certainly drop these shared libs that aren't use by other programs. http://tnorth.ch/fedora/rawtherapee.spec http://tnorth.ch/fedora/rawtherapee-3.0-0.10.a1.fc12.src.rpm Source archive is now less than 900KiB. http://koji.fedoraproject.org/koji/taskinfo?taskID=2059589 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #18 from Sebastian Dziallas sebast...@when.com 2010-03-17 15:38:12 EDT --- Uh? Perhaps I'm wrong, but I can't see them anywhere, neither in the source rpm nor in the built one in 3.0-0.10.a1. Just to make sure I get you correctly, you're talking about the files in /release/languages and /release/themes, right? The languages folder seems to contain only the english-us locale and the themes folder is apparently empty. 3.0-0.9.a1 still had those in, but I thought Thibault had fixed this with the new update - am I missing anything? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #20 from Tom spot Callaway tcall...@redhat.com 2010-03-17 15:47:33 EDT --- No, this was my mistake, I accidentally installed the older SRPM. Lifting FE-Legal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Sebastian Dziallas sebast...@when.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #21 from Sebastian Dziallas sebast...@when.com 2010-03-17 16:03:27 EDT --- Alright, thanks! Since all other issues have been fixed, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #9 from Tom spot Callaway tcall...@redhat.com 2010-03-08 16:54:51 EST --- There look to be several licensing questions in here, please let me know if I missed any: 1. There is not clear licensing on the included translations and themes. If upstream cannot clarify the licensing of those files, they need to be removed. 2. Several files have unclear licensing: rawtherapee-3.0/rtengine/iccjpeg.c: Copied 99% intact from lcms (jpegicc/iccjpeg.c) rawtherapee-3.0/rtengine/jdatasrc.c: Modified copy from libjpeg ( rawtherapee-3.0/rtengine/dcraw.c: Exact copy from dcraw (dcraw/dcraw.c) rawtherapee-3.0/rtengine/iccjpeg.h: Copied 99% intact from lcms (jpegicc/iccjpeg.h) The files copied from lcms are MIT. (I'm not crazy about the file copying, but this code chunk isn't in the lcms library.) The file copied from dcraw is GPLv2+. There is no dcraw library, because upstream thinks it is better for people to either copy the dcraw code into their application or fork off dcraw processes. I can't wait for the first major dcraw exploit to come out. :P The file copied from libjpeg is IJG. The rawtherapee upstream went to some trouble to fork this code and obfuscate the function names so it could link to libjpeg without conflicting. I have no idea why, but I suspect this is a security exploit waiting to happen. If I were the maintainer here, I'd try to patch this to use the system libjpeg instead. * Leaving FE-Legal in place until the translations/theme licensing is either clarified or the files are clearly removed. Nevertheless, from a strict licensing perspective, these files are all acceptably licensed, if poorly marked. License tag on this package should be: License: GPLv3 and MIT and IJG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #7 from Sebastian Dziallas sebast...@when.com 2010-03-07 10:46:45 EST --- I'm having trouble finding the latest .spec file - could you upload that? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #8 from Thibault North thibault.no...@gmail.com 2010-03-07 11:02:11 EST --- Sure: http://tnorth.ch/fedora/rawtherapee.spec http://tnorth.ch/fedora/rawtherapee-3.0-0.8.a1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Thibault North thibault.no...@gmail.com changed: What|Removed |Added Flag|needinfo?(thibault.no...@gm | |ail.com)| --- Comment #6 from Thibault North thibault.no...@gmail.com 2010-03-05 16:27:33 EST --- I found a createicon.exe which we might need to remove from the source as well. Also, please check whether the requires tag on argyllcms and lcms is really needed to be listed. The vendor tag in desktop-file-install shouldn't be necessary. Fixed. * MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. -- NEEDSWORK Getting rid of the shared libraries seems to be the best think to do, according to Jan. * MUST: Each package must consistently use macros. -- NEEDSWORK *Should* be ok. Some people seem to be always macros when possible, some other not. What do you think ? 7] why binaries are renamed? Is there any conflict in filenames with any other existing package? If there is no conflict, it could create confusion for users of older version of this software (where my rtstart (or rt) command disappeared?) Fixed. Well, now calling rtstart actually starts it, but rt fails (requiring shared libs and paths). This should be fixed as soon as rawtherapee will properly find its own path. Updated koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2033824 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Sebastian Dziallas sebast...@when.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|sebast...@when.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569204
Sebastian Dziallas sebast...@when.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Blocks||182235(FE-Legal)
Flag||fedora-review?,
||needinfo?(thibault.no...@gm
||ail.com)
--- Comment #5 from Sebastian Dziallas sebast...@when.com 2010-03-04 16:10:38
EST ---
* MUST: rpmlint must be run on every package. The output should be posted in
the review. -- OK
[sebast...@localhost rawtherapee]$ rpmlint rawtherapee-3.0-0.7.a1.fc12.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[sebast...@localhost rawtherapee]$ rpmlint
rawtherapee-debuginfo-3.0-0.7.a1.fc12.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
* MUST: The package must be named according to the Package Naming Guidelines.
-- OK
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. -- OK
* MUST: The package must meet the Packaging Guidelines. -- NEEDSWORK
I found a createicon.exe which we might need to remove from the source as well.
Also, please check whether the requires tag on argyllcms and lcms is really
needed to be listed.
The vendor tag in desktop-file-install shouldn't be necessary.
* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines. -- OK
* MUST: The License field in the package spec file must match the actual
license. -- NEEDSWORK
The winclude directory contains all kinds of interesting licenses - I read that
we don't really need this directory for the application to work. Can we make
sure none of the files there get inherited into the final .rpm and if necessary
remove the lib and winclude folders?
Apparently, also these files have some interesting headers:
rawtherapee-3.0/rtengine/iccjpeg.c: *No copyright* UNKNOWN
rawtherapee-3.0/rtengine/jdatasrc.c: UNKNOWN
rawtherapee-3.0/rtengine/dcraw.c: UNKNOWN
rawtherapee-3.0/rtengine/iccjpeg.h: *No copyright* UNKNOWN
Blocking FE-LEGAL for now; Spot, can you clarify whether...?
* the lib and winclude directories need to be removed from the source bundle,
* these four files from above are alright,
* we need to act according to this:
http://code.google.com/p/rawtherapee/issues/detail?id=16
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. -- OK
* MUST: The spec file must be written in American English. -- OK
* MUST: The spec file for the package MUST be legible. -- OK
* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this. -- N/A
* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. -- OK
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. -- N/A
* MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. -- OK
* MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. -- OK
* MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. -- NEEDSWORK
I guess it'd be good to add this to %post %postun using the common
scriptlets.
* MUST: Packages must NOT bundle copies of system libraries. -- OK
* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. -- N/A
* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. -- OK
[Bug 569204] Review Request: rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org Summary|Review Request: Rawtherapee |Review Request: rawtherapee |- Raw image processing |- Raw image processing |software|software -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: Rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 --- Comment #4 from Thibault North thibault.no...@gmail.com 2010-03-01 03:21:50 EST --- Just to mention an updated build here, which includes fixes but *not* your suggestions yet. http://koji.fedoraproject.org/koji/taskinfo?taskID=2020086 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569204] Review Request: Rawtherapee - Raw image processing software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Jan Klepek jan.kle...@hp.com changed: What|Removed |Added CC||jan.kle...@hp.com --- Comment #2 from Jan Klepek jan.kle...@hp.com 2010-02-28 17:57:48 EST --- (feel free to add me as co-maintainer) how do you address following issues? 1] licensing issues [1] 2] there is no need for shared libraries, they are not intended to be used outside of rt afaik. 3] patches lacks comment if it was sent to upstream / or what is id in upstream bugtracker, those patches are not fedora specific. [3] 4] did you consider using patches from ( or as source for tarfile ) following repo which address (almost) all building issues? [2] 5] options file is configuration file it has to reside in /etc (otherwise it breaks FHS) [4] 6] could you please point to koji build for rt? I remember there was issue with debuginfo packages for rawtherapee. Are they created correctly now? 7] why binaries are renamed? Is there any conflict in filenames with any other existing package? If there is no conflict, it could create confusion for users of older version of this software (where my rtstart (or rt) command disappeared?) [1] http://code.google.com/p/rawtherapee/issues/detail?id=16 [2] http://repo.or.cz/w/rawtherapee-fixes.git [3] http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment [4] http://fedoraproject.org/wiki/Packaging/Guidelines#Filesystem_Layout -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
