[Bug 569492] Review Request: Ailurus - Install software + Configure Linux + Study Linux skills
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569492
Ankur Sinha sanjay.an...@gmail.com changed:
What|Removed |Added
CC||sanjay.an...@gmail.com
--- Comment #6 from Ankur Sinha sanjay.an...@gmail.com 2010-06-03 12:46:09
EDT ---
hey,
a quick look:
- use http://fedoraproject.org/wiki/Packaging/Python#Macros for the python
macros
- You don't need all the defines at the beginning. Please get rid of them? It's
just doing it twice :)
- no need for unmangled_version, it looks same as version
- prefix is not to be defined in a tag
- vendor tag is obsolete
have a look at
https://fedoraproject.org/wiki/A_Short_RPM_Tutorial#A_complete_hello.spec_file
for the tags to be used.
You should add comments rationalizing the Requires as per
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- use cflags so the build section would go:
%build
CFLAGS=$RPM_OPT_FLAGS %{__python} setup.py build
- similiarly the install section would go
%{__python} setup.py install --skip-build
Please go through the fedora packaging guidelines at the above mentioned links
and then maybe we can do a complete review.
regards,
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - Install software + Configure Linux + Study Linux skills
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 --- Comment #3 from Chen Lei supercy...@163.com 2010-04-24 11:22:54 EDT --- Please list files more explicit on %file instead of %files -f INSTALLED_FILES. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - Install software + Configure Linux + Study Linux skills
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 Chen Lei supercy...@163.com changed: What|Removed |Added CC||supercy...@163.com --- Comment #1 from Chen Lei supercy...@163.com 2010-03-18 04:54:46 EDT --- One comment: Using /usr/share/PolicyKit/policy/cn.ailurus.policy for F11 Using /usr/share/polkit-1/actions/cn.ailurus.policy for F12 and later -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - Install software + Configure Linux + Study Linux skills
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 Liang Suilong liangsuil...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
