[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 Liang Suilong liangsuil...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||CANTFIX --- Comment #14 from Liang Suilong liangsuil...@gmail.com 2010-07-28 08:59:44 EDT --- Homer Xing, the author of ailurus, decided to be more absorbed in developing ailurus. So he has given up this bug report. The package review should be closed. I will take over ailurus' request. So I will close this bug report and open a new one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 Chen Lei supercyp...@gmail.com changed: What|Removed |Added Resolution|CANTFIX |DUPLICATE --- Comment #15 from Chen Lei supercyp...@gmail.com 2010-07-28 09:20:14 EDT --- *** This bug has been marked as a duplicate of bug 619048 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569492
--- Comment #11 from Ankur Sinha sanjay.an...@gmail.com 2010-07-11 14:05:47
EDT ---
I just noticed that you need a sponsor, so I can't officially review this one,
sorry.
here's an **INFORMAL** review (since I promised). It'll make the package better
and easier for a sponsor to review. She/he will have to do it again though.
+ OK
- NA
? ISSUE
=
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[an...@localhost rpmbuild]$ md5sum ailurus-10.06.8.tar.gz
3eac90bab9fe03c53f5ce5ec067cc693 ailurus-10.06.8.tar.gz
[an...@localhost rpmbuild]$ md5sum SOURCES/ailurus-10.06.8.tar.gz
3eac90bab9fe03c53f5ce5ec067cc693 SOURCES/ailurus-10.06.8.tar.gz
- Package needs ExcludeArch
+ BuildRequires correct
? Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
? Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
+ Package is a GUI app and has a .desktop file
- Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
? Package doesn't own any directories other packages own.
? Package owns all the directories it creates.
? No rpmlint output.
SHOULD Items:
+ Should build in mock.
+ Should build on all supported archs
+ Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
Issues:
1. Please use %find_lang for locale files
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
2. I see a url.py with reference to repositories such as adobe and Rpmfusion.
What exactly is the purpose of these? If these are used to configure these 3rd
party repos, I'll have to confirm with legal if the package can be added into
fedora. (otherwise we would have already had a nifty tool to set up Rpmfusion
IMO)
Please contact fedora-legal and get this clarified.
3. The files section needs some cleaning up.
%{datadir}/icons - %{datadir}/icons/*
From:
http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25files_section
If you list a directory in the %files section, then you are claiming that
this package owns that subdirectory and all files and directories in it,
recursively (all the way down) if they are present in the build root
4. rpmlint output is downright UGLY :P
[an...@localhost SPECS]$ rpmlint ailurus.spec
../SRPMS/ailurus-10.06.8-0.fc13.src.rpm
/var/lib/mock/fedora-rawhide-i386/result/*.rpm
ailurus.src: W: summary-not-capitalized C makes Linux easier to use
ailurus.src: W: invalid-url URL: http://ailurus.googlecode.com/
IncompleteRead(0 bytes read)
ailurus.noarch: W: summary-not-capitalized C makes Linux easier to use
ailurus.noarch: W: incoherent-version-in-changelog 10.06.8-1 ['10.06.8-0.fc14',
'10.06.8-0']
ailurus.noarch: W: invalid-url URL: http://ailurus.googlecode.com/
IncompleteRead(0 bytes read)
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/info_pane.py 0644L /usr/bin/env
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/support/windowpos.py 0644L
/usr/bin/env
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/ubuntu/libserver.py 0644L /usr/bin/env
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/support/terminal.py 0644L /usr/bin/env
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/gnome/__init__.py 0644L /usr/bin/env
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/ubuntu/quick_setup.py 0644L
/usr/bin/env
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/loader.py 0644L /usr/bin/env
ailurus.noarch: W: non-conffile-in-etc /etc/dbus-1/system.d/cn.ailurus.conf
ailurus.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/ailurus/strings.py 0644L /usr/bin/env
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 --- Comment #12 from homerxing homer.x...@gmail.com 2010-07-11 21:45:34 EDT --- Dear Ankur, Thank you very much! I will correct the errors as soon as possible. Best regards, Homer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569492
--- Comment #13 from homerxing homer.x...@gmail.com 2010-07-11 23:49:03 EDT
---
I have fixed some issues.
1. Adopt %find_lang for locale files
2. The strings in url.py pointing to repositories such as adobe and Rpmfusion,
are obsolete. If someone do a grep, he will find that the strings are not used
in any other files in ailurus directory. Therefore I remove these strings. I
think ailurus is certainly legal.
3. Clean up the files section
%{datadir}/icons - %{_datadir}/icons/hicolor/*/apps/ailurus.png
4. rpmlint output has no errors now.
5. Change the summary. New summary is:
A simple software center and GNOME tweaker
However, currently rpmlint outputs a warning:
$ rpmlint ~/rpmbuild/RPMS/noarch/ailurus-10.06.93-0.fc13.noarch.rpm
ailurus.noarch: I: enchant-dictionary-not-found en_US
ailurus.noarch: W: invalid-url URL: http://ailurus.googlecode.com/
IncompleteRead(0 bytes read)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
I don't know the reason. :(
Would you please tell me why?
New spec:
http://github.com/homerxing/Ailurus/raw/master/ailurus.spec
New SRPM:
http://homerxing.fedorapeople.org/ailurus-10.06.93-0.fc13.src.rpm
Koji built sucessfully.
Best regards,
Homer
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 --- Comment #9 from Ankur Sinha sanjay.an...@gmail.com 2010-07-09 03:39:53 EDT --- hi, Sorry for the delay. Can you please provide a link to the srpm so I can do a complete review? Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 --- Comment #10 from homerxing homer.x...@gmail.com 2010-07-09 03:59:41 EDT --- Dear Ankur, Here is the srpm http://homerxing.fedorapeople.org/ailurus-10.06.8-0.fc13.src.rpm Hope a complete review will begin. :) Best regards, Homer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - make Linux easier to use for newcomers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 homerxing homer.x...@gmail.com changed: What|Removed |Added Summary|Review Request: Ailurus - |Review Request: Ailurus - |Install software +|make Linux easier to use |Configure Linux + Study |for newcomers |Linux skills | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
