[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 Michael Monreal michael.monreal+b...@gmail.com changed: What|Removed |Added CC||michael.monreal+b...@gmail. ||com --- Comment #7 from Michael Monreal michael.monreal+b...@gmail.com 2010-03-08 03:43:46 EST --- Would be great to see this in F13 as gnome-scan does not really work for me and is basicly unmaintained¹ now... [1] https://bugs.launchpad.net/simple-scan/+bug/483669/comments/1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #8 from Matthias Clasen mcla...@redhat.com 2010-03-08 13:27:45 EST --- Looks good now. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Rahul Sundaram methe...@gmail.com 2010-03-08 13:38:09 EST --- New Package CVS Request === Package Name: simple-scan Short Description: Simple scanning utility Owners: sundaram Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 --- Comment #10 from Kevin Fenzi ke...@tummy.com 2010-03-09 01:19:40 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 Rahul Sundaram methe...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added CC||mcla...@redhat.com AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com --- Comment #1 from Matthias Clasen mcla...@redhat.com 2010-03-07 18:33:41 EST --- Builds in mock, rpmlint output: simple-scan.src: W: strange-permission simple-scan-0.9.5.tar.gz 0600L simple-scan.src: W: no-cleaning-of-buildroot %install simple-scan.src: W: no-buildroot-tag simple-scan.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/simple-scan.schemas 3 packages and 0 specfiles checked; 0 errors, 4 warnings. The permission issue, you should probably fix when committing this to cvs, the rest are ignorable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 --- Comment #2 from Matthias Clasen mcla...@redhat.com 2010-03-07 18:43:40 EST --- As an aside, I notice the following in the docs: PNG files are not compressed like JPEG so they contain the raw data from the scanner. This makes them much larger and not suitable for distributing. If you have scanned multiple pages then a PNG file will be written for each page. This seems confusing at best. The important difference between PNG and JPEG is not compressed vs uncompressed, but lossless vs lossy compression. Of course, it _could_ be that the application decides to save PNG uncompressed, but that would just be a very bad choice... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 --- Comment #3 from Matthias Clasen mcla...@redhat.com 2010-03-07 18:51:12 EST --- I don't have a scanner to test this with here at home, but at least the application detects this and handles it nicely. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 --- Comment #4 from Matthias Clasen mcla...@redhat.com 2010-03-07 19:13:47 EST --- checklist: package name: ok spec file name: ok packaging guidelines: you need to add the usual gconf schema scriptlets, and the patch should have an upstream bug ref or something like that license: ok license field: ok license file: ok spec file language: ok spec file legible: ok upstream sources: ok buildable: ok ExcludeArch: ok, none BuildRequires: the GConf2 BR is redundant, GConf2-devel will pull it in. Might be nice to group the autofoo + gnome-common requires with the patch that makes them necessary, and also add a comment to the autogen call that ties it to the patch locale handling: ok shared libs: ok, none system libs: ok relocatable: ok directory ownership: might want to require yelp, for /usr/share/gnome/help (and to make help work) duplicate files: ok file permissions: ok %clean: ok macro use: ok permissible content: yes large docs: ok %doc content: ok headers: ok, none static libs: ok, none pc files: ok, none shared libs: ok devel package: ok libtool archives: ok gui apps: ok duplicate ownership: ok %install: outdated checklist item utf8 filenames: ok trivia: some trailing whitespace in the spec... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 --- Comment #6 from Rahul Sundaram methe...@gmail.com 2010-03-08 01:47:28 EST --- Updated spec as per review http://sundaram.fedorapeople.org/packages/simple-scan.spec http://sundaram.fedorapeople.org/packages/simple-scan-0.9.5-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570876] Review Request: simple-scan - Simple scanning utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570876 --- Comment #5 from Rahul Sundaram methe...@gmail.com 2010-03-08 01:46:28 EST --- (In reply to comment #2) As an aside, I notice the following in the docs: PNG files are not compressed like JPEG Filed a bug report at https://bugs.launchpad.net/simple-scan/+bug/534207 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
