[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #9 from Hans de Goede 2010-11-04 18:12:15 EDT --- Hmm, it seems the .src.rpm is 404 too. Please fix that, I need to src.rpm to complete the review. In the mean time I've done most of the review based on the .spec file: Good: - rpmlint checks return: libmtag.src: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.src: W: spelling-error %description -l en_US backend -> backed, backbend, back end libmtag.src: W: invalid-url Source0: http://libmtag.googlecode.com/files/libmtag-0.3.5.tar.gz HTTP Error 404: Not Found libmtag.x86_64: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.x86_64: W: spelling-error %description -l en_US backend -> backed, backbend, back end libmtag-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 6 warnings. All of these rpmlint warnings are bogus, so this is fine. - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Needs work: - source matches upstream I could not verify this because of the lack of a .src.rpm - summary Please drop the An from the summary, as a general rule we try to not have Summaries start with A, An or The. - %doc (main package) Please add README and NEWS to the main package %doc, they seem useful to have around to me. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Hans de Goede changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com --- Comment #8 from Hans de Goede 2010-11-04 17:58:46 EDT --- Hi, (In reply to comment #7) > > I have python bindings, not really a python app. > python bindings would make a fine second package submission to show some more of your packaging skills. I'll go and review this package now, but, once reviewed, I would still like to see something more of your packaging skills before sponsoring you. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #7 from Felipe Contreras 2010-11-04 17:02:33 EDT --- (In reply to comment #6) > Well it seems you're previous submission ended up in a communications break > down / personality clash. I do not want to get into whose fault that is (I > don't care), but that does make you're case somewhat special. And I must admit > that unfortunately we do not have enough people doing reviews, esp. not > reviews > of people who need a sponsor. > > If you're still interested in becoming a Fedora package maintainer I'm willing > to help you through the process. > > Step 1 would be for me to review this package, which as you indicate should be > a formality. Then I would somehow like to see some more of your packaging > skills for example by packaging up a python application using this lib, see > here for specific guidelines for python packaging: > http://fedoraproject.org/wiki/Packaging:Python I have python bindings, not really a python app. > If that sounds like a good way forward to you let me know, and I'll start by > reviewing this package submission. Ok, I'll put that in my to-do list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #6 from Hans de Goede 2010-11-04 11:06:17 EDT --- (In reply to comment #5) > (In reply to comment #3) > > http://people.freedesktop.org/~felipec/fedora/libmtag.spec > > > > Gives a 404 error... > > Fixed. > Thanks. > > Also may I ask why you are packaging libmtag? As it is a library mostly, I > > assume > > you're packaging it for use in something else? I'm asking because for > > sponsering I always find it good when a submitter submits multiple packages > > in > > one go, this gives me a better chance to get a feeling for how well you know > > the packaging guidelines. > > The library is good in itself. The reason I'm packaging it is so I and other > people don't have to manually compile it every time. Ok. > I know the packaging guidelines for C libraries, but I have never tried python > or ruby packaging which is how most people are using this library. That's why > I > decided to start with the library first. Ok. > To be honest, the process to submit packages was painful and demotivational, > and after one year and addressing every comment, there's no light on the end > of > the tunnel. Well it seems you're previous submission ended up in a communications break down / personality clash. I do not want to get into whose fault that is (I don't care), but that does make you're case somewhat special. And I must admit that unfortunately we do not have enough people doing reviews, esp. not reviews of people who need a sponsor. If you're still interested in becoming a Fedora package maintainer I'm willing to help you through the process. Step 1 would be for me to review this package, which as you indicate should be a formality. Then I would somehow like to see some more of your packaging skills for example by packaging up a python application using this lib, see here for specific guidelines for python packaging: http://fedoraproject.org/wiki/Packaging:Python If that sounds like a good way forward to you let me know, and I'll start by reviewing this package submission. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Felipe Contreras changed: What|Removed |Added Flag|needinfo?(felipe.contreras@ | |gmail.com) | --- Comment #5 from Felipe Contreras 2010-11-04 07:16:49 EDT --- (In reply to comment #3) > http://people.freedesktop.org/~felipec/fedora/libmtag.spec > > Gives a 404 error... Fixed. > Also may I ask why you are packaging libmtag? As it is a library mostly, I > assume > you're packaging it for use in something else? I'm asking because for > sponsering I always find it good when a submitter submits multiple packages in > one go, this gives me a better chance to get a feeling for how well you know > the packaging guidelines. The library is good in itself. The reason I'm packaging it is so I and other people don't have to manually compile it every time. I know the packaging guidelines for C libraries, but I have never tried python or ruby packaging which is how most people are using this library. That's why I decided to start with the library first. To be honest, the process to submit packages was painful and demotivational, and after one year and addressing every comment, there's no light on the end of the tunnel. I guess I'll better give up, write compelling UI applications that use this library, and leave to other people to push for this library, when presumably you guys would bend over due to public demand. FTR. This package follows the guidelines already. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #4 from Bug Zapper 2010-11-03 16:39:59 EDT --- This message is a reminder that Fedora 12 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 12. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '12'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 12's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 12 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Hans de Goede changed: What|Removed |Added CC||hdego...@redhat.com --- Comment #3 from Hans de Goede 2010-11-03 08:38:15 EDT --- Hi Felipe, http://people.freedesktop.org/~felipec/fedora/libmtag.spec Gives a 404 error... Also may I ask why you are packaging libmtag? As it is a library mostly, I assume you're packaging it for use in something else? I'm asking because for sponsering I always find it good when a submitter submits multiple packages in one go, this gives me a better chance to get a feeling for how well you know the packaging guidelines. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Jason Tibbitts changed: What|Removed |Added Version|12 |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #2 from Felipe Contreras 2010-08-09 15:19:17 EDT --- This package has all the issues fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #1 from Felipe Contreras 2010-06-04 17:57:31 EDT --- Hello? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Felipe Contreras changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
