[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2012-05-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

Jason Tibbitts  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC|fedora-package-review@redha |package-review@lists.fedora
   |t.com   |project.org
 Resolution||NOTABUG
   Flag|fedora-review?  |
Last Closed||2012-05-09 14:57:44

--- Comment #7 from Jason Tibbitts  2012-05-09 14:57:44 EDT 
---
This has been sitting so long with no progress that I'm just going to close it
out.  Since I've already done the review I should be able to finish it up
pretty quickly if Dave wants to reopen.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2012-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

Adrien Kunysz  changed:

   What|Removed |Added

 CC||a...@acunu.com

--- Comment #6 from Adrien Kunysz  2012-01-09 08:05:54 EST ---
It seems that spec file cannot be processed properly when python26 is not
installed:

$ rpmbuild -bp SPECS/python26-psycopg2.spec  
sh: /usr/bin/python2.6: No such file or directory
error: Macro %pyver has empty body
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
error: Failed build dependencies:
python26-devel is needed by python26-psycopg2-2.0.14-2.x86_64
postgresql-devel is needed by python26-psycopg2-2.0.14-2.x86_64

The "error: Failed build dependencies" is expected but as far as I can tell,
the
 "sh: /usr/bin/python2.6: No such file or directory" and "error: Macro %pyver
has empty body" should not happen.

Otherwise it seems to work fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2011-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

GaViT  changed:

   What|Removed |Added

 CC||g.v.tjongah...@gmail.com

--- Comment #5 from GaViT  2011-06-06 11:22:19 EDT ---
I have been able to download the SRPM from Dave Malcolm. I have edited the
SPECFILE to work with postgresql84-server, and have successfully built the RPM.
It seems to have installed well.
I wonder why this hasn't been added to the repos if it "works" so "easily".
For now I think this "solves" my problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2011-01-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

--- Comment #4 from Jason Tibbitts  2011-01-19 20:14:17 EST 
---
Any update here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2010-12-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

Jason Tibbitts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu
   Flag||fedora-review?

--- Comment #3 from Jason Tibbitts  2010-12-03 13:33:41 EST 
---
I don't really do anything relating to EPEL, but this has been sitting around
for so long and my attempts to get someone to look at it have failed, so I'll
take care of it as best I can.

Builds fine in a CentOS5 mock buildroot (no RHEL5 for me; hopefully it doesn't
matter).  rpmlint says:
  python26-psycopg2.x86_64: W: private-shared-object-provides
   /usr/lib64/python2.6/site-packages/psycopg2/_psycopg.so _psycopg.so()(64bit)
which were this Fedora I'd say needs to be filtered.  However, the filtering
infrastructure doesn't appear to be present in RHEL5

The %pyver macro seems to be defined, but not used.

In Fedora, uses of %define should generally be changed to %global.  (I checked
a couple of other python26 reviews and some use %global while yours seem to use
%define.  I'm not sure if there's a reason for that.)

You're right, the license tag on the python-psycopg2 package is definitely
wrong.  In F13 it's "GPLv2+ with exceptions" which doesn't appear to be
correct, and in rawhide it's just "LGPLv3" which is also incorrect.  I just
went ahead and fixed it.

I am assuming that you are sticking with 2.0.14 instead of updating to the
latest version for reasons relating to the age of RHEL5.  If you wish to
package the current instead, just push another package and I'll take a look.

* source files match upstream.  sha256sum:
   902607cdbe1195a00694d2b477eed8429eda433caaa0eb6ff7f80883e1c17ac7
psycopg2-2.0.14.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (x86_64, EL5).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints (for EL5, at least).
* final provides and requires are sane:
  python26-psycopg2-2.0.14-2.el5.x86_64.rpm
   _psycopg.so()(64bit)  
   python26-psycopg2 = 2.0.14-2.el5
  =
   libpq.so.4()(64bit)  
   libpython2.6.so.1.0()(64bit)  

  python26-psycopg2-doc-2.0.14-2.el5.x86_64.rpm
   python26-psycopg2-doc = 2.0.14-2.el5
  =
   python26-psycopg2 = 2.0.14-2.el5

* no bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2010-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

Felix Schwarz  changed:

   What|Removed |Added

 CC||felix.schw...@oss.schwarz.e
   ||u

Bug 574586 depends on bug 573151, which changed state.

Bug 573151 Summary: Review Request: python26 - Parallel-installable Python 2.6 
for EPEL5
https://bugzilla.redhat.com/show_bug.cgi?id=573151

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Status|ASSIGNED|ON_QA
 Resolution||ERRATA
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2010-03-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

Devrim GÜNDÜZ  changed:

   What|Removed |Added

 CC||dev...@gunduz.org

--- Comment #2 from Devrim GÜNDÜZ  2010-03-18 03:54:43 EDT 
---
No problem for me. Please let me know if you need help.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 574586] Review Request: python26-psycopg2 : psycopg2 Postgres client code for python26 on EPEL5

2010-03-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574586

Dave Malcolm  changed:

   What|Removed |Added

 CC||dev...@commandprompt.com
 Depends on||573151(Python26EPEL5)

--- Comment #1 from Dave Malcolm  2010-03-17 17:44:09 EDT 
---
CCing Devrim GUNDUZ, maintainer of python-psycopg2

Devrim: I'm working on a python2.6 stack for EPEL5, parallel-installable with
the main 2.4 stack, and one package I want to maintain is a 2.6 build of
psycopg2.  I hope the above looks sane to you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review