[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Fedora Update System changed: What|Removed |Added Fixed In Version||python-meliae-0.2.0-3.fc13 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #14 from Fedora Update System 2010-10-14 02:31:08 EDT --- python-meliae-0.2.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Dave Malcolm changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #13 from Dave Malcolm 2010-04-22 13:18:59 EDT --- Thanks. Imported and built into F-12, F-13 and devel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #12 from Fedora Update System 2010-04-22 11:50:25 EDT --- python-meliae-0.2.0-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-meliae-0.2.0-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #11 from Fedora Update System 2010-04-22 11:49:32 EDT --- python-meliae-0.2.0-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-meliae-0.2.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #10 from Kevin Fenzi 2010-04-21 00:02:51 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #9 from Dave Malcolm 2010-04-19 15:10:47 EDT --- (In reply to comment #7) Typo; meant to type "F-12 F-13" for branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Dave Malcolm changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Dave Malcolm 2010-04-19 15:09:42 EDT --- New Package CVS Request === Package Name: python-meliae Short Description: Python memory usage statistics Owners: dmalcolm Branches: F-13 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #8 from Dave Malcolm 2010-04-19 15:10:06 EDT --- New Package CVS Request === Package Name: python-meliae Short Description: Python memory usage statistics Owners: dmalcolm Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=577398
Thomas Spura changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||toms...@fedoraproject.org
Flag||fedora-review+
--- Comment #6 from Thomas Spura 2010-04-16
14:36:43 EDT ---
Review:
Good:
- sources match upstream: 21846ab82299ae1e30d3123a92a05ac0
- name ok
- %build/%install ok
- %clean there
- license ok - it's GPLv3 and *NOT* GPLv3+
- Group ok
- arch ok
- koji ok:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2121545
Needswork:
- Could you be a bit more verbose in %files, to detect, if the egg was
correctly build?
e.g.
%{python_sitearch}/meliae
%{python_sitearch}/meliae-*-py?.?.egg-info
- %check missing:
%check
./run_tests.py
doesn't work here, but python setup.py build --inplace doesn't either, don't
know why.
python setup.py build_ext --inplace worked. Could this be a distutils/cython
bug?
- Great patch comment. Is it upstream? No comment about that.
(In reply to comment #5)
> Thanks for the quick response. Changing Py_ssize_t to ssize_t did remove a
> number of errors, but now I'm blocked on errors related to Sets. I'm thinking
> that at this point it's probably not worth trying to backport to Python 2.4.
>
See TODO.txt:
'''
8) Full cross-platform and version compatibility.
I'd like to support python2.4+, 32/64-bit, Win/Linux/Mac. I've tested
a couple variants, but I don't have all of them to make sure it works
everywhere.
'''
Maybe it will be supported in the future.
###
Only shoulds/coulds left (see Needswork).
###
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Thomas Spura changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Dave Malcolm changed: What|Removed |Added Flag|needinfo?(dmalc...@redhat.c | |om) | --- Comment #4 from Dave Malcolm 2010-03-29 12:43:46 EDT --- It builds OK on Fedora 12 with Cython-0.12.1-4.fc12.x86_64 The three errors appear to all relate to "Py_ssize_t", which doesn't exist yet in the Python 2.4 in RHEL5. It's probably fixable by patching away those references in EL5 builds to ssize_t. The relevant info from 2.6's Include/pyport.h: /* Py_ssize_t is a signed integral type such that sizeof(Py_ssize_t) == * sizeof(size_t). C99 doesn't define such a thing directly (size_t is an * unsigned integral type). See PEP 353 for details. */ #ifdef HAVE_SSIZE_T typedef ssize_t Py_ssize_t; #elif SIZEOF_VOID_P == SIZEOF_SIZE_T typedef Py_intptr_t Py_ssize_t; #else # error "Python needs a typedef for Py_ssize_t in pyport.h." #endif -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #5 from Dennis Gregorovic 2010-03-29 13:14:37 EDT --- Thanks for the quick response. Changing Py_ssize_t to ssize_t did remove a number of errors, but now I'm blocked on errors related to Sets. I'm thinking that at this point it's probably not worth trying to backport to Python 2.4. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Dennis Gregorovic changed: What|Removed |Added Flag||needinfo?(dmalc...@redhat.c ||om) --- Comment #3 from Dennis Gregorovic 2010-03-29 12:21:13 EDT --- Does this require a particular version of Python and/or Cython? $ rpm -q python-devel Cython python-devel-2.4.3-27.el5.x86_64 Cython-0.12.1-4.el5.x86_64 $ rpmbuild --rebuild python-meliae-0.2.0-2.fc12.src.rpm [snip] creating build/temp.linux-x86_64-2.4/meliae gcc -pthread -fno-strict-aliasing -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I/usr/include/python2.4 -c meliae/_scanner.c -o build/temp.linux-x86_64-2.4/meliae/_scanner.o meliae/_scanner.c: In function '__pyx_f_6meliae_8_scanner__file_io_callback': meliae/_scanner.c:489: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result meliae/_scanner.c: In function '__pyx_pf_6meliae_8_scanner_dump_object_info': meliae/_scanner.c:681: warning: passing argument 1 of '_dump_object_info' from incompatible pointer type meliae/_scanner.c:693: warning: passing argument 1 of '_dump_object_info' from incompatible pointer type gcc -pthread -fno-strict-aliasing -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I/usr/include/python2.4 -c meliae/_scanner_core.c -o build/temp.linux-x86_64-2.4/meliae/_scanner_core.o In file included from meliae/_scanner_core.c:20: meliae/_scanner_core.h:35: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_size_of' meliae/_scanner_core.c:77: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_basic_object_size' meliae/_scanner_core.c:89: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_var_object_size' ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 Dave Malcolm changed: What|Removed |Added CC||dgre...@redhat.com --- Comment #2 from Dave Malcolm 2010-03-26 18:59:53 EDT --- FWIW, some more information (including usage) can be seen at: http://jam-bazaar.blogspot.com/2009/11/memory-debugging-with-meliae.html http://jam-bazaar.blogspot.com/2010/01/meliae-020.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577398] Review Request: python-meliae - Python memory usage statistics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577398 --- Comment #1 from Dave Malcolm 2010-03-26 17:32:58 EDT --- Updated spec: http://dmalcolm.fedorapeople.org/python-packaging/python-meliae.spec Updated SRPM: http://dmalcolm.fedorapeople.org/python-packaging/python-meliae-0.2.0-2.fc12.src.rpm (I added a patch which fixes an assertion failure) rpmlint output is clean: $ rpmlint RPMS/x86_64/python-meliae-*-2* SRPMS/python-meliae-0.2.0-2.fc12.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
