[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-geoclue-0.1.0-1.fc12 |python-geoclue-0.1.0-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||python-geoclue-0.1.0-1.fc12 Resolution|RAWHIDE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-04-12 21:38:03 EDT --- python-geoclue-0.1.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-04-12 21:37:52 EDT --- python-geoclue-0.1.0-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-04-12 22:00:52 EDT --- python-geoclue-0.1.0-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-geoclue-0.1.0-1.fc11 |python-geoclue-0.1.0-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #8 from Peter Robinson pbrobin...@gmail.com 2010-03-31 15:10:38 EDT --- In rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #9 from Thomas Spura toms...@fedoraproject.org 2010-04-01 00:20:57 EDT --- (In reply to comment #2) I believe these are all fixed now. Yepp, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-03-30 18:23:31 EDT --- python-geoclue-0.1.0-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-geoclue-0.1.0-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-03-30 18:23:35 EDT --- python-geoclue-0.1.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-geoclue-0.1.0-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-03-30 18:23:39 EDT --- python-geoclue-0.1.0-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-geoclue-0.1.0-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=577932
Thomas Spura toms...@fedoraproject.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||toms...@fedoraproject.org
AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org
Flag||fedora-review+
--- Comment #1 from Thomas Spura toms...@fedoraproject.org 2010-03-29
16:38:05 EDT ---
Review:
Good:
- rpmlint
$ rpmlint ./python-geoclue-0.1.0-1.fc13.src.rpm
noarch/python-geoclue-0.1.0-1.fc13.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- group ok
- name ok
(I believe you should directly provide python2-geoclue, because this is likly
to happen in the future.)
- BuildRoot ok
If you don't want to build in RHEL, could you delete that?
- %prep ok
- %build ok
- %install ok
- no libs
- no *.la
- buildarch: noarch ok
Needswork:
- %files
* you should change 0.1.0 to %{version}, this way you don't need to change
this all the time.
* how about %doc docs/* ?
- license wrong: GPLv3 - GPLv3+
- BR wrong:
* What is pygobject2-devel for?
Please BR pygobjec2 instead (only the python files are needed, not the
whole -devel package).
* Instead you need to also Require pygobject2 for python importing on runtime
All needswork are easyfixes, ping me if you object to something.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=577932
--- Comment #2 from Peter Robinson pbrobin...@gmail.com 2010-03-29 16:55:40
EDT ---
Thanks!
Needswork:
- %files
* you should change 0.1.0 to %{version}, this way you don't need to change
this all the time.
* how about %doc docs/* ?
- license wrong: GPLv3 - GPLv3+
- BR wrong:
* What is pygobject2-devel for?
Please BR pygobjec2 instead (only the python files are needed, not the
whole -devel package).
* Instead you need to also Require pygobject2 for python importing on
runtime
I believe these are all fixed now.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577932] Review Request: python-geoclue - A Geoclue python module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577932 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Peter Robinson pbrobin...@gmail.com 2010-03-29 16:57:07 EDT --- New Package CVS Request === Package Name: python-geoclue Short Description: A Geoclue python module Owners: pbrobinson Branches: F-13 F-12 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
