[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #22 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-06-28 13:15:08 EDT --- Thanks for you comments. Should be fixed/changed in this version: http://fedora.lowlatency.de/review/mingw-wine-gecko.spec http://fedora.lowlatency.de/review/mingw-wine-gecko-1.2.0-3.fc16.src.rpm http://fedora.lowlatency.de/review/mingw32-wine-gecko-1.2.0-3.fc16.noarch.rpm http://fedora.lowlatency.de/review/mingw64-wine-gecko-1.2.0-3.fc16.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #20 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-06-21 14:16:26 EDT --- All new fun build on f16 with cross enabled. Please test and leave feedback. Once all pieces of cross/mingw64 are in rawhide I hope someone will review: http://fedora.lowlatency.de/review/mingw-wine-gecko.spec http://fedora.lowlatency.de/review/mingw-wine-gecko-1.2.0-2.fc16.src.rpm http://fedora.lowlatency.de/review/mingw32-wine-gecko-1.2.0-2.fc16.noarch.rpm http://fedora.lowlatency.de/review/mingw64-wine-gecko-1.2.0-2.fc16.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=577951
--- Comment #21 from Erik van Pienbroek erik-fed...@vanpienbroek.nl
2011-06-21 14:37:28 EDT ---
Very nice to see that you based this package on the new MinGW packaging
guidelines (https://fedoraproject.org/wiki/Packaging:MinGW_Future) !
Some small comments:
Please start the .spec file with these set of lines:
%global __strip %{mingw_strip}
%global __objdump %{mingw_objdump}
%define __debug_install_post %{mingw_debug_install_post}
And add a line with %{?mingw_debug_package} right before the start of the first
%package tag. This is needed to automatically extract debug information
I noticed you used the %{description} tag in some places. Last time I tried,
this didn't give the expected results, so you may need to manually add a real
description instead of this macro.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Jacek Caban ja...@codeweavers.com changed: What|Removed |Added CC||ja...@codeweavers.com --- Comment #19 from Jacek Caban ja...@codeweavers.com 2011-03-16 16:39:45 EDT --- Hi all, I'm maintainer of Wine Gecko. We've just released the new version: http://www.winehq.org/pipermail/wine-devel/2011-March/089273.html This is the first version that makes it possible to do proper packaging, like you've tried to do. We've improved the building process a lot, so your problem is probably already fixed. Please let me know if you have any problems, so we can work on them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added CC||xose.vazq...@gmail.com --- Comment #17 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-02-06 05:36:44 EST --- *** Bug 675422 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #18 from Nerijus Baliunas neri...@users.sourceforge.net 2011-02-06 21:04:50 EST --- Regarding error in Comment 12 - it seems it tries to compile in wine-mozilla/media/libtheora/lib/dec/x86_vc directory, which is for Visual C, while it should probably compile in wine-mozilla/media/libtheora/lib/dec/x86. Am I right? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #16 from Stephen Kitt st...@sk2.org 2010-11-24 09:55:02 EST --- I don't know what's causing the problem in Comment 12, but I have figured out why the patch in Comment 11 was necessary previously: the daysFromBuildID function in config/version_win.pl extracts the build date from the build id, then calculates the number of days between the build date and Jan 1, 2000. This works fine just now because daylight savings time is not in effect; but at the time I posted Comment 11, it was, so the result of the calculation was one hour off and returned a non-integer value which caused the build to fail. So the patch in Comment 11 is still necessary for builds to work all year round... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #15 from Nerijus Baliunas neri...@users.sourceforge.net 2010-11-23 20:25:42 EST --- This patch does not help on F14, I still get error as in Comment 12. But there is no more error as in Comment 10 w/o applying patch in Comment 11, as it was on F13. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status Whiteboard||BuildFails --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2010-11-17 08:22:14 EST --- Please clear the whiteboard if providing a version which builds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #14 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2010-11-17 15:38:05 EST --- The build can be fixed by applying this small patch: --- js/src/jslock.cpp.orig 2010-11-17 19:34:59.449610055 +0100 +++ js/src/jslock.cpp 2010-11-17 20:07:18.980134638 +0100 @@ -66,7 +66,7 @@ /* Implement NativeCompareAndSwap. */ -#if defined(_WIN32) defined(_M_IX86) +#if defined(_WIN32) defined(_M_IX86) !defined(__MINGW32__) #pragma warning( disable : 4035 ) JS_BEGIN_EXTERN_C extern long __cdecl A scratch build of this was done at http://koji.fedoraproject.org/koji/taskinfo?taskID=2607153 For this build I added this patch to the wine-mozilla-gcc4-compile-fix.patch file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #12 from Nerijus Baliunas neri...@users.sourceforge.net 2010-08-15 08:20:36 EDT --- After applying the patch there is another error when compiling wine-mozilla/media/libtheora/lib/dec/x86_vc/mmxfrag.c: In file included from /home/nerijus/rpmbuild/BUILD/wine-mozilla/media/libtheora/lib/dec/x86_vc/../../internal.h:25, from /home/nerijus/rpmbuild/BUILD/wine-mozilla/media/libtheora/lib/dec/x86_vc/mmxfrag.c:17: ../../../dist/include/theora/theora.h:192: warning: comma at end of enumerator list /home/nerijus/rpmbuild/BUILD/wine-mozilla/media/libtheora/lib/dec/x86_vc/mmxfrag.c: In function 'oc_frag_recon_intra_mmx': /home/nerijus/rpmbuild/BUILD/wine-mozilla/media/libtheora/lib/dec/x86_vc/mmxfrag.c:36: error: '_asm' undeclared (first use in this function) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Stephen Kitt st...@sk2.org changed: What|Removed |Added CC||st...@sk2.org --- Comment #11 from Stephen Kitt st...@sk2.org 2010-08-05 01:19:54 EDT --- Applying the following patch should fix the build (it truncates the last component of the generated versions): --- wine-gecko-1.0.0.orig/config/version_win.pl +++ wine-gecko-1.0.0/config/version_win.pl @@ -54,8 +54,8 @@ sub daysFromBuildID $d || die(Unrecognized buildid string.); my $secondstodays = 60 * 60 * 24; -return (POSIX::mktime(00, 00, 00, $d, $m - 1, $y - 1900) - -POSIX::mktime(00, 00, 00, 01, 00, 100)) / $secondstodays; +return int((POSIX::mktime(00, 00, 00, $d, $m - 1, $y - 1900) - +POSIX::mktime(00, 00, 00, 01, 00, 100)) / $secondstodays); } #Creates version resource file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #10 from Nerijus Baliunas neri...@users.sourceforge.net 2010-07-13 09:14:03 EDT --- http://fedora.lowlatency.de/review/mingw32-wine-gecko-1.0.0-3.fc13.src.rpm does not build here on F13: Creating Resource file: module.res i686-pc-mingw32-windres -O coff --use-temp-file -DSQLITE_SECURE_DELETE=1 -DSQLITE_THREADSAFE=1 -DSQLITE_CORE=1 -DSQLITE_ENABLE_FTS3=1 -DOSTYPE=\WINNT\ -DOSARCH=WINNT --include-dir /home/nerijus/rpmbuild/BUILD/wine-mozilla/db/sqlite3/src --include-dir /home/nerijus/rpmbuild/BUILD/wine-mozilla/db/sqlite3/src --include-dir . --include-dir ../../../dist/include --include-dir ../../../dist/include/nsprpub --include-dir /home/nerijus/rpmbuild/BUILD/wine-mozilla/wine_gecko/dist/include/nspr --include-dir /home/nerijus/rpmbuild/BUILD/wine-mozilla/wine_gecko/dist/include/nss -o module.res /home/nerijus/rpmbuild/BUILD/wine-mozilla/wine_gecko/db/sqlite3/src/module.rc i686-pc-mingw32-windres: /home/nerijus/rpmbuild/BUILD/wine-mozilla/wine_gecko/db/sqlite3/src/module.rc:54: syntax error make[5]: *** [module.res] Error 1 $ rpm -qf /usr/bin/i686-pc-mingw32-windres mingw32-binutils-2.19.51.0.14-1.fc12.i686 module.rc from line 53: 1 VERSIONINFO FILEVERSION1,9,2,3845.958 PRODUCTVERSION 1,9,2,3845.958 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Nerijus Baliunas neri...@users.sourceforge.net changed: What|Removed |Added CC||neri...@users.sourceforge.n ||et --- Comment #8 from Nerijus Baliunas neri...@users.sourceforge.net 2010-07-06 19:14:13 EDT --- (In reply to comment #5) (In reply to comment #2) by me, but I was wondering if you already have patches ready for wine itself to use this package (as wine expects a .CAB file while this package provides a folder containing the gecko files) ? Yes, I have a patch sitting here which adds this to latest wine. Has the patch been sent upstream and did wine upstream accept it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #9 from Andreas Bierfert andreas.bierf...@lowlatency.de 2010-07-07 00:29:50 EDT --- It has not been submitted upstream yet. It however is included in the latest wine builds in updates-testing. However once it has been tested a bit more I will send it upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #7 from Andreas Bierfert andreas.bierf...@lowlatency.de 2010-07-02 11:39:57 EDT --- https://koji.fedoraproject.org/koji/taskinfo?taskID=2290258 Just did another build on F-13 seems to work again (probably was a bug in the mingw stack). It would be nice if someone could review the package. It works quite well from me an we are very very close to the 1.2 release of wine and this would be a cool thing to have... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #6 from Orion Poplawski or...@cora.nwra.com 2010-05-21 18:42:43 EDT --- I'm seeing a build failure on F-13 now, though F-14 (rawhide) seem okay. http://koji.fedoraproject.org/koji/taskinfo?taskID=2202453 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added Blocks||573530 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added CC||rjo...@redhat.com --- Comment #1 from Andreas Bierfert andreas.bierf...@lowlatency.de 2010-03-29 16:27:35 EDT --- https://koji.fedoraproject.org/koji/taskinfo?taskID=2082448 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #2 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2010-03-29 16:44:39 EDT --- Hi, I'll leave the review up to somebody else as this package was initially created by me, but I was wondering if you already have patches ready for wine itself to use this package (as wine expects a .CAB file while this package provides a folder containing the gecko files) ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #3 from Richard W.M. Jones rjo...@redhat.com 2010-03-29 16:58:21 EDT --- I might have a look at this tomorrow, but I'm interested to know why wine needs a Win32-cross-compiled library? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #4 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2010-03-29 17:10:22 EDT --- See the discussion on the fedora-mingw mailing list from november last year: http://lists.fedoraproject.org/pipermail/mingw/2009-November/002267.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 --- Comment #5 from Andreas Bierfert andreas.bierf...@lowlatency.de 2010-03-30 01:08:21 EDT --- Also take a look here: http://wiki.winehq.org/Gecko (In reply to comment #2) by me, but I was wondering if you already have patches ready for wine itself to use this package (as wine expects a .CAB file while this package provides a folder containing the gecko files) ? Yes, I have a patch sitting here which adds this to latest wine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
