[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|glite-security-trustmanager |glite-security-trustmanager
   |-2.5.5-4.el5|-2.5.5-4.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

--- Comment #12 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 13:26:58 EDT ---
glite-security-trustmanager-2.5.5-4.fc13 has been pushed to the Fedora 13
stable repository.  If problems still persist, please make note of it in this
bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2010-06-11 19:37:09 EDT ---
glite-security-trustmanager-2.5.5-4.el5 has been pushed to the Fedora EPEL 5
stable repository.  If problems still persist, please make note of it in this
bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||glite-security-trustmanager
   ||-2.5.5-4.el5
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-05-28 
14:08:13 EDT ---
glite-security-trustmanager-2.5.5-4.fc13 has been pushed to the Fedora 13
testing repository.  If problems still persist, please make note of it in this
bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update glite-security-trustmanager'. 
You can provide feedback for this update here:
http://admin.fedoraproject.org/updates/glite-security-trustmanager-2.5.5-4.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-05-27 
14:24:34 EDT ---
glite-security-trustmanager-2.5.5-4.el5 has been submitted as an update for
Fedora EPEL 5.
http://admin.fedoraproject.org/updates/glite-security-trustmanager-2.5.5-4.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Dennis Gilmore den...@ausil.us changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #6 from Dennis Gilmore den...@ausil.us 2010-05-25 16:59:11 EDT ---
CVS Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Mattias Ellert mattias.ell...@fysast.uu.se changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Mattias Ellert mattias.ell...@fysast.uu.se 2010-05-23 
09:28:03 EDT ---
Package approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Steve Traylen steve.tray...@cern.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Steve Traylen steve.tray...@cern.ch 2010-05-23 14:16:04 
EDT ---
New Package CVS Request
===
Package Name: glite-security-trustmanager
Short Description: Java trustmanager interface supporting a GSI grid name space
Owners: stevetraylen
Branches: F-12 F-13 EL-5 EL-6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

--- Comment #3 from Steve Traylen steve.tray...@cern.ch 2010-05-22 17:59:23 
EDT ---
All items in comment #2 have been addressed including adding vomjapi
to %post scriptlet.

As an aside I notice that bouncycastle has started including some classes
directly from vomsjapi. Something to check outside this review.

http://cern.ch/straylen/rpms/glite-security-trustmanager/glite-security-trustmanager-2.5.5-2.fc13.src.rpm

http://cern.ch/straylen/rpms/glite-security-trustmanager/glite-security-trustmanager.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-05-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

Mattias Ellert mattias.ell...@fysast.uu.se changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mattias.ell...@fysast.uu.se
   Flag||fedora-review?

--- Comment #2 from Mattias Ellert mattias.ell...@fysast.uu.se 2010-05-21 
13:26:53 EDT ---
Fedora review  glite-security-trustmanager  2010-05-21


rpmlint output:

$ rpmlint ~/rpmbuild/RPMS/*/glite-security-trustmanager-*
../glite-security-trustmanager-2.5.5-1.fc12.src.rpm 
glite-security-trustmanager-javadoc.noarch: W: spelling-error Summary(en_US)
javadocs - java docs, java-docs, Javanese
glite-security-trustmanager-tomcat5.noarch: W: spelling-error %description -l
en_US util - til, until, u til
glite-security-trustmanager-tomcat5.noarch: W: spelling-error %description -l
en_US nescesary - necessary, necessarily, Nescafe
glite-security-trustmanager-tomcat5.noarch: W: log-files-without-logrotate
/var/log/glite-security-trustmanager
glite-security-trustmanager.x86_64: W: spelling-error %description -l en_US
util - til, until, u til
glite-security-trustmanager.src: W: spelling-error %description -l en_US util
- til, until, u til
glite-security-trustmanager.src:170: W: libdir-macro-in-noarch-package (main
package) %attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.*
glite-security-trustmanager.src: W: invalid-url Source0:
glite-security-trustmanager-2.5.5.tar.gz
5 packages and 0 specfiles checked; 0 errors, 8 warnings.

The spelling error nescesary → necessary should be fixed, otherwise OK.


+ Java package with a single jarfile → package name equals name of jar
+ Specfile is named after package
+ License ASL 2.0 is a Fedora approved license
+ The license tag in the spec file corresponds to the license of the sources
+ License file is included in %doc
+ Specfile is written in legible English
+ Sources matches upstream
+ Package compiles successfully (Fedora 13)
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=2201657
+ BuildRequires are sane
+ No bundled libraries

- Package should own the directory /usr/lib64/gcj/glite-security-trustmanager

+ No duplicate files

? Permissions are sane and %files has %defattr
Marking the gcj aot files with %attr(-,root,root) seems redundant though,
since this is covered by the %defattr

+ Specfile uses macros consistently
+ %doc is not runtime essential

+ Package does not own others directories
The /etc/grid-security directory is owned by many packages, but there is
no master package on which all the others depend on, so this is fine

? Do you need vomsjapi in the list of java libraries that get put in
  the tomcat server lib repository in the %post scriptlet?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space

2010-04-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577974

--- Comment #1 from Steve Traylen steve.tray...@cern.ch 2010-04-30 12:08:19 
EDT ---
New versions:

http://cern.ch/straylen/rpms/glite-security-trustmanager/glite-security-trustmanager-2.5.5-1.fc12.src.rpm

http://cern.ch/straylen/rpms/glite-security-trustmanager/glite-security-trustmanager.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review