[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #14 from Fedora Update System 2010-07-13 03:50:35 EDT --- lxpolkit-0.1.0-0.1.20100402git5087383.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Fedora Update System changed: What|Removed |Added Fixed In Version|lxpolkit-0.1.0-0.1.20100402 |lxpolkit-0.1.0-0.1.20100402 |git5087383.fc12 |git5087383.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Fedora Update System changed: What|Removed |Added Fixed In Version||lxpolkit-0.1.0-0.1.20100402 ||git5087383.fc12 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #13 from Fedora Update System 2010-07-13 03:34:48 EDT --- lxpolkit-0.1.0-0.1.20100402git5087383.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Christoph Wickert changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #12 from Fedora Update System 2010-07-04 16:43:33 EDT --- lxpolkit-0.1.0-0.1.20100402git5087383.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/lxpolkit-0.1.0-0.1.20100402git5087383.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #11 from Fedora Update System 2010-07-04 16:41:06 EDT --- lxpolkit-0.1.0-0.1.20100402git5087383.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/lxpolkit-0.1.0-0.1.20100402git5087383.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #10 from Christoph Wickert 2010-07-04 16:37:39 EDT --- I will just go ahead and build this package. I don't really care if I break something, the GNOME folks had 3 months to object but nobody replied to my latest mail. I just sent another mail to the desktop list, lets see what happens. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #9 from Kevin Fenzi 2010-07-04 15:34:34 EDT --- Any news here? Or still in limbo? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #8 from Christoph Wickert 2010-06-05 18:38:00 EDT --- It is imported but nit yet built because I'm still afraid to break everything due to the "shortest package name wins" rule of yum. I asked on the mailing list but we were not able to reach a census. Instead, Matthias Clasen wanted to make a feature of this, see http://fedoraproject.org/wiki/Features/PolkitAgentReorg -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #7 from Kevin Fenzi 2010-06-05 16:49:17 EDT --- Can this be imported and built now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #6 from Kevin Fenzi 2010-04-07 22:45:11 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Christoph Wickert changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Christoph Wickert 2010-04-05 06:32:22 EDT --- New Package CVS Request === Package Name: lxpolkit Short Description: Simple PolicyKit authentication agent Owners: cwickert Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Kevin Fenzi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Kevin Fenzi 2010-04-04 23:29:45 EDT --- Yeah, that all sounds good. I see no further blockers here... this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #3 from Christoph Wickert 2010-04-04 17:46:44 EDT --- (In reply to comment #2) > > 1. Your git checkout comment has the wrong repo in it. ;) Copy & paste... I will fix this before building. > lxpolkit.src:27: W: unversioned-explicit-provides > PolicyKit-authentication-agent > > Should that be versioned? I would guess not. Right, this is a virtual provides, so no versioning. We will get fun with that one anyway: compared to polkit-gnome or polkit-kde, lxpolkit is the shortest name and will be pulled in by yum. All desktop files in autostart will need "OnlyShowIn=..." so that only one agent gets started in each desktop. I think it makes sense if the people using a legacy window manager like openbox or alike will get lxshortcut instead of a GNOME or KDE specific agent. But I will discuss this on f-d-l since we need to coordinate the updates. > lxpolkit.x86_64: W: conffile-without-noreplace-flag > /etc/xdg/autostart/lxpolkit.desktop > > Should this be config(noreplace)? I guess not. We want translation updates or a change in the path to appear there and changes like en/disabling the autostart are done in the private autostart ~/.config/autostart/ anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 --- Comment #2 from Kevin Fenzi 2010-04-04 15:08:45 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Your git checkout comment has the wrong repo in it. ;) Should be git://lxde.git.sourceforge.net/gitroot/lxde/lxpolkit 2. rpmlint says: lxpolkit.src:27: W: unversioned-explicit-provides PolicyKit-authentication-agent Should that be versioned? I would guess not. lxpolkit.src: W: invalid-url Source0: lxpolkit-20100402git5087383.tar.bz2 lxpolkit.x86_64: W: conffile-without-noreplace-flag /etc/xdg/autostart/lxpolkit.desktop Should this be config(noreplace)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@tummy.com Flag||fedora-review? --- Comment #1 from Kevin Fenzi 2010-04-04 14:54:49 EDT --- I'll go ahead and review this. Look for a full review in a bit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579171 Christoph Wickert changed: What|Removed |Added Blocks||505781(LXDE) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
