[Bug 579288] Review Request: pyclutter-gst - Python modules that allow you to use the Clutter-GST toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579288
--- Comment #1 from Ankur Sinha sanjay.an...@gmail.com 2010-04-14 06:57:44
EDT ---
review:
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
? Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[pack...@localhost SPECS]$ md5sum pyclutter-gst-1.0.0.tar.bz2
b1cc99a70042bb91ad75937405ed64d9 pyclutter-gst-1.0.0.tar.bz2
[pack...@localhost SPECS]$ md5sum ../SOURCES/pyclutter-gst-1.0.0.tar.bz2
b1cc99a70042bb91ad75937405ed64d9 ../SOURCES/pyclutter-gst-1.0.0.tar.bz2
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
+ Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
+ .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
+ -devel package Requires: %{name} = %{version}-%{release}
+ .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk and
anything provided by glibc.)
SHOULD Items:
+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
+ Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
Issues:
1.change %{buildroot} to $RPM_BUILD_ROOT on line 52
The rest looks okay.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579288] Review Request: pyclutter-gst - Python modules that allow you to use the Clutter-GST toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579288
--- Comment #2 from Peter Robinson pbrobin...@gmail.com 2010-04-14 07:03:02
EDT ---
1.change %{buildroot} to $RPM_BUILD_ROOT on line 52
Already have updated on my local copy.
The rest looks okay.
Any reason you haven't approved it then, the minor fix is done locally and
doesn't overly impact the approval of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579288] Review Request: pyclutter-gst - Python modules that allow you to use the Clutter-GST toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579288 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579288] Review Request: pyclutter-gst - Python modules that allow you to use the Clutter-GST toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579288 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added CC||sanjay.an...@gmail.com AssignedTo|nob...@fedoraproject.org|sanjay.an...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
