[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|zita-resampler-0.1.1-2.fc13 |zita-resampler-0.1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||zita-resampler-0.1.1-2.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-05-12 13:56:48 EDT --- zita-resampler-0.1.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|zita-resampler-0.1.1-2.fc11 |zita-resampler-0.1.1-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-05-04 03:55:40 EDT --- zita-resampler-0.1.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/zita-resampler-0.1.1-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-05-04 03:56:45 EDT --- zita-resampler-0.1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/zita-resampler-0.1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-05-04 03:56:15 EDT --- zita-resampler-0.1.1-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zita-resampler-0.1.1-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-05-04 19:49:33 EDT --- zita-resampler-0.1.1-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zita-resampler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zita-resampler-0.1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-05-04 19:57:03 EDT --- zita-resampler-0.1.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zita-resampler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zita-resampler-0.1.1-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-05-04 19:54:59 EDT --- zita-resampler-0.1.1-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zita-resampler'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/zita-resampler-0.1.1-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #9 from Kevin Fenzi ke...@tummy.com 2010-05-03 22:53:11 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 David Cornette r...@davidcornette.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #5 from David Cornette r...@davidcornette.com 2010-05-01 01:14:09 EDT --- The issue that I brought up earlier (builds failing on non-Intel type architectures) has been fixed. The only issue I see (and it is not a blocker, since it is not a must) is that there is no man page. The guidelines suggest working with upstream to try to get one. I understand that you have not had good luck getting responses from this upstream developer in the past, but you could just send an email asking for a man page. Unless you feel like making one yourself, of course. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #6 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-05-01 02:57:03 EDT --- Sure, I just sent an email to Fons, although I have serious doubts that he will take it into consideration. I don't have time to make a man page myself. Maybe over the summer... or we can wait Debian to package this and then we can borrow their man page :) since it is a requirement in their guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 David Cornette r...@davidcornette.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from David Cornette r...@davidcornette.com 2010-05-01 12:48:46 EDT --- There are no blockers, and the man page issue is being dealt with as best as possible. == APPROVED == -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #4 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-04-30 19:33:46 EDT --- Hi David, just a reminder, since you are sponsored now you can finish the review on this one. You are not required to though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581197
David Cornette r...@davidcornette.com changed:
What|Removed |Added
CC||r...@davidcornette.com
--- Comment #2 from David Cornette r...@davidcornette.com 2010-04-16 15:21:33
EDT ---
Since I am not yet a fedora packager, this is an informal review. I am
probably being more verbose than normal.
There is one issue that should be addressed. This package does not build
properly on architectures other than i686 and x86_64.
# MUST: rpmlint must be run on every package. The output should be posted in
the review.
$ rpmlint zita-resampler-0.1.1-1.fc12.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
GOOD
# MUST: The package must be named according to the Package Naming Guidelines .
Name contains only permitted ASCII characters. Name matches tarball.
Separators are hyphens. Base name is unique. Spec file name is %{name}.spec.
Version is numeric, and matches uptstream. Release is 1%{?dist}. Case matches
upstream. Not renaming a package. Documentation is not large. Not a font or
addon package.
GOOD
# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
GOOD
# MUST: The package must meet the Packaging Guidelines .
GOOD
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
Package is licensed as GPLv2+, all source files appropriately marked.
GOOD
# MUST: The License field in the package spec file must match the actual
license.
License field matches actual license GPLv2+.
GOOD
# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
COPYING file is included in %doc.
# MUST: The spec file must be written in American English. [5]
GOOD
# MUST: The spec file for the package MUST be legible. [6]
GOOD
# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ wget
http://www.kokkinizita.net/linuxaudio/downloads/zita-resampler-0.1.1.tar.bz2
$ md5sum rpmbuild/SOURCES/zita-resampler-0.1.1.tar.bz2
zita-resampler-0.1.1.tar.bz2
cbf0da8b7ace593082a5f01eed828109 rpmbuild/SOURCES/zita-resampler-0.1.1.tar.bz2
cbf0da8b7ace593082a5f01eed828109 zita-resampler-0.1.1.tar.bz2
GOOD
# MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Builds on x86_64.
GOOD
# MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Build fails on ppc and ppc64. The upstream makefile uses the following to set
the path to install libraries to /usr/libppc or /usr/libppc64, but the %files
section is looking for them to be in %{_libdir}, which is just /usr/lib or
/usr/lib64. arm, s390x, and sparc were not tested, but it appears this issue
would occur on these arches as well.
BAD
# MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
GOOD
# MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
No locales used by package.
GOOD
# MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
Both sections call ldconfig.
GOOD
# MUST: Packages must NOT bundle copies of system libraries.
GOOD
# MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
Not relocatable.
GOOD
# MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
GOOD
# MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-04-16 20:48:48 EDT --- Thank you for the comprehensive but informal review. I fixed the libdir issue: SPEC: http://6mata.com:8014/review/zita-resampler.spec SRPM: http://6mata.com:8014/review/zita-resampler-0.1.1-2.fc12.src.rpm koji F-12 build succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=2122016 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581197] Review Request: zita-resampler - Fast, high-quality sample rate conversion library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581197 --- Comment #1 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-04-10 21:55:36 EDT --- builds fine on F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2108005 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
