[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||extundelete-0.1.8-2.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2010-04-27 21:19:22 EDT --- extundelete-0.1.8-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|extundelete-0.1.8-2.fc13|extundelete-0.1.8-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|extundelete-0.1.8-2.fc12|extundelete-0.1.8-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2010-04-27 21:17:44 EDT --- extundelete-0.1.8-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-04-26 08:31:36 EDT --- extundelete-0.1.8-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/extundelete-0.1.8-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-04-26 08:33:23 EDT --- extundelete-0.1.8-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/extundelete-0.1.8-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-04-26 08:34:55 EDT --- extundelete-0.1.8-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/extundelete-0.1.8-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-04-27 01:50:42 EDT --- extundelete-0.1.8-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #15 from Kevin Fenzi ke...@tummy.com 2010-04-25 23:42:25 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581723
ELMORABITY Mohamed pikachu.2...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #12 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-04-24
19:28:59 EDT ---
Here is the review:
MUST Items:
[X] MUST: rpmlint must be run on every package.
No error/warning except the spelling issues mentioned above that can be
ignored. debug package is OK.
[X] MUST: The package must be named according to the Package Naming Guidelines.
[X] MUST: The spec file name must match the base package %{name}
[X] MUST: The package must meet the Packaging Guidelines.
[X] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
GPLv2+
[X] MUST: The License field in the package spec file must match the actual
license.
See LICENSE file, and comments on source code are OK about the license
[W] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[X] MUST: The spec file must be written in American English.
[X] MUST: The spec file for the package MUST be legible.
[X] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
ff1d0a660727d358364134828fed1a16 → both for embedded archive and downloaded one
[X] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
OK:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2135293
http://koji.fedoraproject.org/koji/taskinfo?taskID=2135291
(Ok also for F11 and F14)
[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[X] MUST: All build dependencies must be listed in BuildRequires
[N/A] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro.
[N/A] MUST: Every binary RPM package which stores shared library files (not
just symlinks) in any of the dynamic linker's default paths, must call ldconfig
in %post and %postun.
[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A package must not contain any duplicate files in the %files
listing.
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[OK] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[OK] MUST: Each package must consistently use macros, as described in the
macros section of Packaging Guidelines.
[OK] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[N/A] MUST: Large documentation files should go in a doc subpackage.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[N/A] MUST: Header files must be in a -devel package.
[N/A] MUST: Static libraries must be in a -static package.
[N/A] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[N/A] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[N/A] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[N/A] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[N/A] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[OK] MUST: Packages must not own files or directories already owned by other
packages.
[OK] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
This package is APPROVED :-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #13 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-24 20:20:26 EDT --- Thanks Mohamed for reviewing this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 Hicham HAOUARI hicham.haou...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #14 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-24 20:22:43 EDT --- New Package CVS Request === Package Name: extundelete Short Description: An ext3 and ext4 file system undeletion utility Owners: hicham Branches: F-11 F-12 F-13 InitialCC: hicham -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #10 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-18 09:27:38 EDT --- Patch approved by upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #11 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-18 09:37:38 EDT --- further cleanup Spec URL: http://hicham.fedorapeople.org/extundelete.spec SRPM URL: http://hicham.fedorapeople.org/extundelete-0.1.8-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #6 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-14 10:49:35 EDT --- Oops, this creates a segfault. I don't know if we should use it with the compilation warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #7 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-14 12:56:54 EDT --- I think this warning goes beyond the scope of this review as it e2fsprogs related -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #8 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-14 13:20:33 EDT --- e2fsprogs does have those warnings in koji too, so we must cope with them. feel free to add any further remarks apart from the warnings :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #2 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-13 07:28:40 EDT --- Updated Spec URL: http://hicham.fedorapeople.org/extundelete.spec SRPM URL: http://hicham.fedorapeople.org/extundelete-0.1.8-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #3 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-13 09:23:12 EDT --- Using the RPM_OPT_FLAGS emerged new compiler warnings about strict aliasing break. I am gonna upstream a patch and see what they say. You can see the patch at : http://hicham.fedorapeople.org/extundelete-no-strict-aliasing-break.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #4 from Hicham HAOUARI hicham.haou...@gmail.com 2010-04-13 09:31:33 EDT --- For 3), current git uses autotools, so in next release, I hope I will drop the CXXFLAGS patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 Hicham HAOUARI hicham.haou...@gmail.com changed: What|Removed |Added Summary|Review Request: extudelete |Review Request: extundelete |- An ext3 and ext4 file |- An ext3 and ext4 file |system undeletion utility |system undeletion utility -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581723] Review Request: extundelete - An ext3 and ext4 file system undeletion utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #1 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-04-13 01:47:44 EDT --- Hi, just a few comments before a potential review. 1) You don't need to add kernel-headers as a BuildRequires, since it is a dependancy of gcc, and gcc an implicit BuildRequires. So remove kernel-headers in your BR. 2) You don't need also to set e2fsprogs as a Requires. Your binary is dynamically linked to libext2fs.so, and this library is set automatically as a Requires when your RPM is built. Moreover your binary doesn't call any executable from the e2fsprogs package. So remove e2fsprogs in your Requires. 3) The binary is not compiled with the Fedora flags (see https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags). You should patch the Makefile to make it use CXXFLAGS and then set the value of CXXFLAGS to $RPM_OPT_FLAGS in your .spec file... Or even ask upstream to write better Makefiles :-P 4) Not very important, but your description and your summary are the same. Maybe you can develop your Description like this: extundelete is a utility that can recover deleted files from an ext3 or ext4 partition. extundelete uses the information stored in the partition's journal to attempt to recover a file that has been deleted from the partition. There is no guarantee that any particular file will be able to be undeleted, so always try to have a good backup system in place, or at least put one in place after recovering your files! (taken from the project website; I think it is better since we have a warning about the fact that extundelete is not infallible). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
