[Bug 584111] Review Request: cmatrix - Simulate the display from " The Matrix"
https://bugzilla.redhat.com/show_bug.cgi?id=584111 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms Resolution|NOTABUG |DUPLICATE --- Comment #27 from Raphael Groner --- *** This bug has been marked as a duplicate of bug 1462465 *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 Ayush Mah'ri changed: What|Removed |Added Flag|needinfo?(ayush.hakmn@gmail | |.com) | --- Comment #24 from Ayush Mah'ri 2011-04-10 09:31:52 EDT --- David: I regret, i didn't had done any reviews. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 David Nalley changed: What|Removed |Added CC||da...@gnsa.us Flag||needinfo?(ayush.hakmn@gmail ||.com) --- Comment #23 from David Nalley 2011-04-10 00:38:54 EDT --- Ayush: Have you done any informal reviews as suggested several months ago?? Please provide links here if you have. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 Jason Tibbitts changed: What|Removed |Added Status Whiteboard||StalledSubmitter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #22 from Ayush Mah'ri 2011-01-19 03:13:03 EST --- Hello guys, I confess that i've been quite lazy in following some other review work due to few reasons. Now, I will make sure to follow the procedures so as to gain the sight of sponsors. Please bear in for few days more with this package :) Thanks n Regards, Ayush -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #21 from Jason Tibbitts 2011-01-18 18:10:21 EST --- I think so. I'm not sure if there's any will to do any other review work, and the package is pretty trivial so we (the sponsors) don't have much of an idea of how well the guidelines are actually understood. The URL with instructions on how to obtain sponsorship were posted twice but it seems that Ayush doesn't want to follow them. And, to be brutally honest, the software scrolls some green text around the screen. It's not going to be a really high priority. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #20 from Jon Kent 2011-01-18 16:59:05 EST --- Hi Ayush, Why didn't this go anywhere, all builds fine and the spec looks good to me. Is it just sponsorship issues? Cheers, Jon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #19 from Ayush Mah'ri 2011-01-16 10:33:03 EST --- Hi Jon, You can take it, if you like. Regards, ayush -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 Jon Kent changed: What|Removed |Added CC||jon.k...@gmail.com --- Comment #18 from Jon Kent 2011-01-14 17:14:40 EST --- Hi, Is there still life in this package, if not I'm happy to take this on board. regards, Jon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #17 from Ankur Sinha 2010-12-26 02:00:37 EST --- Ayush, You will need to review packages etc. in order to get sponsored to the packager group. Please have a look at this link on how to proceed. http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #16 from Ayush Mah'ri 2010-12-22 17:22:07 EST --- Hey Jason, Unfortunately , i haven't done any other review work but i still wish to submit this package . Regards, Ayush -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #15 from Jason Tibbitts 2010-12-22 14:53:32 EST --- Have you done any other review work? Did you still wish to submit this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #14 from Ankur Sinha 2010-05-29 03:24:06 EDT --- hey, next step: http://fedoraproject.org/w/index.php?title=PackageMaintainers/HowToGetSponsored&redirect=no regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #13 from Ayush Mah'ri 2010-05-24 15:13:09 EDT --- SPEC URL : http://hakmn.fedorapeople.org/cmatrix.spec SRPM URL : http://hakmn.fedorapeople.org/cmatrix-1.2a-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584111
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #12 from Martin Gieseking 2010-05-24
04:42:47 EDT ---
A couple of additional comments:
- rename the spec file to cmatrix.spec
- append %{?dist} to the Release number
- replace %doc %{_mandir}/man1/cmatrix.1.gz
with %{_mandir}/man1/cmatrix.1*
$ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm
cmatrix.src: W: spelling-error %description -l en_US screensaver -> screen
saver, screen-saver, screens aver
cmatrix.src: E: invalid-spec-name
cmatrix.src: W: no-cleaning-of-buildroot %install
cmatrix.src: W: no-buildroot-tag
cmatrix.x86_64: W: spelling-error %description -l en_US screensaver -> screen
saver, screen-saver, screens aver
3 packages and 0 specfiles checked; 1 errors, 4 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 Ankur Sinha changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #11 from Ankur Sinha 2010-05-03 15:26:03 EDT --- hey, The package also uses *ancient* font locations. I've pinged upstream requesting him to update his autotooling. Hopefully we'll have an updated source soon. Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584111 --- Comment #10 from ayush.ha...@gmail.com 2010-04-26 02:17:10 EDT --- Thanks Jussi for the comments. I've mixed up all in my head i read from the Packaging Guidelines pages. I'll not commit such silly mistakes again. :) I've edited the spec & build srpm, here are they newly uploaded --> SPEC URL : http://hakmn.fedorapeople.org/cmatrix-1.2a-3.spec SRPM URL : http://hakmn.fedorapeople.org/cmatrix-1.2a-3.src.rpm RPMLINT O/P URL : http://hakmn.fedorapeople.org/rpmlint-cmatrix-1.2a-3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584111
--- Comment #9 from Jussi Lehtola 2010-04-25 17:31:16
EDT ---
- The line
%define version 1.2a
is redundant. The Version tag already defines the macro %{version}.
- The line
%{_mandir}/*/*
is a bit too general. Be more verbose. Use wildcards only when necessary, since
they may end up owning things that they're not supposed to.
- The original spec you used was 1.2a-1. Your first should have been 1.2a-2,
and the second one 1.2a-3. So the next version-release should be 1.2a-4.
Rectify this.
- When you do the above, indicate what you have changed in the releases in the
changelog.
- Note that the changelog is still not in the correct format. See
fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584111
--- Comment #8 from ayush.ha...@gmail.com 2010-04-25 14:57:30 EDT ---
(In reply to comment #7)
> Be sure to go through the Fedora guidelines, most importantly of which
> http://fedoraproject.org/wiki/Packaging/Guidelines
> http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
> Additionally to the Packaging Guidelines, there are a bunch of language /
> application specific guidelines that are linked to in the Packaging
> Guidelines.
>
> Here are some tricks of the trade:
> http://fedoraproject.org/wiki/Packaging_tricks
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
> http://fedoraproject.org/wiki/Common_Rpmlint_issues
>
>
> **
>
> Notes:
>
> - increment the release every time you make changes to the spec file, also
> during the review process. This makes it easier for others to see what has
> been
> done.
>
> - your changelog does not adhere to the changelog format, you need to add the
> release. (See packaging guidelines) Also, add an empty line inbetween
> different
> changelog entries.
>
> - Use
> make %{?_smp_mflags}
> instead of
> make
> to enable SMP build.
>
> - Drop explicit Requires: ncurses. This is automatically picked up by rpm.
>
> - I suggest changing Source: to Source0.
>
> - Use %{version} macro in source line, i.e.
> http://www.asty.org/cmatrix/dist/cmatrix-1.2a.tar.gz
> should be
> http://www.asty.org/cmatrix/dist/cmatrix-%{version}.tar.gz
>
> - Don't duplicate the name in the summary. The summary should be:
> Simulate the display from "The Matrix"
Thanks Jussi for the comments.
I'd edited the spec file as commented by you & included rpmlint output in
another file .
SRPM URL : http://hakmn.fedorapeople.org/cmatrix-1.2a-2.src.rpm
SPEC URL : http://hakmn.fedorapeople.org/cmatrix.spec
RPMLINT o/p URL : http://hakmn.fedorapeople.org/rpmlint-cmatrix
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584111
Jussi Lehtola changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
Blocks||177841(FE-NEEDSPONSOR)
Summary|Review Request: Cmatrix |Review Request: cmatrix -
|shows a Matrix like screen |Simulate the display from
||"The Matrix"
--- Comment #7 from Jussi Lehtola 2010-04-25 12:26:22
EDT ---
Be sure to go through the Fedora guidelines, most importantly of which
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
Additionally to the Packaging Guidelines, there are a bunch of language /
application specific guidelines that are linked to in the Packaging Guidelines.
Here are some tricks of the trade:
http://fedoraproject.org/wiki/Packaging_tricks
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
http://fedoraproject.org/wiki/Common_Rpmlint_issues
**
Notes:
- increment the release every time you make changes to the spec file, also
during the review process. This makes it easier for others to see what has been
done.
- your changelog does not adhere to the changelog format, you need to add the
release. (See packaging guidelines) Also, add an empty line inbetween different
changelog entries.
- Use
make %{?_smp_mflags}
instead of
make
to enable SMP build.
- Drop explicit Requires: ncurses. This is automatically picked up by rpm.
- I suggest changing Source: to Source0.
- Use %{version} macro in source line, i.e.
http://www.asty.org/cmatrix/dist/cmatrix-1.2a.tar.gz
should be
http://www.asty.org/cmatrix/dist/cmatrix-%{version}.tar.gz
- Don't duplicate the name in the summary. The summary should be:
Simulate the display from "The Matrix"
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
