[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Alias|whatweb | -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #61 from Fedora Update System --- FEDORA-EPEL-2023-7e1332650e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #60 from Fedora Update System --- FEDORA-2023-14fdcf9dab has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #59 from Fedora Update System --- FEDORA-2023-4c94b61805 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #58 from Fedora Update System --- FEDORA-EPEL-2023-16c0514367 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Fedora Update System changed: What|Removed |Added Resolution|CURRENTRELEASE |ERRATA --- Comment #57 from Fedora Update System --- FEDORA-2023-caa0fc7fb4 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Status|ON_QA |CLOSED Alias||rr_whatweb Resolution|--- |CURRENTRELEASE Last Closed|2021-06-16 00:45:22 |2023-03-05 11:46:42 --- Comment #56 from Michal Ambroz --- Thank you Otto for review. Package is on its way to Fedora. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Leon Fauster changed: What|Removed |Added CC||leonfaus...@googlemail.com --- Comment #55 from Leon Fauster --- JFYI / EPEL( # LANG=C yum install whatweb --enablerepo=epel-testing Last metadata expiration check: 0:04:59 ago on Sun Mar 5 12:23:44 2023. Error: Problem: conflicting requests - nothing provides rubygem-addressable needed by whatweb-0.5.5-4.el8.noarch (try to add '--skip-broken' to skip uninstallable packages) -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #54 from Fedora Update System --- FEDORA-2023-caa0fc7fb4 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-caa0fc7fb4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #53 from Fedora Update System --- FEDORA-2023-14fdcf9dab has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-14fdcf9dab \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-14fdcf9dab See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #52 from Fedora Update System --- FEDORA-EPEL-2023-7e1332650e has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7e1332650e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #51 from Fedora Update System --- FEDORA-EPEL-2023-16c0514367 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-16c0514367 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #50 from Fedora Update System --- FEDORA-2023-4c94b61805 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4c94b61805 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4c94b61805 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #49 from Fedora Update System --- FEDORA-EPEL-2023-16c0514367 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-16c0514367 -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #46 from Fedora Update System --- FEDORA-2023-caa0fc7fb4 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-caa0fc7fb4 --- Comment #47 from Fedora Update System --- FEDORA-2023-4c94b61805 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4c94b61805 -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #46 from Fedora Update System --- FEDORA-2023-caa0fc7fb4 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-caa0fc7fb4 -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #45 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/whatweb -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Otto Liljalaakso changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #44 from Otto Liljalaakso --- Thank you, Review passed, please request the dist-git repository now. We managed to complete this is less than 13 years! -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #42 from Jakub Kadlčík --- Created attachment 1947359 --> https://bugzilla.redhat.com/attachment.cgi?id=1947359&action=edit The .spec file difference from Copr build 5565977 to 5584602 -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #43 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5584602 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-587978-whatweb/fedora-rawhide-x86_64/05584602-whatweb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Flags|needinfo?(re...@seznam.cz) | --- Comment #41 from Michal Ambroz --- Thank you Otto, here is the update. SPEC URL: http://rebus.fedorapeople.org/SPECS/whatweb.spec SRPM URL: https://rebus.fedorapeople.org/SRPMS/whatweb-0.5.5-4.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com --- Comment #40 from Fabio Valentini --- PS: The URL fragment hack to name GitHub tarball downloads has not been necessary for a few years: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978
Otto Liljalaakso changed:
What|Removed |Added
Flags|needinfo?(otto.liljalaakso@ |fedora-review?
|iki.fi) |needinfo?(re...@seznam.cz)
--- Comment #39 from Otto Liljalaakso ---
Hello Michal,
yes let us finish this one.
> License:GPLv2+
Meanwhile, Fedora's system of noting the license has changed.
Now, SPDX identifiers must be used, so this need to be written as
GPL-2.0-or-later.
Reference: https://docs.fedoraproject.org/en-US/legal/license-field/
> Requires: %{_bindir}/ruby
I asked you to switch to this form, but it turns out I was wrong.
In the context of Requires, this actually must be written as /usr/bin/ruby.
Sorry for the noise.
Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies,
last paragraph
Other than these two small things, this review is ready.
Please correct them and I will flag the review as complete.
--
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=587978
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Jakub Kadlčík changed: What|Removed |Added URL||http://www.morningstarsecur ||ity.com/research/whatweb --- Comment #38 from Jakub Kadlčík --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5565977 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-587978-whatweb/fedora-rawhide-x86_64/05565977-whatweb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Status|CLOSED |NEW Flags||needinfo?(otto.liljalaakso@ ||iki.fi) Resolution|NOTABUG |--- --- Comment #37 from Michal Ambroz --- Hello Otto, Are you still around? Sorry ... this review slipped my mind and emails went to spam. Package served me well all those years, just think it could be useful to others as well so I am reopening the review again. SPEC URL: http://rebus.fedorapeople.org/SPECS/whatweb.spec SRPM URL: https://rebus.fedorapeople.org/SRPMS/whatweb-0.5.5-3.fc37.src.rpm Here the scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=97982216 $ rpmlint whatweb.spec whatweb-0.5.5-3.fc37.src.rpm whatweb-0.5.5-3.fc37.noarch.rpm rpmlint session starts rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 = 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.1 s = -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=587978 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #36 from Otto Urpelainen --- Oh, this is a shame, this was so close. My two remaining items were both non-blocking, so just a reply "I do not want to make any more changes" would have sufficed to get this accepted. Please reopen if you still wish to complete this. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Otto Urpelainen changed: What|Removed |Added Flags|needinfo?(otu...@iki.fi)|needinfo?(re...@seznam.cz) --- Comment #34 from Otto Urpelainen --- Commenting only on items where I have something to all, for all others: Thank you for the explanation. (In reply to Michal Ambroz from comment #32) > (In reply to Otto Urpelainen from comment #31) > > > 3. Fixing env shebangs should not be required in Fedora anymore. If this is > > still needed for some reason (RHEL perhaps?), comment should be updated to > > match > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_shebang_lines > > I consider env to be potential security problem and preffer to be explicit > about the interpreter used in the packaged stuff. > The guide is saying as well that it SHOULD use #!/usr/bin/ruby . > The "env ruby" is not always only /usr/bin/ruby. Depending on environment > settings it could be also /usr/local/bin/ruby or ~user/bin/ruby or even > /tmp/you_have_been_hacked/ruby . Ah, I apologize, I worded by comment badly and linked to wrong, only marginally relevant section of the guidelines. What I was trying to say was this: Nowadays, shebang lines are automatically modified to replace env with the correct interpreter, so there should be no need to do that manually. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines Doing that manually is not forbidden either, so it can stay that way if you prefer. But doing that explicitly does not change the result from what the defaults already do. > > 4. I do not understand this. Is this an issue with upstream man pages? If > > so, a fix or an issue should be submitted and referenced from the specfile. > > > > > # Unknown macros in manpage > > > sed -i -e 's|^.ni||; s|^\./plugins-disabled|+\./plugins-disabled|' > > > whatweb.1 > Yes ... I guess that on Ubuntu they use different groff for formatting the > man pages so it is ok for them. > On Fedora it complains so I have to remove that tags. I see, it may be for the '.ni' case. The './plugins-disabled' is for sure part of the example for enabling and disabling plugin directories. I took a closer look at the upstream whatweb.1, and my interpretation is that the file simply is in a bad shape and would benefit from a PR like this. I encourage submitting fixes. But if you do not want to do that, that's ok too, I won't reject this review for that. Regarding the substitutions: 1. Instead of 's|^.ni||', use 's|^\.ni||', to replace the unknown request '.ni' and not lines starting with 'Ani', 'Bni' etc. 2. Instead of 's|^\./plugins-disabled|+\./plugins-disabled|', use 's|^\./plugins-disabled|\\\./plugins-disabled|'. '+' is not a Groff way to escape '.', but happens to be Whatweb syntax and thus changes the example. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #33 from Mamoru TASAKA --- (In reply to Otto Urpelainen from comment #31) > 3. Fixing env shebangs should not be required in Fedora anymore. If this is > still needed for some reason (RHEL perhaps?), comment should be updated to > match > > > # Fedora using Rubypick > > sed -i -e 's|#!/usr/bin/env ruby|#!/usr/bin/ruby|; s|#!/bin/env > > ruby|#!/usr/bin/ruby|;' \ > whatweb plugin-development/find-common-stuff > plugin-development/get-pattern > > Reference: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/ > #_shebang_lines > This does not say using env on shabang is permitted. The above guideline says when the package really needs jruby, you can write "#!/usr/bin/jruby" on shebang (but I don't think jruby on Fedora is well-maintained). All other should use "#!/usr/bin/ruby" on shebang. Anyway env should not be used on shebang. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978
Michal Ambroz changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|needinfo?(re...@seznam.cz) |needinfo?(otu...@iki.fi)
--- Comment #32 from Michal Ambroz ---
(In reply to Otto Urpelainen from comment #31)
SPEC URL: http://rebus.fedorapeople.org/SPECS/whatweb.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/whatweb-0.5.5-2.fc34.src.rpm
> 1. What is the intent of fragment part #/%{name}-%{version}.tar.gz?
> > Source0:
> > https://github.com/%{gituser}/%{gitname}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
when you download with the spectool -g whatweb.spec, this is what renames
boring v5.5.0.tar.gz to sexy whatweb-5.5.0.tar.gz
> 2. Better %{_bindir}/ruby, since that is how rubypick package provides this
> > Requires: /usr/bin/ruby
Ok ... thanks
> 3. Fixing env shebangs should not be required in Fedora anymore. If this is
> still needed for some reason (RHEL perhaps?), comment should be updated to
> match
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_shebang_lines
I consider env to be potential security problem and preffer to be explicit
about the interpreter used in the packaged stuff.
The guide is saying as well that it SHOULD use #!/usr/bin/ruby .
The "env ruby" is not always only /usr/bin/ruby. Depending on environment
settings it could be also /usr/local/bin/ruby or ~user/bin/ruby or even
/tmp/you_have_been_hacked/ruby .
> 4. I do not understand this. Is this an issue with upstream man pages? If
> so, a fix or an issue should be submitted and referenced from the specfile.
>
> > # Unknown macros in manpage
> > sed -i -e 's|^.ni||; s|^\./plugins-disabled|+\./plugins-disabled|' whatweb.1
Yes ... I guess that on Ubuntu they use different groff for formatting the man
pages so it is ok for them.
On Fedora it complains so I have to remove that tags.
> 5. Is this still needed? PR282 has been merged before 0.5.5 was released, so
> it should be ok. Again, if this is an upstream issue, a bug report or pull
> request should be referenced from here. If Fedora-specific, the situation
> should be explained.
>
> > # Add the whatweb shared directory + PR282
> > sed -i -e "s|expand_path(__dir__)), '.')|expand_path(__dir__)),
> > '%{_datadir}/%{name}')|" whatweb
Yes still needed. I do not consider this ustream bug, but it relies to Fedora
packaging.
> 6. Are both this and the earlier sed call that commnents off 'bundle install'
> needed?
Nah ... Just the sed was working. The alias was not working I just forgot it
there - thanks, removing the alias.
> 7. This is not wrong, but could be handled with a single row
> %{_datadir}/%{name}/addons, which would own the directory and include it and
> all its content in one statement. The same goes for lib, plugins,
> my-plugins, plugin-development and plugin-disabled folders. Also, I wonder
> if a simple '%{_datadir}/%{name}' would correctly handle all this, is there
> something in there that you do not want to own & include?
At the time I was packaging I was probably trying to comply with the rule that
all directories must be owned.
So I was trying to explicitly list them.
These days yes %{_datadir}/%{name} would do.
> 8. There are tests in the source, but no %check in specfile. Tests should be
> run. If is it too difficult to get them run inside the buildsystem, then
> perhaps a %check section with commented off attempt and a comment explaining
> why they cannot be run? Reference:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites
During build there is no networking.
The site used for tests - https://whatweb.net/ - is down.
Adding conditional and comment to build with tests.
> 9. my-plugins and plugin-development folders look like material for plugin
> writing. Are they really needed at runtime? If not, they should not
> installed.
- my-plugins is meant for locally created plugins to separate them from the
dozens of others. Its installed by upstream and searched for local libs - I do
not want to change this.
- moved plugin-development to documentation
> 10. What about the shell scripts in addons folder? Are the intended to be
> run by the user? If so, they should be installed to %{_bindir}. If not, and
> are not otherwise needed at runtime, they should be dropped or perhaps moved
> to documentation.
- yes executables, but more like examples. Not core functionality.
- moved to documentation
> 11. Maybe a comment here explaining what is going on.
> Is it just that RHEL does not support Recommends?
Yes. RHEL7 doesn't know Recommends.
Commented.
> 12. Is the license really GPLv2 or is it GPLv2+? License is listed as such
> in upstream home page, but many (not all!) files like lib/logging.rb contain
> a notice that also allows any later version. You should probably co
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978
Otto Urpelainen changed:
What|Removed |Added
Flags||needinfo?(re...@seznam.cz)
--- Comment #31 from Otto Urpelainen ---
Reviewed, here are my findings. Some are clear and some just things I could not
immediately understand. Fix the parts that you agree with and explain what is
going on with others. I checked everything already, so after these are all
addressed, the review should be clear.
1. What is the intent of fragment part #/%{name}-%{version}.tar.gz? It seems to
me that it is simply ignored. If the idea is to indicate the name of downloaded
file, a comment would do better? Also, the macros in the fragment do not
resolve to the real filename from Content-Disposition http header at the
moment, since %{name} != %{gitname}
> Source0:
> https://github.com/%{gituser}/%{gitname}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
2. Better %{_bindir}/ruby, since that is how rubypick package provides this
> Requires: /usr/bin/ruby
References:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_effect_of_the_usrmove_fedora_feature
https://src.fedoraproject.org/rpms/rubypick/blob/rawhide/f/rubypick.spec
3. Fixing env shebangs should not be required in Fedora anymore. If this is
still needed for some reason (RHEL perhaps?), comment should be updated to
match
> # Fedora using Rubypick
> sed -i -e 's|#!/usr/bin/env ruby|#!/usr/bin/ruby|; s|#!/bin/env
> ruby|#!/usr/bin/ruby|;' \
whatweb plugin-development/find-common-stuff plugin-development/get-pattern
Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_shebang_lines
4. I do not understand this. Is this an issue with upstream man pages? If so, a
fix or an issue should be submitted and referenced from the specfile.
> # Unknown macros in manpage
> sed -i -e 's|^.ni||; s|^\./plugins-disabled|+\./plugins-disabled|' whatweb.1
5. Is this still needed? PR282 has been merged before 0.5.5 was released, so it
should be ok. Again, if this is an upstream issue, a bug report or pull request
should be referenced from here. If Fedora-specific, the situation should be
explained.
> # Add the whatweb shared directory + PR282
> sed -i -e "s|expand_path(__dir__)), '.')|expand_path(__dir__)),
> '%{_datadir}/%{name}')|" whatweb
6. Are both this and the earlier sed call that commnents off 'bundle install'
needed? Can bundler be disable with only one method? If this is really needed
here, a comment explaining what is going on would be good.
> alias bundle='echo'
7. This is not wrong, but could be handled with a single row
%{_datadir}/%{name}/addons, which would own the directory and include it and
all its content in one statement. The same goes for lib, plugins, my-plugins,
plugin-development and plugin-disabled folders. Also, I wonder if a simple
'%{_datadir}/%{name}' would correctly handle all this, is there something in
there that you do not want to own & include?
> %dir %{_datadir}/%{name}/addons
> ...
> %{_datadir}/%{name}/addons/*
8. There are tests in the source, but no %check in specfile. Tests should be
run. If is it too difficult to get them run inside the buildsystem, then
perhaps a %check section with commented off attempt and a comment explaining
why they cannot be run? Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites
9. my-plugins and plugin-development folders look like material for plugin
writing. Are they really needed at runtime? If not, they should not installed.
10. What about the shell scripts in addons folder? Are the intended to be run
by the user? If so, they should be installed to %{_bindir}. If not, and are not
otherwise needed at runtime, they should be dropped or perhaps moved to
documentation.
11. Maybe a comment here explaining what is going on. Is it just that RHEL does
not support Recommends?
> %if 0%{?rhel} && 0%{?rhel} <= 8
> Requires: rubygem-bson
> Requires: rubygem-mongo
> %else
> Recommends: rubygem-bson
> Recommends: rubygem-mongo
> %endif
12. Is the license really GPLv2 or is it GPLv2+? License is listed as such in
upstream home page, but many (not all!) files like lib/logging.rb contain a
notice that also allows any later version. You should probably contact upstream
to clarify the issue.
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-rev
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Otto Urpelainen changed: What|Removed |Added Assignee|nob...@fedoraproject.org|otu...@iki.fi Flags||fedora-review? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Flags|needinfo?(re...@seznam.cz) | --- Comment #30 from Michal Ambroz --- Hello Otto, no need to be sorry ... we are all just volunteers. And thank you if you would pick-up this review. Here is the current version : SPEC URL: http://rebus.fedorapeople.org/SPECS/whatweb.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/whatweb-0.5.5-1.fc33.src.rpm Here the scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=66434481 $ rpmlint whatweb-0.5.5-1.fc33.src.rpm whatweb-0.5.5-1.fc33.noarch.rpm whatweb.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Otto Urpelainen changed: What|Removed |Added CC||otu...@iki.fi Flags||needinfo?(re...@seznam.cz) --- Comment #29 from Otto Urpelainen --- I am sorry for the rough review experience of this package, even after the difficult issue of bundled dependencies got resolved. If you are still interested in getting WhatWeb packaged for Fedora, I can complete the review. If so, please update the spec and srpm to included the latest version so I can proceed to review. If you are not interested anymore, please either close this issue, or do nothing, in which case automation should close this issue in one month. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Randy Berry 's needinfo: Bug 587978: Review Request: whatweb - Web scanner to identify what websites are running https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #28 from Package Review --- This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978
--- Comment #26 from Michal Ambroz ---
SPEC URL: https://rebus.fedorapeople.org/SPECS/whatweb.spec
SRPM URL: https://rebus.fedorapeople.org/SRPMS/whatweb-0.4.9-1.fc27.src.rpm
Bump to current upstream release.
>[!]: MUST Each %files section contains %defattr if rpm < 4.4
defattr removed
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
cleaning of the buildroot removed
>[!]: MUST Sources used to build the package match the upstream source, as
The release should MD5 match much better than git commit ad-hoc snapshot
(please note that gzip contains timestamps so it might not be MD5 same).
>[!]: SHOULD Buildroot is not present
removed
>[!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
removed
>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
link to release source is now resulting in whatweb-0.4.9.tar.gz
>[!]: SHOULD Spec use %global instead of %define.
define changed to global
Best regards
Michal Ambroz
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #25 from Michal Ambroz --- SPEC URL: https://rebus.fedorapeople.org/SPECS/whatweb.spec SRPM URL: https://rebus.fedorapeople.org/SRPMS/whatweb-0.4.8-0.git20160611.1.fc23.src.rpm Bump to current git snapshot. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #24 from Pavel Alexeev (aka Pahan-Hubbitus) --- Ping? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #23 from Michal Ambroz --- SPEC URL: http://rebus.fedorapeople.org/SPECS/whatweb.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/whatweb-0.4.8-0.git20150507.48b9682.1.fc21.src.rpm Bump to current git snapshot. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Bug 587978 depends on bug 632919, which changed state. Bug 632919 Summary: Review Request: rubygem-anemone - Anemone web-spider framework https://bugzilla.redhat.com/show_bug.cgi?id=632919 What|Old Value |New Value Resolution||WONTFIX Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2012-04-16 21:10:54 --- Comment #18 from Michal Ambroz 2012-04-16 21:10:54 EDT --- I am sorry - It is not in my powers to separate the anemone library from the package. The package works for me as is and separation is not supported by the upstream. I am stepping down from pushing this package to Fedora. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #17 from Michal Ambroz 2011-04-05 18:27:47 EDT --- New version of whatweb released. This version requires embedded old patched version of anemone. http://rebus.fedorapeople.org/SPECS/whatweb.spec http://rebus.fedorapeople.org/RPMS/whatweb-0.4.7-1.fc14.noarch.rpm http://rebus.fedorapeople.org/SRPMS/whatweb-0.4.7-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Flag|needinfo?(re...@seznam.cz) | --- Comment #16 from Michal Ambroz 2011-03-27 19:16:46 EDT --- New version of whatweb released. This version still requires embedded old patched version of anemone. http://rebus.fedorapeople.org/RPMS/whatweb-0.4.6-1.fc14.noarch.rpm http://rebus.fedorapeople.org/SPECS/whatweb.spec http://rebus.fedorapeople.org/SRPMS/whatweb-0.4.6-1.fc14.src.rpm Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #15 from Bug Zapper 2010-11-03 11:52:32 EDT --- This message is a reminder that Fedora 12 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 12. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '12'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 12's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 12 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Jason Tibbitts changed: What|Removed |Added Version|12 |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #14 from Michal Ambroz 2010-09-22 20:03:06 EDT --- Whatweb doesn't work with the upstream anemone version. Issue reported to whatweb developer, waiting for fix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Mamoru Tasaka changed: What|Removed |Added Depends on|632912 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Bug 587978 depends on bug 632917, which changed state. Bug 632917 Summary: Review Request: rubygem-shoulda - Making ruby tests easy on the fingers and eyes https://bugzilla.redhat.com/show_bug.cgi?id=632917 What|Old Value |New Value Resolution||DUPLICATE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #13 from Michal Ambroz 2010-09-11 18:53:08 EDT --- SPEC URL: http://rebus.fedorapeople.org/SPECS/whatweb.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/whatweb-0.4.5-2.fc13.src.rpm Patch to use system-wide rubygems anemone library rather than local copy of anemone library. Koji F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2462168 $ rpmlint whatweb-0.4.5-2.fc13.src.rpm whatweb-0.4.5-2.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Depends on||632919 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #12 from Michal Ambroz 2010-09-11 18:24:22 EDT --- I have submitted for review package rubygems-anemone, which is needed for whatweb. Bug 632919 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #11 from Michal Ambroz 2010-09-11 17:52:29 EDT --- U have submitted for review package rubygems-shoulda, which is needed for rubygems-robots, which is needed for rubygems-anemone. Bug 632917. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Depends on||632917 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Michal Ambroz changed: What|Removed |Added Depends on||632912 Flag|needinfo?(re...@seznam.cz) | --- Comment #10 from Michal Ambroz 2010-09-11 16:52:46 EDT --- U have submitted for review package rubygems-robots, which is needed for rubygems-anemone. Bug 632912. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(re...@seznam.cz) --- Comment #9 from Mamoru Tasaka 2010-09-11 12:15:00 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #8 from Mamoru Tasaka 2010-08-30 14:05:07 EDT --- (In reply to comment #7) > I still didn't manage to patch to separate anemone library from whatweb. > First please submit rubygem-anemome review request. Then I guess replacing require 'lib/anemone/anemone.rb' in whatweb script to require 'rubygems' require 'anemone' should work (if anemone 0.4.0 still supports anemone 0.2.0 API: anemone bundled in whatweb 0.4.5 is 0.2.0, while the latest anemone is 0.4.0) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #7 from Michal Ambroz 2010-08-23 18:24:53 EDT --- SPEC URL: http://rebus.fedorapeople.org/13/SPECS/whatweb.spec SRPM URL: http://rebus.fedorapeople.org/13/SRPMS/whatweb-0.4.5-1.fc13.src.rpm Rebuild of new version 0.4.5 of whatweb. I still didn't manage to patch to separate anemone library from whatweb. Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #6 from Michal Ambroz 2010-05-03 05:02:11 EDT --- Hello Mamoru, thank you for your comments. I will consider packing anemone and patching the whatweb to use sytem library of anemone. (In reply to comment #4) > https://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries I believe this link is not relevant as there is currenlty no anemone library in Fedora. >https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries However according this there probably should be one. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #5 from Mamoru Tasaka 2010-05-03 00:26:07 EDT --- As written on the above URLs, one of the biggest reasons is that when a new version of the package is released for (security) bug fixes or so, it gets very hard for us to track if such bug fixes are also applied to ones internally bundled in other packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #4 from Mamoru Tasaka 2010-05-03 00:20:22 EDT --- (In reply to comment #3) > (In reply to comment #1) > (In reply to comment #2) > > You should package anemone seperately: > > http://anemone.rubyforge.org/ > Original anemone project has got some extra dependencies. > Version present in whatweb is standalone patched version of anemone without > some dependencies. So please explain why you want to avoid additional dependency for this package. I don't think that so huge additonal dependency will be added. Using copy of external project is generally forbidden on Fedora and it should be packaged: https://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #3 from Michal Ambroz 2010-05-02 17:54:59 EDT --- (In reply to comment #1) > Add dep on ruby: Strange - I wanted to add dependency by following guideline for ruby. Apparently it was not enough adding the: Requires: ruby(abi) = 1.8 Thank you Terje for noticing that - I will add file dependency for ruby binary as well. SPEC URL: http://rebus.fedorapeople.org/12/SPECS/whatweb.spec SRPM URL: http://rebus.fedorapeople.org/12/SRPMS/whatweb-0.4.2-2.fc12.src.rpm (In reply to comment #2) > You should package anemone seperately: > http://anemone.rubyforge.org/ Original anemone project has got some extra dependencies. Version present in whatweb is standalone patched version of anemone without some dependencies. Best regards. Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Mamoru Tasaka changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #2 from Mamoru Tasaka 2010-05-02 14:32:49 EDT --- You should package anemone seperately: http://anemone.rubyforge.org/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587978 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #1 from Terje Røsten 2010-05-02 14:18:25 EDT --- Add dep on ruby: $ whatweb /usr/bin/env: ruby: No such file or directory -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
