[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Jason Tibbitts changed: What|Removed |Added Status Whiteboard|StalledSubmitter| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Jesus M. Rodriguez changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED Last Closed||2010-11-18 09:51:41 --- Comment #14 from Jesus M. Rodriguez 2010-11-18 09:51:41 EST --- This initially started as a dependency for rubygem-buildr. It is no longer needed for that. We can cancel this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Jason Tibbitts changed: What|Removed |Added Status Whiteboard||StalledSubmitter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(ayo...@redhat.com ||) --- Comment #12 from Mamoru Tasaka 2010-05-21 12:43:44 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Adam Young changed: What|Removed |Added Flag|needinfo?(ayo...@redhat.com | |) | --- Comment #13 from Adam Young 2010-05-21 12:48:11 EDT --- Just one of many buildr related rubygems. PLus, I've been diverted to other tasks. I'll get to this, or someone from the candlepin team will, in the near future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #11 from Mamoru Tasaka 2010-05-12 12:49:14 EDT --- One more - .gitignore file is not needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=588437
--- Comment #10 from Mamoru Tasaka 2010-05-12
12:21:41 EDT ---
For -2:
* Unused macro / consistent macro usage
- %ruby_sitelib macro seems to be used no where.
- %geminstdir should also be used also in %check.
* The place of documents
- I don't see any reason you should move README.markdown or
so to under %{_defaultdocdir}
* Documents
- CONTRIBUTORS, Rakefile files should be marked as %doc.
- spec/ test/ directories should also be marked as %doc.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #9 from Adam Young 2010-05-11 15:53:15 EDT --- Sorry for that. http://admiyo.fedorapeople.org/buildr-repo/rubygem-fakefs-0.2.1-2.young.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #8 from Mamoru Tasaka 2010-05-11 15:11:03 EDT --- Please post the URL of srpm, not rebuilt binary rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #7 from Adam Young 2010-05-11 12:25:38 EDT --- Updated with changes noted above. Please confirm that my apporach to handling the docs is correct. http://github.com/admiyo/MySpecs/blob/ade6668b8ca6c54dc75e0e8377b3d3d00f197854/rubygem-fakefs.spec http://admiyo.fedorapeople.org/buildr-repo/rubygem-fakefs-0.2.1-2.young.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #6 from Mamoru Tasaka 2010-05-07 13:20:24 EDT --- Just a reminder: Every time you modify your spec file, please - change the release number to avoid confusion - add proper %changelog entry - post the URLs of new srpm / spec on the review request bug ( please post ! ) Otherwise no one will notice you did some work after (potential) reviewer added a comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Adam Young changed: What|Removed |Added Blocks||588406 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #5 from Mamoru Tasaka 2010-05-05 15:24:13 EDT --- "LICENSE" text clearly shows this is under MIT (if you are saying gem2rpm returned the license is under GPLv2 or Ruby, please don't rely on it) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #4 from Adam Young 2010-05-05 14:55:28 EDT --- Are you sure about the MIT License? I see the commit message in the Upstream repo that it was added, but the Gem Has "GPL2 or Ruby" in it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #3 from Mamoru Tasaka 2010-05-05 14:24:36 EDT --- (In reply to comment #1) > * License > - is MIT for Ah... I meant "License is MIT for this package". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 --- Comment #2 from Adam Young 2010-05-05 14:15:52 EDT --- Thanks, Mamoru. I'm assuming that most of these comments apply for the other gem2rpm packages that I have submitted. I'll update each of those bugs once I've corrected them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Mamoru Tasaka changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #1 from Mamoru Tasaka 2010-05-05 13:40:58 EDT --- Some notes: * %define -> %global - We now prefer to use %global instead of %define. https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * License - is MIT for * BuildRoot - On Fedora BuildRoot is no longer needed (rpmlint may complain about removing this, however you can ignore it) * abi requirements - Writing "Requires: ruby(abi) = 1.8" is mandatory https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * Test - As this gem contains test/ directory, please add %check section and execute some tests there (like $ rake test) - Also as this gem contains spec/ directory, executing $rake spec is preferred. * Duplicate files https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files 57 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fakefs-0.2.1/LICENSE 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fakefs-0.2.1/README.markdown - Please make it sure that every file is listed only once in %files section. * Consistent macro usage - As %geminstdir macro is defined, please use this macro in %files consistently. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
